From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=hkWEZ9PA; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id EB1EA5A0008 for ; Tue, 15 Apr 2025 21:10:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744744219; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SADSfiXsz9xSzcIcmhtipU7mojK2Q9uU94ZmTYT4bw8=; b=hkWEZ9PA6p5aW6RaDvAKYZBPUGlVgEIzLzWKBNlCOD/gmReB8uXQG81rPA2yAXvhb4V8fb dULXaqbLcezfAkGTKUyV7N8greXR7hZipFA1mt+sAaTFmsjw9NPQtOI3SwrgbdlCsEVXpF Bhix0SAuqUTlva8EaCp/vMNVDvy4fqc= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-674-mGtRUVb9PFS1AiAkyUeOaQ-1; Tue, 15 Apr 2025 15:10:18 -0400 X-MC-Unique: mGtRUVb9PFS1AiAkyUeOaQ-1 X-Mimecast-MFC-AGG-ID: mGtRUVb9PFS1AiAkyUeOaQ_1744744217 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43cec217977so35370365e9.0 for ; Tue, 15 Apr 2025 12:10:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744744217; x=1745349017; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=SADSfiXsz9xSzcIcmhtipU7mojK2Q9uU94ZmTYT4bw8=; b=LlWX+EUT8aLYKxuaPKDJ0wine0SWyry/0wCitORrafhg2dL63dTM8K2jGCTv/I1Jub 6tQOA8dHu+TWpzOTylJMNLhwmVFqxzEK6iyqWm+i9TADD/hrDOWizCfODYzsdHz/V6CD bNBlcaQ7695oMS4ddPtvyulU/XeqI4kgYmfOHppJOGP/GMU0zz6YlJ1zD4iH4b7vbYSJ ykHUmZ61v26oOZchsdVNxUYeoeTdt1gAqehelxjItTbxnuqSMdQNSr7JuOI1oyS7EEZ3 +6OSqMLKi1+Ehm2MU82QcuguZAPJ/MuLZLQrCiV6Ql3dTGboj5nRAkOxdJgxvtLNfX2m fRdg== X-Gm-Message-State: AOJu0Yz1alf2UrOE/iIy8ttbkXMBiI2jTIimPZ4y0i73jyTM9vIML1HP OFZ8GPIkeyCog54PVQrpF6IWa5+VSJtrbWMrZ2sdiaCOd1OgbTwI0PDoiWe/f64tiSeM3GVapJQ z2FRImAMouyOXwsek8p31tK0Jv7r1WOlXc1UsQY4foJ6LgXI0pg== X-Gm-Gg: ASbGncs6Gr7+Fj+xgsEOER/mPN9TYNukXi21+W8xNtGJUlYxMCTM5ZHlMbgr5UB2ifG U2Sr/XrlhpQHBifdNrlMdnv49ZDBeEWWTxnkeOWyNl+QuBA4m8/XcZDwvACV+SGqbfbp37tyKn+ pdeILEWXXcfMpUMDAitQ0D+8ft3hTu5ORsd/CTPbEoG+X48Qr2cfkVqpXx4rbgghvnRCIb4Z7+h D9hRXO6Nj3rODwLhvElQC3TXPObGth+Esq/YnGH9VowmpQD51OPKXad7hU0WlBxzn9ttHojNVZf 576k3zIXbBbTZPi8AX7AvIE= X-Received: by 2002:a5d:64ad:0:b0:38f:3a89:fdb5 with SMTP id ffacd0b85a97d-39ee272a1aemr590311f8f.11.1744744217100; Tue, 15 Apr 2025 12:10:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHE8/mJ91j6lJWqPTMP9k76QBnXmIqBg6VzPNRjIoKbKp4JB8Mu0UfLejo6TFGiWTedxjuBHg== X-Received: by 2002:a5d:64ad:0:b0:38f:3a89:fdb5 with SMTP id ffacd0b85a97d-39ee272a1aemr590304f8f.11.1744744216762; Tue, 15 Apr 2025 12:10:16 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39eae96400dsm15300316f8f.11.2025.04.15.12.10.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Apr 2025 12:10:16 -0700 (PDT) Date: Tue, 15 Apr 2025 21:10:15 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 0/7] Assorted fixes for UDP socket and error handling problems Message-ID: <20250415211015.4273fd28@elisabeth> In-Reply-To: <20250415071624.2618589-1-david@gibson.dropbear.id.au> References: <20250415071624.2618589-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: u3Ji3O8LWUBkXxtGXlTxuaEMPEZMubmQqoQEUf66ee0_1744744217 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: FEH6NOW4WJXVLVWTXXYSJZLZEEMFQ3HI X-Message-ID-Hash: FEH6NOW4WJXVLVWTXXYSJZLZEEMFQ3HI X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Jon Maloy X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 15 Apr 2025 17:16:17 +1000 David Gibson wrote: > My recent changes to UDP socket management caused some unfortunate > side effects. In particular, it has some bad interactions with UDP > error handling. Fix several bugs here, along with some reworks to > allow that. > > David Gibson (7): > udp: Fix breakage of UDP error handling by PKTINFO support > udp: Be quieter about errors on UDP receive > udp: Pass socket & flow information direction to error handling > functions > udp: Deal with errors as we go in udp_sock_fwd() > udp: Add udp_pktinfo() helper > udp: Minor re-organisation of udp_sock_recverr() > udp: Propagate errors on listening and brand new sockets Applied with minor changes as described for 5/7 and 7/7. -- Stefano