From: Laurent Vivier <lvivier@redhat.com>
To: passt-dev@passt.top
Cc: Laurent Vivier <lvivier@redhat.com>
Subject: [PATCH v4 21/28] arp: use iov_tail rather than pool
Date: Wed, 16 Apr 2025 17:25:58 +0200 [thread overview]
Message-ID: <20250416152605.3947623-22-lvivier@redhat.com> (raw)
In-Reply-To: <20250416152605.3947623-1-lvivier@redhat.com>
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
arp.c | 14 +++++---------
arp.h | 2 +-
tap.c | 5 +----
tap.h | 1 +
4 files changed, 8 insertions(+), 14 deletions(-)
diff --git a/arp.c b/arp.c
index 4cb6965e9793..f979ad260275 100644
--- a/arp.c
+++ b/arp.c
@@ -63,11 +63,11 @@ static bool ignore_arp(const struct ctx *c,
/**
* arp() - Check if this is a supported ARP message, reply as needed
* @c: Execution context
- * @p: Packet pool, single packet with Ethernet buffer
+ * @data: Single packet with Ethernet buffer
*
* Return: 1 if handled, -1 on failure
*/
-int arp(const struct ctx *c, const struct pool *p)
+int arp(const struct ctx *c, struct iov_tail *data)
{
struct {
struct ethhdr eh;
@@ -77,17 +77,13 @@ int arp(const struct ctx *c, const struct pool *p)
const struct ethhdr *eh;
const struct arphdr *ah;
const struct arpmsg *am;
- struct iov_tail data;
struct arphdr ahc;
struct ethhdr ehc;
struct arpmsg amc;
- if (!packet_data(p, 0, &data))
- return -1;
-
- eh = IOV_REMOVE_HEADER(&data, ehc);
- ah = IOV_REMOVE_HEADER(&data, ahc);
- am = IOV_REMOVE_HEADER(&data, amc);
+ eh = IOV_REMOVE_HEADER(data, ehc);
+ ah = IOV_REMOVE_HEADER(data, ahc);
+ am = IOV_REMOVE_HEADER(data, amc);
if (!eh || !ah || !am)
return -1;
diff --git a/arp.h b/arp.h
index ac5cd16e47f4..86bcbf878eda 100644
--- a/arp.h
+++ b/arp.h
@@ -20,6 +20,6 @@ struct arpmsg {
unsigned char tip[4];
} __attribute__((__packed__));
-int arp(const struct ctx *c, const struct pool *p);
+int arp(const struct ctx *c, struct iov_tail *data);
#endif /* ARP_H */
diff --git a/tap.c b/tap.c
index 56b8cb21d9dd..b1c817451031 100644
--- a/tap.c
+++ b/tap.c
@@ -720,10 +720,7 @@ resume:
if (!eh)
continue;
if (ntohs(eh->h_proto) == ETH_P_ARP) {
- PACKET_POOL_P(pkt, 1, in->buf, in->buf_size);
-
- packet_add(pkt, &data);
- arp(c, pkt);
+ arp(c, &data);
continue;
}
diff --git a/tap.h b/tap.h
index 954ad440a287..095190eea44e 100644
--- a/tap.h
+++ b/tap.h
@@ -115,6 +115,7 @@ void tap_handler_passt(struct ctx *c, uint32_t events,
const struct timespec *now);
int tap_sock_unix_open(char *sock_path);
void tap_sock_reset(struct ctx *c);
+void tap_sock_set_mr(struct vhost_user_memory *mr, int nb);
void tap_sock_update_pool(void *base, size_t size);
void tap_backend_init(struct ctx *c);
void tap_flush_pools(void);
--
@@ -115,6 +115,7 @@ void tap_handler_passt(struct ctx *c, uint32_t events,
const struct timespec *now);
int tap_sock_unix_open(char *sock_path);
void tap_sock_reset(struct ctx *c);
+void tap_sock_set_mr(struct vhost_user_memory *mr, int nb);
void tap_sock_update_pool(void *base, size_t size);
void tap_backend_init(struct ctx *c);
void tap_flush_pools(void);
--
2.49.0
next prev parent reply other threads:[~2025-04-16 15:26 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 15:25 [PATCH v4 00/28] Introduce discontiguous frames management Laurent Vivier
2025-04-16 15:25 ` [PATCH v4 01/28] arp: Don't mix incoming and outgoing buffers Laurent Vivier
2025-04-16 15:25 ` [PATCH v4 02/28] iov: Introduce iov_slice(), iov_tail_slice() and iov_tail_drop() Laurent Vivier
2025-04-16 15:25 ` [PATCH v4 03/28] iov: Update IOV_REMOVE_HEADER() and IOV_PEEK_HEADER() Laurent Vivier
2025-04-16 15:25 ` [PATCH v4 04/28] tap: Use iov_tail with tap_add_packet() Laurent Vivier
2025-04-16 15:25 ` [PATCH v4 05/28] packet: Use iov_tail with packet_add() Laurent Vivier
2025-04-16 15:25 ` [PATCH v4 06/28] packet: Add packet_data() Laurent Vivier
2025-04-16 15:25 ` [PATCH v4 07/28] arp: Convert to iov_tail Laurent Vivier
2025-04-16 15:25 ` [PATCH v4 08/28] ndp: " Laurent Vivier
2025-04-16 15:25 ` [PATCH v4 09/28] icmp: " Laurent Vivier
2025-04-16 15:25 ` [PATCH v4 10/28] udp: " Laurent Vivier
2025-04-16 15:25 ` [PATCH v4 11/28] tcp: Convert tcp_tap_handler() to use iov_tail Laurent Vivier
2025-04-16 15:25 ` [PATCH v4 12/28] tcp: Convert tcp_data_from_tap() " Laurent Vivier
2025-04-16 15:25 ` [PATCH v4 13/28] dhcpv6: move offset initialization out of dhcpv6_opt() Laurent Vivier
2025-04-16 15:25 ` [PATCH v4 14/28] dhcpv6: Extract sending of NotOnLink status Laurent Vivier
2025-04-16 15:25 ` [PATCH v4 15/28] dhcpv6: Convert to iov_tail Laurent Vivier
2025-04-16 15:25 ` [PATCH v4 16/28] dhcpv6: Use iov_tail in dhcpv6_opt() Laurent Vivier
2025-04-16 15:25 ` [PATCH v4 17/28] dhcp: Convert to iov_tail Laurent Vivier
2025-04-16 15:25 ` [PATCH v4 18/28] ip: Use iov_tail in ipv6_l4hdr() Laurent Vivier
2025-04-16 15:25 ` [PATCH v4 19/28] tap: Convert tap4_handler() to iov_tail Laurent Vivier
2025-04-16 15:25 ` [PATCH v4 20/28] tap: Convert tap6_handler() " Laurent Vivier
2025-04-16 15:25 ` Laurent Vivier [this message]
2025-04-16 15:25 ` [PATCH v4 22/28] dhcp: use iov_tail rather than pool Laurent Vivier
2025-04-16 15:26 ` [PATCH v4 23/28] dhcpv6: " Laurent Vivier
2025-04-16 15:26 ` [PATCH v4 24/28] icmp: " Laurent Vivier
2025-04-16 15:26 ` [PATCH v4 25/28] ndp: " Laurent Vivier
2025-04-16 15:26 ` [PATCH v4 26/28] packet: remove PACKET_POOL() and PACKET_POOL_P() Laurent Vivier
2025-04-16 15:26 ` [PATCH v4 27/28] packet: remove unused parameter from PACKET_POOL_DECL() Laurent Vivier
2025-04-16 15:26 ` [PATCH v4 28/28] packet: add memory regions information into pool Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250416152605.3947623-22-lvivier@redhat.com \
--to=lvivier@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).