From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=WvzFSzpP; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 441845A026F for ; Fri, 25 Apr 2025 08:27:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745562426; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nXE/H1HwKwE04f9vRH9BP7ly9Tsl+e5X0LvhinlJKcM=; b=WvzFSzpPgyPA7/iPGp6uV2VoS3c2hvWvQUn6It11oueCtrj9SVAUPUuZs9YHRGU7hbl99w rlPoRtOFMv9idQMzisgVLHQ72n7X8pAwmQPYMJB2GX6PAIer85vO3Hhh4zylSG1i4SVXbl Pyh/wUs+9+T1cQHOYbXlAULpalAzmmE= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-673-ltOKFBfPOMy7P5HQTcYQwQ-1; Fri, 25 Apr 2025 02:27:04 -0400 X-MC-Unique: ltOKFBfPOMy7P5HQTcYQwQ-1 X-Mimecast-MFC-AGG-ID: ltOKFBfPOMy7P5HQTcYQwQ_1745562423 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43efa869b0aso11394845e9.3 for ; Thu, 24 Apr 2025 23:27:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745562422; x=1746167222; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=nXE/H1HwKwE04f9vRH9BP7ly9Tsl+e5X0LvhinlJKcM=; b=jXTRi8Rt6xHP9V+V+I3pyBvdc9NTNTkpVleVyYYKyKaGC1ipSvec+06mSwCwFOfmBb wrRvxCL0RQLfd/EZmvHvvO3/MdkJBwQlMjYZQDc/lZlHtEn8Ze2oOrMikcQSV4dNMgbh XIl/6tOZK2UIjYxu6kXTno2QhZw7Tl4A8T1fqt6RdpXNnkyA34kafUzkfosMhnTBbhx7 kEjPuo3O2rCvh2gSIRJ6PStGafIEDxS6Hk8U5+KCOlvQbAObUGz1vCrzFM0LJvrxwfpv 1DlyLSG/5L7M+gUPG6wFCY/IrHaeM1VWM87HIEUXBZQyXCbzLuYd+e3tQAixGdi4LFuG mG/w== X-Gm-Message-State: AOJu0YwbaQrHsWFzS7MqbFz7C4m+xu2Cv7QkrSowjEhnoBV5rnC5h9Tt 9DoHcuh4PkuP6tpZ8G4N3TMJnuJszqwII5w1U7KHw+jzG21u7bzKfAv6mwslQ0G078e+kDzslV/ yaorzt00FX2MEBviwi+kXHtB24uMQfkPmPtXy0Gg/OYNNYgfLydxy5ChjDA== X-Gm-Gg: ASbGnctZcGMyvmIzhIcnDn8tVc13MsIBL2eVigNfiJGTKsjg1GdD+JnzNlz6OItOupB 7VF2H8+VXAoiM/kFIgmxaKQ22yfTasFtxzU5I3AXyAPYu5UcceBW7xrjnak6MUyLmbOR93LRH3W 954GSqlCIfnaE6xUq6j3YgA2s6BsqDMLo3VCiemRaBJC3id648gf3W3vUkIwZi1IRa/g+LTs4/s jQK6GL6go+Ruxj7fjoxItvU/uASKZn1g8GslMteTqygG6pSuUezQozAODyMosKQw/YirWJubkhW whZPpkR0xk/cIFzRmZnEVRNXw5IlYP4pJHj/PWeY X-Received: by 2002:a05:6000:400c:b0:39c:e28:5f0d with SMTP id ffacd0b85a97d-3a074e419e5mr673481f8f.25.1745562422186; Thu, 24 Apr 2025 23:27:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHizCRYM+x1wSUBG3CpovuA5unaSG6EY4/4GDzqzRD1samF0vjV8gVg5Xi/EbKyhteBlr0NVg== X-Received: by 2002:a05:6000:400c:b0:39c:e28:5f0d with SMTP id ffacd0b85a97d-3a074e419e5mr673473f8f.25.1745562421803; Thu, 24 Apr 2025 23:27:01 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4409d2d8343sm46039155e9.28.2025.04.24.23.27.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Apr 2025 23:27:01 -0700 (PDT) Date: Fri, 25 Apr 2025 08:27:00 +0200 From: Stefano Brivio To: passt-dev@passt.top Subject: Re: [PATCH 00/12] Use connect()ed sockets for both sides of UDP flows Message-ID: <20250425082700.0bbbf2a8@elisabeth> In-Reply-To: <20250404101542.3729316-1-david@gibson.dropbear.id.au> References: <20250404101542.3729316-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: hLLRPOM4N2r38bOCkKpiF3ieXT88WkYlR11fPIwB4Pg_1745562423 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: QOI6TP5NKG5EKOUYIWHBCWZ3WQ7GZ65B X-Message-ID-Hash: QOI6TP5NKG5EKOUYIWHBCWZ3WQ7GZ65B X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson , Jon Maloy X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 4 Apr 2025 21:15:30 +1100 David Gibson wrote: > As discussed, I've been working on using connect()ed sockets, rather > than dups of the listening sockets for handling traffic on the > initiating side of UDP flows. This improves consistency, avoids some > problems (bug 103) and will allow for some useful future improvements. > > It has the nice side effect of allowing some more code to be shared > between various paths, resulting in a pretty nice negative diffstat. > > David Gibson (12): > udp: Use connect()ed sockets for initiating side > udp: Make udp_sock_recv() take max number of frames as a parameter > udp: Polish udp_vu_sock_info() and remove from vu specific code > udp: Don't bother to batch datagrams from "listening" socket > udp: Parameterize number of datagrams handled by > udp_*_reply_sock_data() > udp: Split spliced forwarding path from udp_buf_reply_sock_data() > udp: Merge vhost-user and "buf" listening socket paths > udp: Move UDP_MAX_FRAMES to udp.c > udp_flow: Take pif and port as explicit parameters to > udp_flow_from_sock() > udp: Rework udp_listen_sock_data() into udp_sock_fwd() > udp: Fold udp_splice_prepare and udp_splice_send into udp_sock_to_sock > udp_flow: Don't discard packets that arrive between bind() and > connect() Just for the record: it's likely that something here made https://github.com/containers/podman/issues/25959 more visible (or directly caused it). I couldn't rule out recent ICMP changes yet, but I'm fairly sure it's not those. -- Stefano