public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: Alyssa Ross <hi@alyssa.is>
Cc: passt-dev@passt.top
Subject: Re: [PATCH] conf: allow --fd 0
Date: Mon, 28 Apr 2025 14:36:02 +0200	[thread overview]
Message-ID: <20250428143602.5130c64d@elisabeth> (raw)
In-Reply-To: <20250426084425.25940-1-hi@alyssa.is>

On Sat, 26 Apr 2025 10:44:25 +0200
Alyssa Ross <hi@alyssa.is> wrote:

> inetd-style socket passing traditionally starts a service with a
> connected socket on file descriptors 0 and 1.  passt disallowing
> obtaining its socket from either of these descriptors made it
> difficult to use with super-servers providing this interface — in my
> case I wanted to use passt with s6-ipcserver[1].

Hah, interesting usage, first report I've seen with s6. Is that to
dispatch passt processes for a network / set of guests or something?

> Since (as far as I can tell) passt does not use standard input for
> anything else (unlike standard output),

Correct (...and unlike standard error, too).

> it should be safe to relax the restrictions on --fd to allow setting
> it to 0, enabling this use case.
> 
> Link: https://skarnet.org/software/s6/s6-ipcserver.html [1]
> Signed-off-by: Alyssa Ross <hi@alyssa.is>

Applied, thanks for the patch, and welcome to the git log!

-- 
Stefano


  reply	other threads:[~2025-04-28 12:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-26  6:44 [PATCH] conf: allow --fd 0 Alyssa Ross
2025-04-28 12:36 ` Stefano Brivio [this message]
2025-04-28 15:49   ` Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250428143602.5130c64d@elisabeth \
    --to=sbrivio@redhat.com \
    --cc=hi@alyssa.is \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).