From: Stefano Brivio <sbrivio@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: passt-dev@passt.top
Subject: Re: [PATCH] flow: close socket fd on error
Date: Mon, 12 May 2025 23:20:50 +0200 [thread overview]
Message-ID: <20250512232050.1e54e0da@elisabeth> (raw)
In-Reply-To: <20250512164700.1309894-1-lvivier@redhat.com>
On Mon, 12 May 2025 18:47:00 +0200
Laurent Vivier <lvivier@redhat.com> wrote:
> In eea8a76caf85 ("flow: fix podman issue #26073"), we unregister
> the fd from epoll_ctl() in case of error, but we also need to close it.
>
> As flowside_sock_l4() also calls sock_l4_sa() via flowside_sock_splice()
> we can do it unconditionally.
The previous PIF_HOST check made sense to me because it excluded
PIF_TAP, not so much because it excluded PIF_SPLICE.
But anyway, we'll never reach here with anything that's not PIF_HOST
nor PIF_TAP (kind of by definition), and a spurious epoll_del() is
surely better than the alternative in any case...
> Fixes: eea8a76caf85 ("flow: fix podman issue #26073")
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Applied, thanks. New release coming soon.
--
Stefano
next prev parent reply other threads:[~2025-05-12 21:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-12 16:47 [PATCH] flow: close socket fd on error Laurent Vivier
2025-05-12 21:20 ` Stefano Brivio [this message]
2025-05-14 6:05 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250512232050.1e54e0da@elisabeth \
--to=sbrivio@redhat.com \
--cc=lvivier@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).