From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=f/m3Hr2q; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 3F9245A027E for ; Wed, 14 May 2025 09:08:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747206492; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iO/OK3Tn5LHvoXb6Q3ve0Wc13rSjcVWnEMYYlwL8TOo=; b=f/m3Hr2qPjSWpNGk7poCf7PuOBsZuvVaPnxkx0hg2odyILexlPqEkLWCGOUk46Zylwnt4b IcoZ+qBziWjWPfUSjdW35U0LH1XWj3kdmtboGNy7OBD0DpcgwvaZ1wtdd8EXmq6BUAm/oO grTC8zZZizyQTxO49rysa4wYxkr1o+c= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-94-lSfj34OtMh-kuA8N1aY5gQ-1; Wed, 14 May 2025 03:08:10 -0400 X-MC-Unique: lSfj34OtMh-kuA8N1aY5gQ-1 X-Mimecast-MFC-AGG-ID: lSfj34OtMh-kuA8N1aY5gQ_1747206489 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a0b589a2c6so2269988f8f.0 for ; Wed, 14 May 2025 00:08:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747206489; x=1747811289; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=iO/OK3Tn5LHvoXb6Q3ve0Wc13rSjcVWnEMYYlwL8TOo=; b=SwcZMv27ElKT+zRbafafmC3rT/EGbbCRqNjSrHGo6jklLYGMPRyHLWT2Vuywbj/5aV VVhMAiPEAJ4UG/1BKk+/+e6WxThKsWAI2sbstnSPCApg6yswdooL9ChafX6WHZNpVX1w EQzlmQOMKXgU0YWuTFs5C52zx+ipyD1bMkW2GuV4lJXrm2aP7qaT8p+ZE2nf31Ol4KWN xnqLhRKE4ELVLhO+KmL/52nnqzYL7DfLOMz6shLAVEDCiiGFLhgd+f4L0OpCK3FwJTc+ FLN9uDFjQgNgFDoCJg7ObTGqN05dTqhTyqjDiyVJPIO+GV3nKkBEb8m1IVJz+U342+zT fnKQ== X-Gm-Message-State: AOJu0YwRAp/ruc4dy67wkcklODc8240HaePzBY1MEl4FryMsHYZ2ZiMl gRnrt5mi702P+cAFxAcnJXUJilRaWHzN5tq4rK1AF8qxiuct+greHymYldbqrluuyEArgYab3uR tkU+0WrNmBVqDO2NEUiaQhEQc2IX58Sk9AOtiGLqCesFhyW/jIlBlBPH2BqekYmy7Tqj94GS+GE PDsPPPJVqNHPl3Z7J9aa7V35cPUlsIiQdY X-Gm-Gg: ASbGncv3wTeCFt6GWz06JaBdEuQdl92giMNx7e5fMf1Emo6cF2AUO9ughoNFO1UqAeI JmSIiXX3h3KRKT0IW+yJ3EeC0+hAZ0ZsZNXXejoRUwvWdQyQBLRmkW8CjLxV6BKhzHAlnuozTdI 1cAxyBhunCy1CL214WKZE1Bp2dElmGISJ28njy6m/3BQ2zLMFH2coOcj4fpvAeeUJt0K6HcYLdM HdVonQY6OTydF/syDr8GIYWbCBvKAEYZRpPElh8t9hR+Hf90SQi2PK0smRAJ4a9ZdKuBVllW60C ZctoxxAqezFZxJYslZ5PbUE= X-Received: by 2002:a05:6000:420c:b0:390:df75:ddc4 with SMTP id ffacd0b85a97d-3a34991da86mr1711843f8f.44.1747206489352; Wed, 14 May 2025 00:08:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG2ncLywhjLIuWlXXaha/iD48BxOSbIF/YzmlVbIrwRJcqJn1Yrwhms0Hcel3f/cPGHZtA9OQ== X-Received: by 2002:a05:6000:420c:b0:390:df75:ddc4 with SMTP id ffacd0b85a97d-3a34991da86mr1711801f8f.44.1747206488849; Wed, 14 May 2025 00:08:08 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a1f5a4c5e1sm18348029f8f.89.2025.05.14.00.08.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 May 2025 00:08:08 -0700 (PDT) Date: Wed, 14 May 2025 09:08:07 +0200 From: Stefano Brivio To: Laurent Vivier Subject: Re: [PATCH] test: Display count of skipped tests in status and summary Message-ID: <20250514090807.00c9197a@elisabeth> In-Reply-To: <20250514064129.3375592-1-lvivier@redhat.com> References: <20250514064129.3375592-1-lvivier@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 4i2oN_VL9BOctPwp140sanTq1fGTJ50gw29ulATXax4_1747206489 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: SR2R3KABPABLEF6KIP5SXUUIZ4CR4AWC X-Message-ID-Hash: SR2R3KABPABLEF6KIP5SXUUIZ4CR4AWC X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 14 May 2025 08:41:29 +0200 Laurent Vivier wrote: > This commit enhances test reporting by tracking and displaying the > number of skipped tests. > > The skipped test count is now visible in the tmux status bar during > execution and included in the final test summary log. This provides > a more complete overview of test suite results. Makes sense, thanks, just one nit: > > Signed-off-by: Laurent Vivier > --- > test/lib/term | 7 +++++-- > test/run | 4 ++-- > 2 files changed, 7 insertions(+), 4 deletions(-) > > diff --git a/test/lib/term b/test/lib/term > index ed690de82c20..089364c67f85 100755 > --- a/test/lib/term > +++ b/test/lib/term > @@ -19,6 +19,7 @@ STATUS_FILE_INDEX=0 > STATUS_COLS= > STATUS_PASS=0 > STATUS_FAIL=0 > +STATUS_SKIPPED=0 > > PR_RED='\033[1;31m' > PR_GREEN='\033[1;32m' > @@ -439,19 +440,21 @@ info_layout() { > # status_test_ok() - Update counter of passed tests, log and display message > status_test_ok() { > STATUS_PASS=$((STATUS_PASS + 1)) > - tmux set status-right "PASS: ${STATUS_PASS} | FAIL: ${STATUS_FAIL} | #(TZ="UTC" date -Iseconds)" > + tmux set status-right "PASS: ${STATUS_PASS} | FAIL: ${STATUS_FAIL} | SKIPPED: ${STATUS_SKIPPED} | #(TZ="UTC" date -Iseconds)" > info_passed > } > > # status_test_fail() - Update counter of failed tests, log and display message > status_test_fail() { > STATUS_FAIL=$((STATUS_FAIL + 1)) > - tmux set status-right "PASS: ${STATUS_PASS} | FAIL: ${STATUS_FAIL} | #(TZ="UTC" date -Iseconds)" > + tmux set status-right "PASS: ${STATUS_PASS} | FAIL: ${STATUS_FAIL} | SKIPPED: ${STATUS_SKIPPED} | #(TZ="UTC" date -Iseconds)" > info_failed > } > > # status_test_fail() - Update counter of failed tests, log and display message > status_test_skip() { > + STATUS_SKIPPED=$((STATUS_SKIPPED + 1)) > + tmux set status-right "PASS: ${STATUS_PASS} | FAIL: ${STATUS_FAIL} | SKIPPED: ${STATUS_SKIPPED} | #(TZ="UTC" date -Iseconds)" > info_skipped > } > > diff --git a/test/run b/test/run > index 4e86f30fb750..a6070d28e8c4 100755 > --- a/test/run > +++ b/test/run > @@ -202,7 +202,7 @@ skip_distro() { > perf_finish > [ ${CI} -eq 1 ] && video_stop > > - log "PASS: ${STATUS_PASS}, FAIL: ${STATUS_FAIL}" > + log "PASS: ${STATUS_PASS}, FAIL: ${STATUS_FAIL} SKIPPED: ${STATUS_SKIPPED}" Here, and below, the string is missing a comma before "SKIPPED". I can fix it up on merge if you prefer (or resend, as you wish). > > pause_continue \ > "Press any key to keep test session open" \ > @@ -236,7 +236,7 @@ run_selected() { > done > teardown "${__setup}" > > - log "PASS: ${STATUS_PASS}, FAIL: ${STATUS_FAIL}" > + log "PASS: ${STATUS_PASS}, FAIL: ${STATUS_FAIL} SKIPPED: ${STATUS_SKIPPED}" > > pause_continue \ > "Press any key to keep test session open" \ -- Stefano