From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=NEU4XK9Y; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 9A2325A027E for ; Wed, 14 May 2025 18:27:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747240036; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hC0Nlu5eCnEtNm4qeewmy8PuWfgZCVz1pdwSEiI/iXE=; b=NEU4XK9YqtEu4NKV7V0FaoQb9jnppg8BJH+8toigRbs5JqEScUP9YQiwzIvjFOj3PgnalK rHQjxOvlA1rdgYfZT8yu49/HTVOtjPZbAz1MGhptN2jL97ADT2bp2sOt6ZcuDYDAA4/4JZ SQLQcO9X9ywhLicfgHEWl5Xq156xXGE= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-681-dAPQnopKPMWNulVHBXoCwA-1; Wed, 14 May 2025 12:27:15 -0400 X-MC-Unique: dAPQnopKPMWNulVHBXoCwA-1 X-Mimecast-MFC-AGG-ID: dAPQnopKPMWNulVHBXoCwA_1747240034 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a0b7cd223fso4007797f8f.2 for ; Wed, 14 May 2025 09:27:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747240033; x=1747844833; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=hC0Nlu5eCnEtNm4qeewmy8PuWfgZCVz1pdwSEiI/iXE=; b=ODjhTnUNuCItSOA4Tehfit2mg2oyxS6QystwTA3JbbTRpTineYfzS+MBAvLp7OB7vt zQlstqjUSC+1DliQR43Q6SMTs6nVDfVFCGfH9KOjPtc+wKDyUE8wKuU68qDu7pQ9a/nh r9bmOdq9XDzA2SjDBIVCkLFkNiOWFk6moNvp6/V6UGLI1a86blaImx2zM5RWDbxxwSqZ Ai/dxX439QTiGqBKQAd06SVDGAyGxWME9C3zitmA+lBGr2vnHJFSm3PjMiXA0u5URd6E 7/rT1JAYjxZG/WBvzwVgBP1CeKp2fYyW1YBn8sL5sSr/ymp1gg17yiwGeBPFjqewzDnh mnLA== X-Gm-Message-State: AOJu0YwnMAsHa36qlfH1pzJsDPPgScQaNkT87wOVuljOjmd9e1pLxGf/ lMYtZpN0fmjk5skwotVHlSxP/qEgWXHkfotJEYabsf8QcmuOBC71Z8bo5uyhiMVv34GIZr1w4H+ XA6XXfQ0RzJ1kvJMHwmrdu06E/dCfgH0nWL7BOkFExquqOvmUStGtIzpqy2VG3E3Q8R7l5l/2cZ xDfr9btZVx93XAJTt6lDk8occpSZ9GKG/s X-Gm-Gg: ASbGncuU08yHb6RNdVwtG3lgPI699jaa2Hfxo1/4seGFEwKMXGgR/tsx4dVgCC1Ae9+ Mq66XlJHtc6/pkRfBCIyRAB8pWbnDATF+IDwr+x8tDJP3HlaAlqv6y9ni5nKn30AteNe9AkuWX1 Fd0fFt/u6FrtxTO6iiAoMBEjJIqkYhVNDll3vCxSu5WJl2S4ItefDFI4YwjBlK3dIIyiMfPOJd5 xbPw/v1lDdTaHnP03ArO2nxUXFYCRZFcN35eqbuHeUxtvrbgX2W5zktAKq5FGlWrYA/vWpscVXb NQJUCGcPXLvVjvga075Y5imfiP3o1g+v7Vna9IIP X-Received: by 2002:a05:6000:18a5:b0:3a0:830e:d1a8 with SMTP id ffacd0b85a97d-3a34991bdfcmr4004383f8f.46.1747240033315; Wed, 14 May 2025 09:27:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHN42NAMqgzn4WYcHuuaYZxe9J4+isIUWaBrnp9D5DxfO4DDP6qXo3jggv9BSxFheZ/N1oztA== X-Received: by 2002:a05:6000:18a5:b0:3a0:830e:d1a8 with SMTP id ffacd0b85a97d-3a34991bdfcmr4004358f8f.46.1747240032902; Wed, 14 May 2025 09:27:12 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a1f5a2d37fsm20511195f8f.68.2025.05.14.09.27.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 May 2025 09:27:12 -0700 (PDT) Date: Wed, 14 May 2025 18:27:09 +0200 From: Stefano Brivio To: Laurent Vivier Subject: Re: [PATCH 0/4] Fedora 42: Static Analysis and Compiler Warning Fixes Message-ID: <20250514182709.40745c6a@elisabeth> In-Reply-To: <20250513094102.1372330-1-lvivier@redhat.com> References: <20250513094102.1372330-1-lvivier@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: xbGOI9B8w592RVII-fiZAUAUyJcJmHJR8lE2rVw1mSE_1747240034 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: CKJ53NSVTXKVWVWU3AQH6TA5VVXXVXUG X-Message-ID-Hash: CKJ53NSVTXKVWVWU3AQH6TA5VVXXVXUG X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 13 May 2025 11:40:58 +0200 Laurent Vivier wrote: > This patch series addresses a collection of warnings and errors flagged > by GCC and Clang's static analyzer across various modules. The fixes > primarily involve clarifying code intent where warnings were false > positives or applying specific attributes to suppress warnings for > intentionally designed code constructs. > > The series consists of the following patches (in order of application): > > 1. **dhcpv6: fix GCC error (unterminated-string-initialization)** > Silences GCC error for an intentionally non-NUL-terminated string. > > 2. **virtio: Fix Clang warning (bugprone-sizeof-expression, cert-arr39-c)** > Justifies intentional `sizeof` usage in pointer arithmetic against Clang warnings. > > 3. **ndp: Fix Clang analyzer warning (clang-analyzer-security.PointerSub)** > Clarifies pointer subtraction as a valid C idiom for struct offset calculation. > > 4. **flow: fix clang error (clang-analyzer-security.PointerSub)** > Confirms pointers in `flow_idx()` reference the same array, validating subtraction. > > Laurent Vivier (4): > dhcpv6: fix GCC error (unterminated-string-initialization) > virtio: Fix Clang warning (bugprone-sizeof-expression, cert-arr39-c) > ndp: Fix Clang analyzer warning (clang-analyzer-security.PointerSub) > flow: Fix clang error (clang-analyzer-security.PointerSub) Applied. I also checked this against musl (with Clang) on Alpine, no new errors from 'make clang-tidy'. -- Stefano