public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: Eugenio Perez Martin <eperezma@redhat.com>
Cc: passt-dev@passt.top, Jason Wang <jasowang@redhat.com>,
	Jeff Nelson <jenelson@redhat.com>
Subject: Re: vhost-kernel net on pasta: from 26 to 37Gbit/s
Date: Wed, 21 May 2025 12:08:55 +0200	[thread overview]
Message-ID: <20250521120855.5cdaeb04@elisabeth> (raw)
In-Reply-To: <CAJaqyWcyT+jRwYEBkW=oz+ORMss0GHPj00ccofAxg13k=-+m0A@mail.gmail.com>

On Tue, 20 May 2025 17:09:44 +0200
Eugenio Perez Martin <eperezma@redhat.com> wrote:

> [...]
>
> Now if I isolate the vhost kernel thread [1] I get way more
> performance as expected:
> - - - - - - - - - - - - - - - - - - - - - - - - -
> [ ID] Interval           Transfer     Bitrate         Retr
> [  5]   0.00-10.00  sec  43.1 GBytes  37.1 Gbits/sec    0             sender
> [  5]   0.00-10.04  sec  43.1 GBytes  36.9 Gbits/sec                  receiver
> 
> After analyzing perf output, rep_movs_alternative is the most called
> function in the three iperf3 (~20%Self), passt.avx2 (~15%Self) and
> vhost (~15%Self)

Interesting... s/most called function/function using the most cycles/, I
suppose.

So it looks somewhat similar to

  https://archives.passt.top/passt-dev/20241017021027.2ac9ea53@elisabeth/

now?

> But I don't see any of them consuming 100% of CPU in
> top: pasta consumes ~85% %CPU, both iperf3 client and server consumes
> 60%, and vhost consumes ~53%.
> 
> So... I have mixed feelings about this :). By "default" it seems to
> have less performance, but my test is maybe too synthetic.

Well, surely we can't ask Podman users to pin specific stuff to given
CPU threads. :)

> There is room for improvement with the mentioned optimizations so I'd
> continue applying them, continuing with UDP and TCP zerocopy, and
> developing zerocopy vhost rx.

That definitely makes sense to me.

> With these numbers I think the series should not be
> merged at the moment. I could send it as RFC if you want but I've not
> applied the comments the first one received, POC style :).

I don't think it's really needed for you to spend time on
semi-polishing something just to have an RFC if you're still working on
it. I guess the implementation will change substantially anyway once
you factor in further optimisations.

-- 
Stefano


  parent reply	other threads:[~2025-05-21 10:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-20 15:09 vhost-kernel net on pasta: from 26 to 37Gbit/s Eugenio Perez Martin
2025-05-21  0:57 ` Jason Wang
2025-05-21  5:37   ` Eugenio Perez Martin
2025-05-21 10:08 ` Stefano Brivio [this message]
2025-05-21 10:35   ` Eugenio Perez Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250521120855.5cdaeb04@elisabeth \
    --to=sbrivio@redhat.com \
    --cc=eperezma@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=jenelson@redhat.com \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).