From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=elSyQb4P; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 27E245A0280 for ; Mon, 26 May 2025 16:19:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748269192; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ad7DAH8S1eAQr/oZr9OdKHordtCV1zDoBjVbLYIdEPU=; b=elSyQb4PoYYbI9wVmKs4GSyFk1Zq8VSf/EbIfR2VPPguMSzOqs9zQ5ANZiVdBpibaMWqoL IW3eIOehJXMbJD858MTP2kaQtXp756urvLFqJWob2THb0LNJmnGlw0VKUwLcHOF3hlnHiV 0Hckb2R44njI6PaYjPgxxRHXeo3L1+o= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-691-QC0f3WZQMVaOYv3ADPbLHQ-1; Mon, 26 May 2025 10:19:50 -0400 X-MC-Unique: QC0f3WZQMVaOYv3ADPbLHQ-1 X-Mimecast-MFC-AGG-ID: QC0f3WZQMVaOYv3ADPbLHQ_1748269190 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-442fa43e018so14878035e9.0 for ; Mon, 26 May 2025 07:19:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748269189; x=1748873989; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ad7DAH8S1eAQr/oZr9OdKHordtCV1zDoBjVbLYIdEPU=; b=UBQJrntizXU1IP1Oe/o+4j3878WQHXy+b+hk5DrdStsva5Uz5AMfImT+Lj4tS5x+SV eHVjLG7SYeItrUTSjC6Qn4F2MWGy51qWWPe33UjptdSkTRZ+a4fDFHOJNYBqeV9OuMNC eS5jOw3kyRfR4umuvw+acC2uazE/OFxZKsJGX439B5zvfkkMKxW/u7kH9nkL2UIvepk7 9jzGMqcdy81xMFNFc5mVmPfp0DjXs5944o+BL/vZnhRaNQOB0ABwNHYfmVyoLF+SjhDs TapIqjS6vyi9ocH1rK5TKQl9SNl763MBC6YGnLq/5B/J+o1arvXRFCiMtN66ZgxCxxGf jpOA== X-Gm-Message-State: AOJu0Yyoo+Gbe6eh30qaj8mc33l1UI0qFqFpJxG6Dczzyo+AgvzLEm2S LdjtMo9tWSHAlHkOVq/vQzdo+nTIgx4bV/tq8oxRcQbjZHaH8GMhn+85dPKM9GsH38jaeagB1XP 56H3EsJpnmmqSogpIagub4X4KcvkA2krz/pDAGDg+Xan6lTJ5Rk7n7A== X-Gm-Gg: ASbGncsQaoc9pz3YqtrcUG829LzbaHbYXIRVtJTovlsy1srjwf4i9H3eI8/rqO6E8l2 0Afpnt2dZR045Ub5V5861luOhVdxiLVJaDcINZMZ7M5n6pWIC8qrPPjWWewAqzQ9OKJF66jOmml 3fTghXuihRpFMq7JXHQfsu1Zy+yaQVZDvmk/e380J3wazwc3fUJMvKbj9ozwx+l0S4Y/KYNfRXT GG1RGmheaDcd6bvFhQZdaT7KaR1KNngJA2g5/CTv7cHuzxnMnJNVZnaGmT44gQalMUnT2pbBlIS HftCemXBnJglaa9W2daGpBo= X-Received: by 2002:a05:600c:4e45:b0:44a:b468:87b1 with SMTP id 5b1f17b1804b1-44c7a941ebamr79368085e9.4.1748269189669; Mon, 26 May 2025 07:19:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFiRh4Hh0f1nlyvU72lXrkZIYPs1ftyFYXRTKQsJvrj2lIhl05qOPWajsMOdgmtjGbM9wUKMA== X-Received: by 2002:a05:600c:4e45:b0:44a:b468:87b1 with SMTP id 5b1f17b1804b1-44c7a941ebamr79367865e9.4.1748269189320; Mon, 26 May 2025 07:19:49 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a35ca5a84csm35367668f8f.31.2025.05.26.07.19.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 May 2025 07:19:48 -0700 (PDT) Date: Mon, 26 May 2025 16:19:47 +0200 From: Stefano Brivio To: Laurent Vivier Subject: Re: [PATCH v5 07/29] arp: Convert to iov_tail Message-ID: <20250526161947.5f37c7ca@elisabeth> In-Reply-To: <20250417165136.2688884-8-lvivier@redhat.com> References: <20250417165136.2688884-1-lvivier@redhat.com> <20250417165136.2688884-8-lvivier@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 3z3z9_5Hkv489ip9ZAiinpBzT7lC3h7aBlAIxosYKRk_1748269190 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 2R6ZCDEDIKAJB6FBQLFAOPEHBIDMCXWM X-Message-ID-Hash: 2R6ZCDEDIKAJB6FBQLFAOPEHBIDMCXWM X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 17 Apr 2025 18:51:14 +0200 Laurent Vivier wrote: > Use packet_data() and extract headers using IOV_REMOVE_HEADER() > rather than packet_get(). > > Signed-off-by: Laurent Vivier > Reviewed-by: David Gibson > --- > arp.c | 12 +++++++++--- > packet.c | 1 - > 2 files changed, 9 insertions(+), 4 deletions(-) > > diff --git a/arp.c b/arp.c > index 9d68d7c3b602..4cb6965e9793 100644 > --- a/arp.c > +++ b/arp.c > @@ -77,11 +77,17 @@ int arp(const struct ctx *c, const struct pool *p) > const struct ethhdr *eh; > const struct arphdr *ah; > const struct arpmsg *am; > + struct iov_tail data; > + struct arphdr ahc; Nit: excess whitespace. > + struct ethhdr ehc; > + struct arpmsg amc; > > - eh = packet_get(p, 0, 0, sizeof(*eh), NULL); > - ah = packet_get(p, 0, sizeof(*eh), sizeof(*ah), NULL); > - am = packet_get(p, 0, sizeof(*eh) + sizeof(*ah), sizeof(*am), NULL); > + if (!packet_data(p, 0, &data)) > + return -1; > > + eh = IOV_REMOVE_HEADER(&data, ehc); > + ah = IOV_REMOVE_HEADER(&data, ahc); > + am = IOV_REMOVE_HEADER(&data, amc); That's quite neat! > if (!eh || !ah || !am) > return -1; > > diff --git a/packet.c b/packet.c > index 675bccf4d787..b6de869db176 100644 > --- a/packet.c > +++ b/packet.c > @@ -200,7 +200,6 @@ void *packet_get_do(const struct pool *p, const size_t idx, > * > * Return: true if @data contains valid data, false otherwise > */ > -/* cppcheck-suppress unusedFunction */ > bool packet_data_do(const struct pool *p, size_t idx, > struct iov_tail *data, > const char *func, int line) -- Stefano