From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=YqsDFNQg; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 486405A0281 for ; Mon, 26 May 2025 16:21:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748269278; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Nd4yS1Ptw+Rg2u0L1C7o9bC71KOUQZChb/cvEiDJtbo=; b=YqsDFNQg2ld1HBgmDK8BKHmXU9HQQfuilTxTjiDw9Hykj+ApaIDPsCSaE1sfdyURNKipw9 KpJBZUr9qQeOWG3bnoz5moN14Qpku5A1QWpgPO6tMsBImCPMOLSVs+cIUkUdoAxxe+6n/4 0ZS8+H69s+3GXmoM+QLprbm43Eqf+8w= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-599-hzdl5tgWP76zoj6EwXxxBQ-1; Mon, 26 May 2025 10:21:16 -0400 X-MC-Unique: hzdl5tgWP76zoj6EwXxxBQ-1 X-Mimecast-MFC-AGG-ID: hzdl5tgWP76zoj6EwXxxBQ_1748269276 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a3684a5655so1156427f8f.0 for ; Mon, 26 May 2025 07:21:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748269275; x=1748874075; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Nd4yS1Ptw+Rg2u0L1C7o9bC71KOUQZChb/cvEiDJtbo=; b=D5A3vvtM3b5MS8dJSPp+ytAEympDQOxqVWXflGGra26TtoxKirbud79iVa4uSz+K+1 gmoB8LPmoGwppt8bYZkEixfPGmzacnf397g7x9VEywDeZgaw08Nty+ZpSUetuSQ/9VZw SveFq47ohJtlCMK8BMWrrCxRSgbTzfzfpzYHvrREhKviyeep7XopAKOBu0doevjHq/82 g/og+4ZBh5N2xs68V1m7Zo7Ym3IhsOMIm6Ybui6HnuCzD/Q4hBZ8S8TGtTN41vkw31/x ihTnJWKj5Kk0Fe9SRXH4aWWIVercWXZWSLz2PJ2MoufFUkkQn2SLkfLEh2EzJiQ+pGlo FbOg== X-Gm-Message-State: AOJu0YzUdESYKifOatgY+11/ThnsSBZPRh8nNvhIIybB16PUbJ7lVDOb OCiu4RErKxvucOFX0bev4iu8RSi5edEWItdjqekAeJk5iy5tqsyY1nygRoF2lUfTzwlcPR4FPIp iV0jlOtz0+6t4hHhKqKru8ykQ1a20C494J6UqQ3fcFWBsyeOdxFrGdTJkrb9GdXs6MIUUMOGY1z 0T6snK/OmsJHWswzUO3d3A5sca9D8EJnHAlB+t X-Gm-Gg: ASbGnctA02cZveqYpVayGklZirugu2Zo5s/Wl1ws8Rg0Ev/VtG0QuzA84un1aKp8vKJ OcDEaRWf8/VAiCK02HjhFz9K9CKKbSIap2MKdXQd1jpvqpEHfgH/4zHf87NjyDswzV4bwiQx/V2 mhIp8bo4Jfbn5LF0GHJwVvvteV9B+4OrdQ9vzpZoCilA6Wq9xATKayNQ7Tg7gTbO/a+Je7TBct4 9GQQDWUfW0WIzJqAFmCCtSM3Ld0nOfc+WOHGDu3+s6si/aPiXU97fMv4TJADnKPDeMLW9zqQM1g 5roubeP53SYwsJldSMeY0XmfDhIKrkvsmu+vV2HG X-Received: by 2002:a05:6000:118a:b0:3a3:7ba5:9618 with SMTP id ffacd0b85a97d-3a4cb44edeemr5461232f8f.29.1748269275325; Mon, 26 May 2025 07:21:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGwNfCfsQzsseNFQXtOWGDt0nZm5o4o0iXFTwRGtCkFXsmbPSOflJrxWrxnDaGBTBdMbr+a2A== X-Received: by 2002:a05:6000:118a:b0:3a3:7ba5:9618 with SMTP id ffacd0b85a97d-3a4cb44edeemr5461207f8f.29.1748269274898; Mon, 26 May 2025 07:21:14 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a4cd0cf5c0sm7686852f8f.12.2025.05.26.07.21.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 May 2025 07:21:14 -0700 (PDT) Date: Mon, 26 May 2025 16:21:13 +0200 From: Stefano Brivio To: Laurent Vivier Subject: Re: [PATCH v5 23/29] dhcpv6: use iov_tail rather than pool Message-ID: <20250526162113.403c48e5@elisabeth> In-Reply-To: <20250417165136.2688884-24-lvivier@redhat.com> References: <20250417165136.2688884-1-lvivier@redhat.com> <20250417165136.2688884-24-lvivier@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: kO2rpSNcYqfu50mrvx7lWdQ4Lji80LECnWvrP4MF1b8_1748269276 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 2IS5FPKKIMWBWLXNY4O3C4CVVJEIZ75A X-Message-ID-Hash: 2IS5FPKKIMWBWLXNY4O3C4CVVJEIZ75A X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 17 Apr 2025 18:51:30 +0200 Laurent Vivier wrote: > Signed-off-by: Laurent Vivier > --- > dhcpv6.c | 29 +++++++++++++---------------- > dhcpv6.h | 2 +- > tap.c | 6 ++---- > 3 files changed, 16 insertions(+), 21 deletions(-) > > diff --git a/dhcpv6.c b/dhcpv6.c > index 365b609addda..d02eb59a08fa 100644 > --- a/dhcpv6.c > +++ b/dhcpv6.c > @@ -535,17 +535,17 @@ static size_t dhcpv6_client_fqdn_fill(const struct iov_tail *data, > /** > * dhcpv6() - Check if this is a DHCPv6 message, reply as needed > * @c: Execution context > - * @p: Packet pool, single packet starting from UDP header > + * @data Single packet starting from UDP header Nit: @data: > * @saddr: Source IPv6 address of original message > * @daddr: Destination IPv6 address of original message > * > * Return: 0 if it's not a DHCPv6 message, 1 if handled, -1 on failure > */ > -int dhcpv6(struct ctx *c, const struct pool *p, > +int dhcpv6(struct ctx *c, struct iov_tail *data, > const struct in6_addr *saddr, const struct in6_addr *daddr) > { > const struct opt_server_id *server_id = NULL; > - struct iov_tail data, opt, client_id_base; > + struct iov_tail opt, client_id_base; This should be moved one line below. -- Stefano