From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=CsD/ds3W; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 3BFA35A0281 for ; Mon, 26 May 2025 16:21:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748269286; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LYUAPsL/rsIiotEBkpAGqxGy9Dvcbk+qrRVvvA188JQ=; b=CsD/ds3WXRhPxe9ampNCLld+fqOangij5TQANad93g153XvB2VJ7pRpEHxxZluuEvH8aX9 47dVmghSl8uCpzfNp55pWKgPJYDTidq82di3IWBbn7Dfn9+2zKHnrpl1o6G0OZCgws1S3O 8yCARzc5/jd8ZflQrqCroVLeHoGlmKQ= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-134-1E02Xb09PV2Vw_X93azGxw-1; Mon, 26 May 2025 10:21:25 -0400 X-MC-Unique: 1E02Xb09PV2Vw_X93azGxw-1 X-Mimecast-MFC-AGG-ID: 1E02Xb09PV2Vw_X93azGxw_1748269284 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43eea5a5d80so14672725e9.1 for ; Mon, 26 May 2025 07:21:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748269283; x=1748874083; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=LYUAPsL/rsIiotEBkpAGqxGy9Dvcbk+qrRVvvA188JQ=; b=wrPJvncgHHxejwahrvTRK1TXIBGiyMNeLJoYz2Fq0du8OCA6zhLWI2pAOFMHa74X7i ubx3ai/Xw0yMmG9lfLSagPCBb4mhWvi/P+LAgiXK3RCNCBV9Rt4V7u9oQVCp8d4Nfa9Q Pui3GacnAQfOGFSXk6tMmL5bq3cK9tG2j3q3Gx/E5MCa544t6WImDbGJZYSR3wRhO4mX igZ0+QuVebCDE+F9TxnfW4MTWNTsqLiBwNjEVTIuJdAv5FVh4yLSrsBaRq4yqAOI1WeE f8kfUQfrKSiYI/M2iS8GgqXA8gvlw4MT9S5e4khbxxuoiMNmkqW/Rj1Y9c2ej4f48ZxK GWRQ== X-Gm-Message-State: AOJu0Yxx0OpU+U6k6MCGooY/4x5BwYpuKz7fKMCt/m2Vju8uZm/4Aof4 E3cEzvTOcr4C48GHdM9V0zBUiiTYBkw9qlmbZ+zQQpHVYVgEezcZE/hkJdSfh7qTe1Azk8s/ViZ qDeve/Cp3i/9o+pgNbFFiiADmvgRK0qqb2g65wib1gLC/3nhSiCg0WEo5kbD37/tiaBaGaLMQoK neyp4dCjPWdnandlXxfbMnhWhTKKEQTU/DlGVF X-Gm-Gg: ASbGncvY6PSmbCvpJOKpOf271ysyhxOtuZ2k3hWaHnComAHs4/wYrg20FoSYigzePI8 9UnTn/BWUFjxw/a68RmHW5nlJdA41lJpCbqDUnbntG7NSIYC3MZaFn0vqi5inSzKxcS6RONJnub hR6fwgSFijlK1r/K8IaLbAnYyYJ3knUeau7dKaHFFWZFF4lkgS1vKQOSURBmgz79C7PALdaibBT NDGsOuid8NldE3NMnzlepfuosXFiNgWkPQiqOI2UtNagmZkWtfAV/84GxRyu7eMBCfKGT+ShDod DjNqReTnzF8R182FLjmnMviFcoQvCBdv3j0DISZc X-Received: by 2002:a05:600c:1d8b:b0:43c:fffc:7886 with SMTP id 5b1f17b1804b1-44c935dca57mr78377015e9.8.1748269283554; Mon, 26 May 2025 07:21:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE6TmQ4d+2KSz0O4CIRxJ62SmxKRFdIFYB+WSn1VM9la8kfagA1ldvgkheVNc40vEgBm/LZvw== X-Received: by 2002:a05:600c:1d8b:b0:43c:fffc:7886 with SMTP id 5b1f17b1804b1-44c935dca57mr78376835e9.8.1748269283097; Mon, 26 May 2025 07:21:23 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-442ebda7d2csm246415315e9.3.2025.05.26.07.21.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 May 2025 07:21:22 -0700 (PDT) Date: Mon, 26 May 2025 16:21:21 +0200 From: Stefano Brivio To: Laurent Vivier Subject: Re: [PATCH v5 24/29] icmp: use iov_tail rather than pool Message-ID: <20250526162121.6d5fbba8@elisabeth> In-Reply-To: <20250417165136.2688884-25-lvivier@redhat.com> References: <20250417165136.2688884-1-lvivier@redhat.com> <20250417165136.2688884-25-lvivier@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: jYUmeImEUeKa9icGFUcNBghGpsZdQvwffsalEk_hVL8_1748269284 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: AMYIUF64TUNDDZJW3TAMBTRLTBLIPGSA X-Message-ID-Hash: AMYIUF64TUNDDZJW3TAMBTRLTBLIPGSA X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 17 Apr 2025 18:51:31 +0200 Laurent Vivier wrote: > As the iov_tail has a non zero offset (because of the presence of > packet headers in the iov array), we must copy it to a new > iov array (using iov_splice()) to pass it to sendmsg(). > > We cannot use anymore iov_tail_msghdr(), so remove it. > > Signed-off-by: Laurent Vivier > --- > icmp.c | 30 +++++++++++++++++++----------- > icmp.h | 2 +- > iov.c | 23 ----------------------- > iov.h | 2 -- > tap.c | 7 ++----- > 5 files changed, 22 insertions(+), 42 deletions(-) > > diff --git a/icmp.c b/icmp.c > index d27d860b4af4..44d431d53c96 100644 > --- a/icmp.c > +++ b/icmp.c > @@ -44,6 +44,7 @@ > > #define ICMP_ECHO_TIMEOUT 60 /* s, timeout for ICMP socket activity */ > #define ICMP_NUM_IDS (1U << 16) > +#define MAX_IOV_ICMP 16 Is there any specific / normative reason why you picked 16 here, or it's arbitrary and supposed to be good enough? If it's arbitrary, perhaps indicate it with /* Arbitrary, should be enough */ or suchlike. -- Stefano