From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by passt.top (Postfix, from userid 1000) id 5DF455A0283; Wed, 04 Jun 2025 12:32:50 +0200 (CEST) From: Stefano Brivio To: passt-dev@passt.top Subject: [PATCH] passt-repair: Fix missing newlines in error messages Date: Wed, 4 Jun 2025 12:32:50 +0200 Message-ID: <20250604103250.4190812-1-sbrivio@redhat.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: ATMUAG2G3QRV3H6STCXQTEAJYWVIZQ3C X-Message-ID-Hash: ATMUAG2G3QRV3H6STCXQTEAJYWVIZQ3C X-MailFrom: sbrivio@passt.top X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Signed-off-by: Stefano Brivio --- passt-repair.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/passt-repair.c b/passt-repair.c index ff1c44f..8c59d7e 100644 --- a/passt-repair.c +++ b/passt-repair.c @@ -83,7 +83,7 @@ int main(int argc, char **argv) prog.filter = filter_repair; if (prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0) || prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &prog)) { - fprintf(stderr, "Failed to apply seccomp filter"); + fprintf(stderr, "Failed to apply seccomp filter\n"); _exit(1); } @@ -134,13 +134,13 @@ int main(int argc, char **argv) n = read(fd, buf, sizeof(buf)); if (n < 0) { - fprintf(stderr, "inotify read: %i", errno); + fprintf(stderr, "inotify read: %i\n", errno); _exit(1); } buf[n - 1] = '\0'; if (n < (ssize_t)sizeof(*ev)) { - fprintf(stderr, "Short inotify read: %zi", n); + fprintf(stderr, "Short inotify read: %zi\n", n); continue; } @@ -176,7 +176,7 @@ int main(int argc, char **argv) } if (ret <= 0 || ret >= (int)sizeof(a.sun_path)) { - fprintf(stderr, "Invalid socket path"); + fprintf(stderr, "Invalid socket path\n"); _exit(2); } @@ -245,8 +245,8 @@ loop: for (i = 0; i < n; i++) { if (setsockopt(fds[i], SOL_TCP, TCP_REPAIR, &op, sizeof(op))) { fprintf(stderr, - "Setting TCP_REPAIR to %i on socket %i: %s", op, - fds[i], strerror(errno)); + "Setting TCP_REPAIR to %i on socket %i: %s\n", + op, fds[i], strerror(errno)); _exit(1); } -- 2.43.0