From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Q1LKXtIB; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 960165A028F for ; Wed, 04 Jun 2025 15:09:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749042558; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oOYwb+hO2RtGDtizyFZ+0rbh17aGFPHXQrZXXHfHG9U=; b=Q1LKXtIBOQSuwjKg55QzFDemUpugCAr0u4DXO/sx1X+YRcZUxKAKkCGGveHhrqwKFCqzqH GmrEQijVi4lZiZIOJi7UEV6T0dKXsLfp+w/kb/7gTAcQRer6ncjhL0hesBsd59iBePWSlZ ONiHuxJ9vHpPQ/Vu7x3GuSGn596J4wg= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-37-jt8bUwxNN-CdvKhoS55wTA-1; Wed, 04 Jun 2025 09:09:17 -0400 X-MC-Unique: jt8bUwxNN-CdvKhoS55wTA-1 X-Mimecast-MFC-AGG-ID: jt8bUwxNN-CdvKhoS55wTA_1749042556 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A85C919560AB for ; Wed, 4 Jun 2025 13:09:16 +0000 (UTC) Received: from lenovo-t14s.redhat.com (unknown [10.45.225.52]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 90AFD19560AD; Wed, 4 Jun 2025 13:09:15 +0000 (UTC) From: Laurent Vivier To: passt-dev@passt.top Subject: [PATCH v6 20/30] tap: Convert tap6_handler() to iov_tail Date: Wed, 4 Jun 2025 15:08:24 +0200 Message-ID: <20250604130834.3868010-21-lvivier@redhat.com> In-Reply-To: <20250604130834.3868010-1-lvivier@redhat.com> References: <20250604130834.3868010-1-lvivier@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: -09Od2PDJLc1p4oEkNCfrB5lm9NiPWjCYjSnpomG4vM_1749042556 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true Message-ID-Hash: 44SO7BUQQ7FHXX4HNTSBZZRNI7ULBOVJ X-Message-ID-Hash: 44SO7BUQQ7FHXX4HNTSBZZRNI7ULBOVJ X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Laurent Vivier X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Use packet_data() and extract headers using IOV_REMOVE_HEADER() and IOV_PEEK_HEADER() rather than packet_get(). Remove packet_get() as it is not used anymore. Signed-off-by: Laurent Vivier --- packet.c | 70 -------------------------------------------------------- packet.h | 11 --------- tap.c | 25 ++++++++++++-------- 3 files changed, 16 insertions(+), 90 deletions(-) diff --git a/packet.c b/packet.c index 014b353cdf8b..5da18bafa576 100644 --- a/packet.c +++ b/packet.c @@ -121,76 +121,6 @@ void packet_add_do(struct pool *p, struct iov_tail *data, p->count++; } -/** - * packet_get_try_do() - Get data range from packet descriptor from given pool - * @p: Packet pool - * @idx: Index of packet descriptor in pool - * @offset: Offset of data range in packet descriptor - * @len: Length of desired data range - * @left: Length of available data after range, set on return, can be NULL - * @func: For tracing: name of calling function - * @line: For tracing: caller line of function call - * - * Return: pointer to start of data range, NULL on invalid range or descriptor - */ -/* cppcheck-suppress [staticFunction] */ -void *packet_get_try_do(const struct pool *p, size_t idx, size_t offset, - size_t len, size_t *left, const char *func, int line) -{ - char *ptr; - - ASSERT_WITH_MSG(p->count <= p->size, - "Corrupt pool count: %zu, size: %zu, %s:%i", - p->count, p->size, func, line); - - if (idx >= p->count) { - debug("packet %zu from pool count: %zu, %s:%i", - idx, p->count, func, line); - return NULL; - } - - if (offset > p->pkt[idx].iov_len || - len > (p->pkt[idx].iov_len - offset)) - return NULL; - - ptr = (char *)p->pkt[idx].iov_base + offset; - - ASSERT_WITH_MSG(!packet_check_range(p, ptr, len, func, line), - "Corrupt packet pool, %s:%i", func, line); - - if (left) - *left = p->pkt[idx].iov_len - offset - len; - - return ptr; -} - -/** - * packet_get_do() - Get data range from packet descriptor from given pool - * @p: Packet pool - * @idx: Index of packet descriptor in pool - * @offset: Offset of data range in packet descriptor - * @len: Length of desired data range - * @left: Length of available data after range, set on return, can be NULL - * @func: For tracing: name of calling function - * @line: For tracing: caller line of function call - * - * Return: as packet_get_try_do() but log a trace message when returning NULL - */ -void *packet_get_do(const struct pool *p, const size_t idx, - size_t offset, size_t len, size_t *left, - const char *func, int line) -{ - void *r = packet_get_try_do(p, idx, offset, len, left, func, line); - - if (!r) { - trace("missing packet data length %zu, offset %zu from " - "length %zu, %s:%i", - len, offset, p->pkt[idx].iov_len, func, line); - } - - return r; -} - /** * packet_data_do() - Get data range from packet descriptor from given pool * @p: Packet pool diff --git a/packet.h b/packet.h index 062afb978124..dab8274fa5c5 100644 --- a/packet.h +++ b/packet.h @@ -33,12 +33,6 @@ struct pool { int vu_packet_check_range(void *buf, const char *ptr, size_t len); void packet_add_do(struct pool *p, struct iov_tail *data, const char *func, int line); -void *packet_get_try_do(const struct pool *p, const size_t idx, - size_t offset, size_t len, size_t *left, - const char *func, int line); -void *packet_get_do(const struct pool *p, const size_t idx, - size_t offset, size_t len, size_t *left, - const char *func, int line); bool packet_data_do(const struct pool *p, const size_t idx, struct iov_tail *data, const char *func, int line); @@ -47,11 +41,6 @@ void pool_flush(struct pool *p); #define packet_add(p, data) \ packet_add_do(p, data, __func__, __LINE__) - -#define packet_get_try(p, idx, offset, len, left) \ - packet_get_try_do(p, idx, offset, len, left, __func__, __LINE__) -#define packet_get(p, idx, offset, len, left) \ - packet_get_do(p, idx, offset, len, left, __func__, __LINE__) #define packet_data(p, idx, data) \ packet_data_do(p, idx, data, __func__, __LINE__) diff --git a/tap.c b/tap.c index 30031c6e514e..7cf807149879 100644 --- a/tap.c +++ b/tap.c @@ -894,21 +894,28 @@ resume: for (seq_count = 0, seq = NULL; i < in->count; i++) { size_t l4len, plen, check; struct in6_addr *saddr, *daddr; + struct ipv6hdr ip6h_storage; + struct ethhdr eh_storage; + struct udphdr uh_storage; const struct ethhdr *eh; const struct udphdr *uh; struct iov_tail data; struct ipv6hdr *ip6h; uint8_t proto; - char *l4h; - eh = packet_get(in, i, 0, sizeof(*eh), NULL); + if (!packet_data(in, i, &data)) + return -1; + + eh = IOV_REMOVE_HEADER(&data, eh_storage); if (!eh) continue; - ip6h = packet_get(in, i, sizeof(*eh), sizeof(*ip6h), &check); + ip6h = IOV_PEEK_HEADER(&data, ip6h_storage); if (!ip6h) continue; + check = iov_tail_size(&data) - sizeof(*ip6h); + saddr = &ip6h->saddr; daddr = &ip6h->daddr; @@ -916,10 +923,8 @@ resume: if (plen != check) continue; - data = IOV_TAIL_FROM_BUF(ip6h, sizeof(*ip6h) + check, 0); if (!ipv6_l4hdr(&data, &proto, &l4len)) continue; - l4h = (char *)data.iov[0].iov_base + data.off; if (IN6_IS_ADDR_LOOPBACK(saddr) || IN6_IS_ADDR_LOOPBACK(daddr)) { char sstr[INET6_ADDRSTRLEN], dstr[INET6_ADDRSTRLEN]; @@ -944,6 +949,8 @@ resume: } if (proto == IPPROTO_ICMPV6) { + struct icmp6hdr l4h_storage; + const struct icmp6hdr *l4h; PACKET_POOL_P(pkt, 1, in->buf, in->buf_size); if (c->no_icmp) @@ -952,9 +959,9 @@ resume: if (l4len < sizeof(struct icmp6hdr)) continue; - data = IOV_TAIL_FROM_BUF(l4h, l4len, 0); packet_add(pkt, &data); + l4h = IOV_PEEK_HEADER(&data, l4h_storage); if (ndp(c, (struct icmp6hdr *)l4h, saddr, pkt)) continue; @@ -967,12 +974,13 @@ resume: if (l4len < sizeof(*uh)) continue; - uh = (struct udphdr *)l4h; + uh = IOV_PEEK_HEADER(&data, uh_storage); + if (!uh) + continue; if (proto == IPPROTO_UDP) { PACKET_POOL_P(pkt, 1, in->buf, in->buf_size); - data = IOV_TAIL_FROM_BUF(l4h, l4len, 0); packet_add(pkt, &data); if (dhcpv6(c, pkt, saddr, daddr)) @@ -1029,7 +1037,6 @@ resume: #undef L4_SET append: - data = IOV_TAIL_FROM_BUF(l4h, l4len, 0); packet_add((struct pool *)&seq->p, &data); } -- 2.49.0