From: Laurent Vivier <lvivier@redhat.com>
To: passt-dev@passt.top
Cc: Laurent Vivier <lvivier@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH v6 08/30] ndp: Convert to iov_tail
Date: Wed, 4 Jun 2025 15:08:12 +0200 [thread overview]
Message-ID: <20250604130834.3868010-9-lvivier@redhat.com> (raw)
In-Reply-To: <20250604130834.3868010-1-lvivier@redhat.com>
Use packet_data() and extract headers using IOV_REMOVE_HEADER()
rather than packet_get().
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
---
ndp.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/ndp.c b/ndp.c
index b664034b00b1..77722353be7b 100644
--- a/ndp.c
+++ b/ndp.c
@@ -351,9 +351,14 @@ int ndp(const struct ctx *c, const struct icmp6hdr *ih,
return 1;
if (ih->icmp6_type == NS) {
+ struct ndp_ns ns_storage;
const struct ndp_ns *ns;
+ struct iov_tail data;
- ns = packet_get(p, 0, 0, sizeof(struct ndp_ns), NULL);
+ if (!packet_data(p, 0, &data))
+ return -1;
+
+ ns = IOV_REMOVE_HEADER(&data, ns_storage);
if (!ns)
return -1;
--
@@ -351,9 +351,14 @@ int ndp(const struct ctx *c, const struct icmp6hdr *ih,
return 1;
if (ih->icmp6_type == NS) {
+ struct ndp_ns ns_storage;
const struct ndp_ns *ns;
+ struct iov_tail data;
- ns = packet_get(p, 0, 0, sizeof(struct ndp_ns), NULL);
+ if (!packet_data(p, 0, &data))
+ return -1;
+
+ ns = IOV_REMOVE_HEADER(&data, ns_storage);
if (!ns)
return -1;
--
2.49.0
next prev parent reply other threads:[~2025-06-04 13:08 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-04 13:08 [PATCH v6 00/30] Introduce discontiguous frames management Laurent Vivier
2025-06-04 13:08 ` [PATCH v6 01/30] arp: Don't mix incoming and outgoing buffers Laurent Vivier
2025-06-04 13:08 ` [PATCH v6 02/30] iov: Introduce iov_tail_clone() and iov_tail_drop() Laurent Vivier
2025-06-04 13:08 ` [PATCH v6 03/30] iov: Update IOV_REMOVE_HEADER() and IOV_PEEK_HEADER() Laurent Vivier
2025-06-04 13:08 ` [PATCH v6 04/30] tap: Use iov_tail with tap_add_packet() Laurent Vivier
2025-06-04 13:08 ` [PATCH v6 05/30] packet: Use iov_tail with packet_add() Laurent Vivier
2025-06-04 13:08 ` [PATCH v6 06/30] packet: Add packet_data() Laurent Vivier
2025-06-04 13:08 ` [PATCH v6 07/30] arp: Convert to iov_tail Laurent Vivier
2025-06-04 13:08 ` Laurent Vivier [this message]
2025-06-04 13:08 ` [PATCH v6 09/30] icmp: " Laurent Vivier
2025-06-04 13:08 ` [PATCH v6 10/30] udp: " Laurent Vivier
2025-06-04 13:08 ` [PATCH v6 11/30] tcp: Convert tcp_tap_handler() to use iov_tail Laurent Vivier
2025-06-04 13:08 ` [PATCH v6 12/30] tcp: Convert tcp_data_from_tap() " Laurent Vivier
2025-06-04 13:08 ` [PATCH v6 13/30] dhcpv6: move offset initialization out of dhcpv6_opt() Laurent Vivier
2025-06-04 13:08 ` [PATCH v6 14/30] dhcpv6: Extract sending of NotOnLink status Laurent Vivier
2025-06-04 13:08 ` [PATCH v6 15/30] dhcpv6: Convert to iov_tail Laurent Vivier
2025-06-04 13:08 ` [PATCH v6 16/30] dhcpv6: Use iov_tail in dhcpv6_opt() Laurent Vivier
2025-06-04 13:08 ` [PATCH v6 17/30] dhcp: Convert to iov_tail Laurent Vivier
2025-06-04 13:08 ` [PATCH v6 18/30] ip: Use iov_tail in ipv6_l4hdr() Laurent Vivier
2025-06-04 13:08 ` [PATCH v6 19/30] tap: Convert tap4_handler() to iov_tail Laurent Vivier
2025-06-04 13:08 ` [PATCH v6 20/30] tap: Convert tap6_handler() " Laurent Vivier
2025-06-04 13:08 ` [PATCH v6 21/30] packet: rename packet_data() to packet_get() Laurent Vivier
2025-06-04 13:08 ` [PATCH v6 22/30] arp: use iov_tail rather than pool Laurent Vivier
2025-06-04 13:08 ` [PATCH v6 23/30] dhcp: " Laurent Vivier
2025-06-04 13:08 ` [PATCH v6 24/30] dhcpv6: " Laurent Vivier
2025-06-04 13:08 ` [PATCH v6 25/30] icmp: " Laurent Vivier
2025-06-04 13:08 ` [PATCH v6 26/30] ndp: " Laurent Vivier
2025-06-04 13:08 ` [PATCH v6 27/30] packet: remove PACKET_POOL() and PACKET_POOL_P() Laurent Vivier
2025-06-04 13:08 ` [PATCH v6 28/30] packet: remove unused parameter from PACKET_POOL_DECL() Laurent Vivier
2025-06-04 13:08 ` [PATCH v6 29/30] packet: add memory regions information into pool Laurent Vivier
2025-06-04 13:08 ` [PATCH v6 30/30] packet: use buf to store iovec array Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250604130834.3868010-9-lvivier@redhat.com \
--to=lvivier@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).