From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=PadW8i3m; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id C355F5A0280 for ; Fri, 06 Jun 2025 12:06:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749204363; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fMYQNWgLIrQ39yn6QypUcENsZzPDTSpB9moHO9/iPak=; b=PadW8i3mj67xiwTPUP7Oe3uhd5Ut3Q3KtdBYHx/OnJ+uUWaqPPcqN9BGFFhj6C31+lFA5Z QPet2IvNjTMwwj+EQ2yALTHvUT7bh5LdqUffzdzu7MTnjHBX3px7696gkjWIxGRpKChsaY jaSSQfs+sNUfydO1on2v580CUziA4kw= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-36-YYcrG92qO1qlgTDd4Z6VlQ-1; Fri, 06 Jun 2025 06:06:02 -0400 X-MC-Unique: YYcrG92qO1qlgTDd4Z6VlQ-1 X-Mimecast-MFC-AGG-ID: YYcrG92qO1qlgTDd4Z6VlQ_1749204361 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-450d64026baso11223025e9.1 for ; Fri, 06 Jun 2025 03:06:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749204360; x=1749809160; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=fMYQNWgLIrQ39yn6QypUcENsZzPDTSpB9moHO9/iPak=; b=TgovZbt/lv+X1y3QpjJIgMTTxf/kx87xbL2z036Orw9rxrwGuKIdsKMejG9YeoONcS 77/HxLGopAZ010Z79F7EHrC6IwkJ5NbpGnoQ6mpfLRrJhsDrgrvtFI0weK77otSCXftL zMebMvGPv9WGLDZ2SzwfOrYkWlrsNiCPYl1vw/d1ShAPQS2jiVKEqeDwRq5hZk/uaHVa YmIfKg1du29w0cPvwyM8B+Z2L5mZ3k90AK6DFhBQ/ai1e1Rcmjl2k5lp5lBllsl/rqtS M6vbTdUXxViC2LOqZ8At9hu2b7VdN6FnA2SkKg42xJuv/L/RA8GxGkpKOyTAvHwSjVuP gquQ== X-Gm-Message-State: AOJu0YzPO9XsMO3BBbc9IrbUJS4M65m8oWsdI0G/WRrjHZyO64mZnPDT KY4EmsuVgjd4yKCf50rI52wY4YzulhO98ZATJxfjNZUGsRfDfhPd7SjM4FparXjeQ2vL/SNOtDJ E7VnxrjfMJSxhHpki+VTaPfMUTw5taepdxtvF5D1NjX5AqU+/f9RlfplG57LKbC1QoMnJtA+0Vu D4G9KSLAqh39SpcE3YwUYSPVhhzESifpclE3uo X-Gm-Gg: ASbGncsP/lILQ2kjyRqqyGEybTEuia5WFTVE2wST6hPg1my/6Qkcni0Wu+Jv5zgO6Hr 3udIs19ATVppcVFXpA/03zujB3hQybppGbAqhovCArLEN0ABUOcX5qFj5t/w28Z7QVz9ISrbJx3 2ifuI2qXqH1gGmhnoAqvdsISPcBw4hJGX56WID9ZuXRIlNilwaJP2d+pgy7CIjvkv+DZusr0TPE Is+DJhnH6hj8m2VEWiza4jApjlFWiIhwdTz4KgLTmsTrm0+pPHPkKAGDLwjkVQgngIzKOHXKhiw 4pWS++zXEsl+IkDdvuzp7lpHjeDUkjys0I+kMh4k X-Received: by 2002:a05:600c:3b25:b0:451:dee4:cd08 with SMTP id 5b1f17b1804b1-452013d1b4fmr28159285e9.23.1749204360479; Fri, 06 Jun 2025 03:06:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFAWpwhDX0WL0qJ6DsnVtRqoKUhmrRkmjiD+mbscdDd+y3hhteqnshf8WdYWaxPbd/B2FpeWw== X-Received: by 2002:a05:600c:3b25:b0:451:dee4:cd08 with SMTP id 5b1f17b1804b1-452013d1b4fmr28158995e9.23.1749204359996; Fri, 06 Jun 2025 03:05:59 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45209bc6d50sm18876185e9.5.2025.06.06.03.05.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jun 2025 03:05:59 -0700 (PDT) Date: Fri, 6 Jun 2025 12:05:58 +0200 From: Stefano Brivio To: Laurent Vivier Subject: Re: [PATCH] Correct various function comment headers Message-ID: <20250606120558.27dec7bc@elisabeth> In-Reply-To: <20250519085256.44985-1-lvivier@redhat.com> References: <20250519085256.44985-1-lvivier@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: xIHLm1ujknDtcdaXpyGI5k7lJZ38i-hav7HHeF3d3VY_1749204361 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: KF55HKDAU5EKTWVV4IRYAPRGGGKTQ33F X-Message-ID-Hash: KF55HKDAU5EKTWVV4IRYAPRGGGKTQ33F X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 19 May 2025 10:52:56 +0200 Laurent Vivier wrote: > This commit refines function comment headers for improved accuracy > and consistency. Key changes include: > > - Corrected parameter/return descriptions (e.g., `logtime`, `__daemon`). > - Added missing and removed incorrect parameter documentation (e.g., > `tcp_vu_sock_recv`, `ndp`). > - Standardized comments to the `/** ... */` style for functions > like `udp_flow_close` and `ns_enter`. > - Ensured function names in comments consistently use `()`. > - Addressed minor typos and updated comments for renamed functions. > > Signed-off-by: Laurent Vivier Applied, sorry for the delay. -- Stefano