From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Y2+xEjGi; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 5CFF75A0280 for ; Fri, 20 Jun 2025 11:24:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750411465; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=swvjQV9pqVK/I3AS64hOjfWlODRLgmDwM58x8jJBi98=; b=Y2+xEjGikPW1glcZtn67+DbniO84nuy6GWBOF/tQ2602ySkJJTS41cd61rBKwPpAO43uRr Nxxq6LcQmNEUcZz8BHjY1Z52k8EsIg05ewYJVTDqQNhYJIr68ml2pM4nFIs82JiXBRygZT 2fqJkPvDtijl85BQWZkFLBuluddEQqY= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-530-PUXF4Pj3MPuV1FMLZWtGyA-1; Fri, 20 Jun 2025 05:24:23 -0400 X-MC-Unique: PUXF4Pj3MPuV1FMLZWtGyA-1 X-Mimecast-MFC-AGG-ID: PUXF4Pj3MPuV1FMLZWtGyA_1750411462 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-452ff9e054eso7624815e9.2 for ; Fri, 20 Jun 2025 02:24:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750411462; x=1751016262; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=swvjQV9pqVK/I3AS64hOjfWlODRLgmDwM58x8jJBi98=; b=rlJRUVPqG+xfIb6Dc9gpSZH1XP5H7Cch0qfYW5dWfwNfjMw0SKuI0eo9C2O5fHWEXp 2bHAUdgAypmYZYYs9lXCrfvu7cWRWprm0R8cxzfmp5+n8JFMWqT+DFwbRaHWMQNyhtD5 py8BZzRgmvMvJZ76H5fEZCQIE11NZHwIlOUnxh562igFGi3kYPEo6Jx863+SYVkUxBme 8cOvKkVMxgHo6VNdl5OacG8bnP33/sYAEU+4wJgANLPMTOjdSKimuDlYzSBbYpTEqqzR nnRq7hVlcdxKLrLFq2g5tCbZ2Fxnhyl7Bqo6Xe5hbWvGvWElEYBcNwM8cj2D02+cq0kY Nt2w== X-Gm-Message-State: AOJu0YxKaRYN2TFxq5wE00nT+/s2w6+QIZwZRWfrrkNU4kGGMvOCwlTo o3Oj+NF6wnTNczSEZ1vW8hOteNvJEKS7GrQ3ZaEDSZu/sj66hYkvpCwacYS8ZQLKMtPlazeWZgz qHXqrEJssuSKv7hwAsT3D+pDuimtclmpiHi4pAMKVHTVEX07pHbGZwlPRRjXSQcdeZO90gU9xMs 79+A03xEKQK+rVFGblAS+VOyQ6X7ctSnP2zhf9 X-Gm-Gg: ASbGncvZTgLCbb5nAaSI53Tg8/RJN5VXTMsYSA2atp8TNSStsX3ngYpw+OpcP/Npz0A l+LHykphpwY5bxejJAk2ZWY73Zij73G9in4lWQ/vFXSG1hzZQpF436tc1AKigudPeA/NjILMxpq PFB0TKg3WUa9gO3bJi65ilDeag9H+aOFOW3d0QDbwlGEcTzeM4F/zcDrTe5RWgQbWAzzqqIlnnt mpDfF1KpxUw/vJjaS6taj4A0vwKmHG+CLnQBPtJpPfA/5TzmOjlp9SCyCMRHGvGAxXcx76nkgT0 UHm5nIkoUdJ4aBB/EyobGOItbko/fOZfog== X-Received: by 2002:a05:600c:37c5:b0:43c:f81d:34 with SMTP id 5b1f17b1804b1-4536539bff3mr18959175e9.9.1750411462007; Fri, 20 Jun 2025 02:24:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEAI4SiBS2OtFF7/Zusy9YUgwZBC1MTpoQloh4VIJg1X9rnzk/1NSF7nLoMlCxX5yWDWge54g== X-Received: by 2002:a05:600c:37c5:b0:43c:f81d:34 with SMTP id 5b1f17b1804b1-4536539bff3mr18958835e9.9.1750411461475; Fri, 20 Jun 2025 02:24:21 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-453646dc761sm18829625e9.17.2025.06.20.02.24.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Jun 2025 02:24:20 -0700 (PDT) Date: Fri, 20 Jun 2025 11:24:11 +0200 From: Stefano Brivio To: Laurent Vivier Subject: Re: [PATCH] style: Fix 'Return' comment style Message-ID: <20250620112411.0d7e5be1@elisabeth> In-Reply-To: <20250619113728.953203-1-lvivier@redhat.com> References: <20250619113728.953203-1-lvivier@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: kEeVowyGWNS93ukTkkxo8RYASenYOGAiBtbrLtEnZjE_1750411462 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 2RAQTCWU3TMYLJOBN3USCWXS2KZ2O2RM X-Message-ID-Hash: 2RAQTCWU3TMYLJOBN3USCWXS2KZ2O2RM X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 19 Jun 2025 13:37:28 +0200 Laurent Vivier wrote: > We always use imperative (no 'Returns:'), no tab after the ':' and > only one space, the first character is always lowercase. > > [...] > > @@ -129,7 +129,7 @@ static int udp_vu_sock_recv(const struct ctx *c, int s, bool v6, ssize_t *dlen) > * @toside: Address information for one side of the flow > * @dlen: Packet data length > * > - * Return: Layer-4 length > + * Return: layer-4 length ...unless it's a proper noun (Layer-4, Layer 4, L4...). I can fix this up on merge, but feel free to re-post. :) -- Stefano