public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Laurent Vivier <lvivier@redhat.com>
To: passt-dev@passt.top
Cc: Laurent Vivier <lvivier@redhat.com>
Subject: [PATCH v7 00/31] Introduce discontiguous frames management
Date: Mon, 23 Jun 2025 13:06:04 +0200	[thread overview]
Message-ID: <20250623110635.1478625-1-lvivier@redhat.com> (raw)

This series introduces iov_tail to convey frame information
between functions.

This is only an API change, for the moment the memory pool
is only able to store contiguous buffer, so, except for
vhost-user in a special case, we only play with iovec array
with only one entry.

v7:
    - Add a patch to fix comment style of 'Return:'
    - Fix ignore_arp()/accept_arp()
    - Fix coverity error
    - Fix several comments

v6:
    - Replaced iov_slice() with the clearer iov_tail_clone()
      for creating iovec subsets.
    - Standardized local header variable names (to *_storage suffix).
    - Renamed functions for better semantics (e.g., ignore_arp to
      accept_arp, packet_data to packet_get).
    - Corrected OPTLEN_MAX definition in TCP.
    - Addressed minor logic issues (e.g., DHCPv6 FQDN flags, NDP null check).
    - Updated ipv6_l4hdr() return type to boolean.
    - Improved comments and documentation across several modules.

v5:
    - store in the pool iovec array with several entries

v4:
  Prepare to introduce iovec array in the pool:
    - passe iov_tail rather than pool to ndp,icmp, dhcp, dhcpv6 and arp
    - remove unused pool macros
    - add memory regions in the pool structure, this will allow us to use
      the buf pointer to store the iovec array for vhost-user

v3:
  Address comments from David

Laurent Vivier (31):
  style: Fix 'Return' comment style
  arp: Don't mix incoming and outgoing buffers
  iov: Introduce iov_tail_clone() and iov_tail_drop().
  iov: Update IOV_REMOVE_HEADER() and IOV_PEEK_HEADER()
  tap: Use iov_tail with tap_add_packet()
  packet: Use iov_tail with packet_add()
  packet: Add packet_data()
  arp: Convert to iov_tail
  ndp: Convert to iov_tail
  icmp: Convert to iov_tail
  udp: Convert to iov_tail
  tcp: Convert tcp_tap_handler() to use iov_tail
  tcp: Convert tcp_data_from_tap() to use iov_tail
  dhcpv6: move offset initialization out of dhcpv6_opt()
  dhcpv6: Extract sending of NotOnLink status
  dhcpv6: Convert to iov_tail
  dhcpv6: Use iov_tail in dhcpv6_opt()
  dhcp: Convert to iov_tail
  ip: Use iov_tail in ipv6_l4hdr()
  tap: Convert tap4_handler() to iov_tail
  tap: Convert tap6_handler() to iov_tail
  packet: rename packet_data() to packet_get()
  arp: use iov_tail rather than pool
  dhcp: use iov_tail rather than pool
  dhcpv6: use iov_tail rather than pool
  icmp: use iov_tail rather than pool
  ndp: use iov_tail rather than pool
  packet: remove PACKET_POOL() and PACKET_POOL_P()
  packet: remove unused parameter from PACKET_POOL_DECL()
  packet: add memory regions information into pool
  packet: use buf to store iovec array

 arp.c        |  86 ++++++++++++-------
 arp.h        |   2 +-
 checksum.c   |   4 +-
 conf.c       |  12 +--
 dhcp.c       |  48 ++++++-----
 dhcp.h       |   2 +-
 dhcpv6.c     | 223 +++++++++++++++++++++++++++++++-------------------
 dhcpv6.h     |   2 +-
 flow.c       |   4 +-
 flow_table.h |   2 +-
 icmp.c       |  43 ++++++----
 icmp.h       |   2 +-
 inany.c      |   4 +-
 iov.c        | 118 ++++++++++++++++++++++----
 iov.h        |  58 +++++++++----
 ip.c         |  32 ++++----
 ip.h         |   3 +-
 lineread.c   |   2 +-
 ndp.c        |  16 +++-
 ndp.h        |   4 +-
 packet.c     | 227 ++++++++++++++++++++++++++++++++++++++-------------
 packet.h     |  57 ++++++-------
 pcap.c       |   1 +
 tap.c        | 134 +++++++++++++++++-------------
 tap.h        |   8 +-
 tcp.c        |  67 ++++++++++-----
 tcp_buf.c    |   2 +-
 tcp_splice.c |   4 +-
 tcp_vu.c     |   4 +-
 udp.c        |  37 ++++++---
 udp_vu.c     |   6 +-
 util.c       |   6 +-
 util.h       |   4 +-
 vhost_user.c |  72 ++++++++--------
 virtio.c     |   6 +-
 virtio.h     |  24 ++++--
 vu_common.c  |  48 ++++-------
 37 files changed, 870 insertions(+), 504 deletions(-)

-- 
2.49.0



             reply	other threads:[~2025-06-23 11:06 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-23 11:06 Laurent Vivier [this message]
2025-06-23 11:06 ` [PATCH v7 01/31] style: Fix 'Return' comment style Laurent Vivier
2025-06-23 11:06 ` [PATCH v7 02/31] arp: Don't mix incoming and outgoing buffers Laurent Vivier
2025-06-23 11:06 ` [PATCH v7 03/31] iov: Introduce iov_tail_clone() and iov_tail_drop() Laurent Vivier
2025-06-23 11:06 ` [PATCH v7 04/31] iov: Update IOV_REMOVE_HEADER() and IOV_PEEK_HEADER() Laurent Vivier
2025-06-23 11:06 ` [PATCH v7 05/31] tap: Use iov_tail with tap_add_packet() Laurent Vivier
2025-06-23 11:06 ` [PATCH v7 06/31] packet: Use iov_tail with packet_add() Laurent Vivier
2025-06-23 11:06 ` [PATCH v7 07/31] packet: Add packet_data() Laurent Vivier
2025-06-23 11:06 ` [PATCH v7 08/31] arp: Convert to iov_tail Laurent Vivier
2025-06-23 11:06 ` [PATCH v7 09/31] ndp: " Laurent Vivier
2025-06-23 11:06 ` [PATCH v7 10/31] icmp: " Laurent Vivier
2025-06-23 11:06 ` [PATCH v7 11/31] udp: " Laurent Vivier
2025-06-23 11:06 ` [PATCH v7 12/31] tcp: Convert tcp_tap_handler() to use iov_tail Laurent Vivier
2025-06-23 11:06 ` [PATCH v7 13/31] tcp: Convert tcp_data_from_tap() " Laurent Vivier
2025-06-23 11:06 ` [PATCH v7 14/31] dhcpv6: move offset initialization out of dhcpv6_opt() Laurent Vivier
2025-06-23 11:06 ` [PATCH v7 15/31] dhcpv6: Extract sending of NotOnLink status Laurent Vivier
2025-06-23 11:06 ` [PATCH v7 16/31] dhcpv6: Convert to iov_tail Laurent Vivier
2025-06-23 11:06 ` [PATCH v7 17/31] dhcpv6: Use iov_tail in dhcpv6_opt() Laurent Vivier
2025-06-23 11:06 ` [PATCH v7 18/31] dhcp: Convert to iov_tail Laurent Vivier
2025-06-23 11:06 ` [PATCH v7 19/31] ip: Use iov_tail in ipv6_l4hdr() Laurent Vivier
2025-06-23 11:06 ` [PATCH v7 20/31] tap: Convert tap4_handler() to iov_tail Laurent Vivier
2025-06-23 11:06 ` [PATCH v7 21/31] tap: Convert tap6_handler() " Laurent Vivier
2025-06-23 11:06 ` [PATCH v7 22/31] packet: rename packet_data() to packet_get() Laurent Vivier
2025-06-23 11:06 ` [PATCH v7 23/31] arp: use iov_tail rather than pool Laurent Vivier
2025-06-23 11:06 ` [PATCH v7 24/31] dhcp: " Laurent Vivier
2025-06-23 11:06 ` [PATCH v7 25/31] dhcpv6: " Laurent Vivier
2025-06-23 11:06 ` [PATCH v7 26/31] icmp: " Laurent Vivier
2025-06-23 11:06 ` [PATCH v7 27/31] ndp: " Laurent Vivier
2025-06-23 11:06 ` [PATCH v7 28/31] packet: remove PACKET_POOL() and PACKET_POOL_P() Laurent Vivier
2025-06-23 11:06 ` [PATCH v7 29/31] packet: remove unused parameter from PACKET_POOL_DECL() Laurent Vivier
2025-06-23 11:06 ` [PATCH v7 30/31] packet: add memory regions information into pool Laurent Vivier
2025-06-23 11:06 ` [PATCH v7 31/31] packet: use buf to store iovec array Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250623110635.1478625-1-lvivier@redhat.com \
    --to=lvivier@redhat.com \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).