From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=JSE4v8Ou; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 2FD725A028F for ; Mon, 23 Jun 2025 13:07:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750676846; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3xYsq213hvuCiD7vXOsHYPAUk9VkMf8NxQOjCKM4xY8=; b=JSE4v8Ou72bt3HKWHDqjgUtksF2kI20h9AswZ5fqF6X0TW5JJ7kDf4rnhEnEDCYO5T/+/A 2VwhFOiQay3sF6bXe++ZnoqyVQy9H9wYgaBvltwEuuSbGJ8llSXv4DMVoUGe6dlpkIsro4 Bv2AUOg/pxZtBI7xE+gdRRP5bBxVZY4= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-404-0nrhIihzPxegsVHR7gEoeA-1; Mon, 23 Jun 2025 07:07:24 -0400 X-MC-Unique: 0nrhIihzPxegsVHR7gEoeA-1 X-Mimecast-MFC-AGG-ID: 0nrhIihzPxegsVHR7gEoeA_1750676843 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C6BCD19560AD for ; Mon, 23 Jun 2025 11:07:23 +0000 (UTC) Received: from lenovo-t14s.redhat.com (unknown [10.45.224.132]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B42D61956096; Mon, 23 Jun 2025 11:07:22 +0000 (UTC) From: Laurent Vivier To: passt-dev@passt.top Subject: [PATCH v7 24/31] dhcp: use iov_tail rather than pool Date: Mon, 23 Jun 2025 13:06:28 +0200 Message-ID: <20250623110635.1478625-25-lvivier@redhat.com> In-Reply-To: <20250623110635.1478625-1-lvivier@redhat.com> References: <20250623110635.1478625-1-lvivier@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: kG3VuWyiGNdN6K3FJPyZlzzpIB_i_nYC2YHYTRdoxeg_1750676843 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true Message-ID-Hash: 4CYC3QEOVQOWPAL56HJJHLKDX2ZZHJKP X-Message-ID-Hash: 4CYC3QEOVQOWPAL56HJJHLKDX2ZZHJKP X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Laurent Vivier X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This patch refactors the dhcp() function to accept `struct iov_tail *data` directly as its packet input, replacing the previous `const struct pool *p` parameter. Consequently, dhcp() no longer fetches packet data internally using packet_data(). This change simplifies callers, such as tap4_handler(), which now pass the iov_tail representing the L2 frame directly to dhcp(). This removes the need for intermediate packet pool handling for DHCP processing. Signed-off-by: Laurent Vivier --- dhcp.c | 32 ++++++++++++++------------------ dhcp.h | 2 +- tap.c | 5 +---- 3 files changed, 16 insertions(+), 23 deletions(-) diff --git a/dhcp.c b/dhcp.c index 47317f334945..cad1d037cee1 100644 --- a/dhcp.c +++ b/dhcp.c @@ -296,11 +296,11 @@ static void opt_set_dns_search(const struct ctx *c, size_t max_len) /** * dhcp() - Check if this is a DHCP message, reply as needed * @c: Execution context - * @p: Packet pool, single packet with Ethernet buffer + * @data: Single packet with Ethernet buffer * * Return: 0 if it's not a DHCP message, 1 if handled, -1 on failure */ -int dhcp(const struct ctx *c, const struct pool *p) +int dhcp(const struct ctx *c, struct iov_tail *data) { char macstr[ETH_ADDRSTRLEN]; size_t mlen, dlen, opt_len; @@ -311,24 +311,20 @@ int dhcp(const struct ctx *c, const struct pool *p) const struct ethhdr *eh; const struct iphdr *iph; const struct udphdr *uh; - struct iov_tail data; struct msg const *m; struct msg reply; unsigned int i; struct msg m_storage; - if (!packet_get(p, 0, &data)) - return -1; - - eh = IOV_REMOVE_HEADER(&data, eh_storage); - iph = IOV_PEEK_HEADER(&data, iph_storage); + eh = IOV_REMOVE_HEADER(data, eh_storage); + iph = IOV_PEEK_HEADER(data, iph_storage); if (!eh || !iph) return -1; - if (!iov_tail_drop(&data, iph->ihl * 4UL)) + if (!iov_tail_drop(data, iph->ihl * 4UL)) return -1; - uh = IOV_REMOVE_HEADER(&data, uh_storage); + uh = IOV_REMOVE_HEADER(data, uh_storage); if (!uh) return -1; @@ -338,8 +334,8 @@ int dhcp(const struct ctx *c, const struct pool *p) if (c->no_dhcp) return 1; - mlen = iov_tail_size(&data); - m = (struct msg const *)iov_remove_header_(&data, &m_storage, + mlen = iov_tail_size(data); + m = (struct msg const *)iov_remove_header_(data, &m_storage, offsetof(struct msg, o), __alignof__(struct msg)); if (!m || @@ -367,24 +363,24 @@ int dhcp(const struct ctx *c, const struct pool *p) for (i = 0; i < ARRAY_SIZE(opts); i++) opts[i].clen = -1; - opt_len = iov_tail_size(&data); + opt_len = iov_tail_size(data); while (opt_len >= 2) { uint8_t olen_storage, type_storage; const uint8_t *olen; uint8_t *type; - type = IOV_REMOVE_HEADER(&data, type_storage); - olen = IOV_REMOVE_HEADER(&data, olen_storage); + type = IOV_REMOVE_HEADER(data, type_storage); + olen = IOV_REMOVE_HEADER(data, olen_storage); if (!type || !olen) return -1; - opt_len = iov_tail_size(&data); + opt_len = iov_tail_size(data); if (opt_len < *olen) return -1; - iov_to_buf(&data.iov[0], data.cnt, data.off, &opts[*type].c, *olen); + iov_to_buf(&data->iov[0], data->cnt, data->off, &opts[*type].c, *olen); opts[*type].clen = *olen; - iov_tail_drop(&data, *olen); + iov_tail_drop(data, *olen); opt_len -= *olen; } diff --git a/dhcp.h b/dhcp.h index 87aeecd8dec8..cd50c99b8856 100644 --- a/dhcp.h +++ b/dhcp.h @@ -6,7 +6,7 @@ #ifndef DHCP_H #define DHCP_H -int dhcp(const struct ctx *c, const struct pool *p); +int dhcp(const struct ctx *c, struct iov_tail *data); void dhcp_init(void); #endif /* DHCP_H */ diff --git a/tap.c b/tap.c index ace735cfc136..7d7e89304723 100644 --- a/tap.c +++ b/tap.c @@ -785,11 +785,8 @@ resume: if (iph->protocol == IPPROTO_UDP) { struct iov_tail eh_data; - PACKET_POOL_P(pkt, 1, in->buf, in->buf_size); - packet_get(in, i, &eh_data); - packet_add(pkt, &eh_data); - if (dhcp(c, pkt)) + if (dhcp(c, &eh_data)) continue; } -- 2.49.0