From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=cyOBmYIj; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 21ADD5A0285 for ; Sun, 29 Jun 2025 19:13:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751217237; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XuzzEit8oMjaaYP6kf53Dir5Yn79TovN0Lxv42mDF0g=; b=cyOBmYIjkqyUtPcGhvzrjIFdp/vTLVJDE4rjqmRfrVR6G+/59GQ0VCJgN8ehsBDUuxNpoI E21zTju/d9p+iebi4LXLnZNss0JHvqYzo12TZ0lPSqWEd9cm2C8ZoyOj/CiaLxnQhM68Xj wUtJqoenKzvzJ+pR0aiBbvI33Rs7ihU= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-413-Xu_iQVTNO5SGevGZVElWqg-1; Sun, 29 Jun 2025 13:13:54 -0400 X-MC-Unique: Xu_iQVTNO5SGevGZVElWqg-1 X-Mimecast-MFC-AGG-ID: Xu_iQVTNO5SGevGZVElWqg_1751217233 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1E1AA1955EC1; Sun, 29 Jun 2025 17:13:53 +0000 (UTC) Received: from jmaloy-thinkpadp16vgen1.rmtcaqc.csb (unknown [10.22.64.73]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 163CC19560B2; Sun, 29 Jun 2025 17:13:50 +0000 (UTC) From: Jon Maloy To: sbrivio@redhat.com, dgibson@redhat.com, david@gibson.dropbear.id.au, jmaloy@redhat.com, passt-dev@passt.top Subject: [PATCH v3 1/8] netlink: add function to extract MAC addresses from NDP/ARP table Date: Sun, 29 Jun 2025 13:13:40 -0400 Message-ID: <20250629171348.86323-2-jmaloy@redhat.com> In-Reply-To: <20250629171348.86323-1-jmaloy@redhat.com> References: <20250629171348.86323-1-jmaloy@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: qoDGwljwYYg4HpW9WFK3FsOXDjaCsW3EBr68NLG74is_1751217233 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true Message-ID-Hash: HIK2UOPPSBPF2J3IF4BAYWSZRDMAUD2W X-Message-ID-Hash: HIK2UOPPSBPF2J3IF4BAYWSZRDMAUD2W X-MailFrom: jmaloy@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The solution to bug https://bugs.passt.top/show_bug.cgi?id=120 requires the ability to translate from an IP address to its corresponding MAC address in cases where those are present in the ARP/NDP table. We add this feature here. Signed-off-by: Jon Maloy --- v3: - Added an attribute contianing NDA_DST to sent message, so that we let the kernel do the filtering of the IP address and return only one entry. - Added interface index to the call signature. Since the only interface we know is the template interface, this limits the number of hosts that will be seen as 'network segment local' from a PASST viewpoint. --- netlink.c | 62 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ netlink.h | 2 ++ 2 files changed, 64 insertions(+) diff --git a/netlink.c b/netlink.c index ee9325a..16bb995 100644 --- a/netlink.c +++ b/netlink.c @@ -800,6 +800,68 @@ int nl_addr_get(int s, unsigned int ifi, sa_family_t af, return status; } +/** + * nl_mac_get() - Get MAC address corresponding to given IP address + * @s: Netlink socket + * @addr: IPv4 or IPv6 address + * @ifi: Interface index + * @mac: Array to place the returned MAC address + * + * Return: 0 if found or not in table, negative error code on failure. + * Leaves MAC array unchanged if no match found + */ +int nl_mac_get(int s, const union inany_addr *addr, int ifi, unsigned char *mac) +{ + struct req_t { + struct nlmsghdr nlh; + struct ndmsg ndm; + struct rtattr rta; + char ip[RTA_ALIGN(sizeof(struct in6_addr))]; + } req = { + .ndm.ndm_ifindex = ifi, + .rta.rta_type = NDA_DST + }; + struct nlmsghdr *nh; + char buf[NLBUFSIZ]; + const void *ip; + ssize_t status; + uint32_t seq; + int msglen; + int iplen; + + if (inany_v4(addr)) { + ip = &addr->v4mapped.a4; + iplen = sizeof(struct in_addr); + req.ndm.ndm_family = AF_INET; + } else { + ip = &addr->a6; + iplen = sizeof(struct in6_addr); + req.ndm.ndm_family = AF_INET6; + } + req.rta.rta_len = RTA_LENGTH(iplen); + memcpy(RTA_DATA(&req.rta), ip, iplen); + msglen = NLMSG_ALIGN(sizeof(req.nlh) + sizeof(req.ndm) + RTA_LENGTH(iplen)); + + seq = nl_send(s, &req, RTM_GETNEIGH, 0, msglen); + nl_foreach_oftype(nh, status, s, buf, seq, RTM_NEWNEIGH) { + struct ndmsg *ndm = NLMSG_DATA(nh); + struct rtattr *rta = (struct rtattr *)(ndm + 1); + size_t na = RTM_PAYLOAD(nh); + bool found = false; + + for (; RTA_OK(rta, na); rta = RTA_NEXT(rta, na)) { + if (rta->rta_type == NDA_DST) { + if (memcmp(RTA_DATA(rta), ip, iplen) == 0) + found = true; + } else if (rta->rta_type == NDA_LLADDR && found) { + memcpy(mac, RTA_DATA(rta), ETH_ALEN); + } + } + } + + return status; +} + /** * nl_addr_get_ll() - Get first IPv6 link-local address for a given interface * @s: Netlink socket diff --git a/netlink.h b/netlink.h index b51e99c..51ba49f 100644 --- a/netlink.h +++ b/netlink.h @@ -17,6 +17,8 @@ int nl_route_dup(int s_src, unsigned int ifi_src, int s_dst, unsigned int ifi_dst, sa_family_t af); int nl_addr_get(int s, unsigned int ifi, sa_family_t af, void *addr, int *prefix_len, void *addr_l); +int nl_mac_get(int s, const union inany_addr *addr, int ifi, + unsigned char *mac); int nl_addr_set(int s, unsigned int ifi, sa_family_t af, const void *addr, int prefix_len); int nl_addr_get_ll(int s, unsigned int ifi, struct in6_addr *addr); -- 2.48.1