From: Stefano Brivio <sbrivio@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: passt-dev@passt.top
Subject: Re: [PATCH v2] style: Fix 'Return' comment style
Date: Fri, 18 Jul 2025 20:45:21 +0200 [thread overview]
Message-ID: <20250718204521.4d173ba0@elisabeth> (raw)
In-Reply-To: <20250620093641.1345500-1-lvivier@redhat.com>
On Fri, 20 Jun 2025 11:36:41 +0200
Laurent Vivier <lvivier@redhat.com> wrote:
> We always use imperative (no 'Returns:'), no tab after the ':' and
> only one space, the first character is always lowercase.
>
> This is fixed with:
>
> sed -i "s/Returns:/Return:/;s/Return: /Return: /;s/Return: */Return: /;s/Return: \([A-Z]\)/Return: \L\1/" *.[ch]
>
> And manually updated to fix alignment of multiline comment and words
> that must keep uppercase (like IPv4, TCP, UDP, Layer-4).
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Applied.
--
Stefano
prev parent reply other threads:[~2025-07-18 18:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-20 9:36 [PATCH v2] style: Fix 'Return' comment style Laurent Vivier
2025-07-18 18:45 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250718204521.4d173ba0@elisabeth \
--to=sbrivio@redhat.com \
--cc=lvivier@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).