From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=NzRrcpql; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 3F65A5A0282 for ; Fri, 18 Jul 2025 20:45:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752864333; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=agqOG99DDucQX7acWBetuVFb2dp52+I/Fg1BYLWVWi0=; b=NzRrcpqlhoFKHINXGRa0imNhROLNeQoepBmrzTL82R4WmwYXVl61KjtoIWV6CBMgnXQor5 LQ31fUVNviHE4reBWX8XEhd/TJLdaICB/qy+LT5Ps2ZQA0JNgn9K1ivC2r8wC5W3HdQXNv BaFN/5qHhzBCquAcGYgMrgZYuHugbrE= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-623-wPSyA2YpP9itW8A8pSfWpA-1; Fri, 18 Jul 2025 14:45:31 -0400 X-MC-Unique: wPSyA2YpP9itW8A8pSfWpA-1 X-Mimecast-MFC-AGG-ID: wPSyA2YpP9itW8A8pSfWpA_1752864330 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3a4f7ebfd00so1119160f8f.2 for ; Fri, 18 Jul 2025 11:45:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752864329; x=1753469129; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=agqOG99DDucQX7acWBetuVFb2dp52+I/Fg1BYLWVWi0=; b=na4J0Y76RvEjhxQ2eMontTqsI6tg2SeIm0WOhjRRa9jKzBlhuk6unKkorQtgG0w+M4 d2mfXK71H7gohFRuZMRZtTesDXsqeGZ38Lwo1sVj0XzI7yn6NP250NHIbaKiIu5lCuOv xpBUmSs98eSR5J3BWK77IOfIkW7A61rQDkAP1kIvFQhg2arm9ZruAuSLgrBrt6MN4JpZ hgrhDWhC2UEE9MP1gexygp04svRLVisxJ69qTWW+Y+U11tDuu5jMO2GvUnx4MZSUx2nm XZ4Nb7+syRBn4nb6YAqolYAz3W65R+mPtnLoMIGw4VRQCXkTR1ZQlAXuVmCZUK6omRbz h9YQ== X-Gm-Message-State: AOJu0YyhoaxTOpVhPK4TWuEN67/mSPuO7JeuvHx+NftzidTX/XwtHHzZ 7AP94qI6SeUZdpAlbSpDzWlDYOqwhq9iS09pQGzShVrfQl2ABuBvRV98qsGm33taiuqXP4plkF1 7zQle8e7LQq23r708ZDsuVfAD72KpaagLFYIiCU76K2eUmWBs3Eh7xwvsda8DAAZMo9pTxcp+tx 0d+3v7wK2JJ7VriP4pEJzQN3qj/kvo4aHqhhhv X-Gm-Gg: ASbGnctLT37XxFLtKVZ3ytYIgY/supVUMTWxuGwUEHmE7dlZS/JO4Xj30watPueCpzs x8XBFUd1mhG8Lo3yUHbTiV6mVKD6pkcXRhk5trxiqcjO9NcU8aaxErIuIYyCo/MuniLHtCBsUlL gL+bIcMDG/3Xaw6iC+nJN05U6hx3qG/FjfgsKkLktShbhcr9h39UnqXwCdcaZ8jeja4MT1OCe4G SEz3b888BVm2dqvjOEcut0m8I0W3vQi33HsML/3X8+sAexgg6Li6yYmOxw8DRcLlx166bphPnj/ Lk/oZMQgVq7TVWXKmlRazKiNMgBAbiiothgSBMYkUq4ia8WcuTLxpYSgI349kKjaJg64 X-Received: by 2002:a5d:5d12:0:b0:3a4:ee40:715c with SMTP id ffacd0b85a97d-3b613e66f3amr7247194f8f.14.1752864328963; Fri, 18 Jul 2025 11:45:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGuXadjH57P/5qGXpr+iDtu8+Q8IYrHX79p/cwGSm8TfNPIkxZJgLs4PgyLS99jKSRHOfYr5w== X-Received: by 2002:a5d:5d12:0:b0:3a4:ee40:715c with SMTP id ffacd0b85a97d-3b613e66f3amr7247181f8f.14.1752864328413; Fri, 18 Jul 2025 11:45:28 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4563b5b7e6fsm27615285e9.10.2025.07.18.11.45.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Jul 2025 11:45:27 -0700 (PDT) Date: Fri, 18 Jul 2025 20:45:21 +0200 From: Stefano Brivio To: Laurent Vivier Subject: Re: [PATCH v2] style: Fix 'Return' comment style Message-ID: <20250718204521.4d173ba0@elisabeth> In-Reply-To: <20250620093641.1345500-1-lvivier@redhat.com> References: <20250620093641.1345500-1-lvivier@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ktCggpEuLY4y-KN3JXTcT3s6rrv32tKfeJqvtnUIMr8_1752864330 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: B6KDD2AEWWVLF337DCNC7NHJVTHYD4HZ X-Message-ID-Hash: B6KDD2AEWWVLF337DCNC7NHJVTHYD4HZ X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 20 Jun 2025 11:36:41 +0200 Laurent Vivier wrote: > We always use imperative (no 'Returns:'), no tab after the ':' and > only one space, the first character is always lowercase. > > This is fixed with: > > sed -i "s/Returns:/Return:/;s/Return: /Return: /;s/Return: */Return: /;s/Return: \([A-Z]\)/Return: \L\1/" *.[ch] > > And manually updated to fix alignment of multiline comment and words > that must keep uppercase (like IPv4, TCP, UDP, Layer-4). > > Signed-off-by: Laurent Vivier Applied. -- Stefano