From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=erAvk8oE; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id AD8A75A0282 for ; Fri, 18 Jul 2025 20:45:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752864352; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M1KNNssUDCvg/AxF+YPPtl277LIBGdOpMmERcu9L86s=; b=erAvk8oEn6Sxs0NRGZO2MUyUOOsG5SOLdNLq05OqNzpInlKBhrcnKtvY29FJ2Wc6PSwUCV Ohti8L7cE8yHTKtvGT4T4GsWhDvOdon4kmsuigqLKY8/yhDGnUdnRXnNAXfKkfjpSWaYeY LJ38UhCkKgu+Auc7MMF3L8Kc9wFrcD8= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-292-N1pvAjBmMIyCpd5Y_3nLXg-1; Fri, 18 Jul 2025 14:45:51 -0400 X-MC-Unique: N1pvAjBmMIyCpd5Y_3nLXg-1 X-Mimecast-MFC-AGG-ID: N1pvAjBmMIyCpd5Y_3nLXg_1752864350 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-451d2037f1eso15135565e9.0 for ; Fri, 18 Jul 2025 11:45:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752864349; x=1753469149; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=C5Gc4OD32H55Dy8X1gXcF8tb6UPTNqk/s8GcOsiAmNs=; b=nf+X0pRC2je9htv7X+QWts6Uc7DiAoeHdYRhVRNKTeMw78NkC3zifeJrNKngCcwAv7 UdPzZG3vS6J2gZK7pt9Dxf4TP3Iyzb6z3oxhvtnPBj3UdiICPi4WnaeHN710yGJkxVxE /KqIGPizbPq4SoEr43elMSeHz9cA62oVrqtix8O1td8QAcUr9oyNqyo4G9MhbAZj6Csy yWdsiSg2BrJGrqjqceJktzn3QiifEsvfW/GSHGLk/a3u5qsk/4NkgFRglL8S5J6dUJb2 JwaYH9uiFSPhvgrjbgnr6AN1+vmx25uYIHglnRU3dro1c3GzU93uTQv7GufcMf39I2A0 eylw== X-Gm-Message-State: AOJu0Yz5RzvHpHTBRlhgq6GElPov6OclO/xLrxB+4/obCcve5IIISLpQ jVLWh0IRM3bhwM1R0Acbeh+rz/AmYEmkSZLgwtApC4OgCtCoL6hW44ULPZpVqpxK6CEc2zYnnh4 QpeQMcdm5TqRnA/wEPuPcY92SG8+AEQPF6H/8gcHgLXeCQ/AdF40CrTYoCKKv3ZstuSrUbZF3/m 47z5ysHZedI/BMPhX+cCfNeErWo8XOTuVs4vHH X-Gm-Gg: ASbGncsJ+orwffKYNE07ibtk90d6Oq59kRKYexvo8D4cvFzq10GtQ6lmFt2felCktTa 1oTHlHhQpzsQeU3AjlolHSLiRms8BwJaOw7abpQ0LZHitAjr+sJpMhTFarf3Oo5hq7+f4BhBZSG Evyf9VrQiWAKd/ZfoVonHKSb9Q4uZJIowYJOAnF8KeRdowKpcJBXufqjabjqdH+W/hswqmREWvm RRPfmLrlpvzu35u8MA4HNV/jBudSh+8PM/pKXsVRfppuI1Gc6PSADYWA70pY+jBF9J/CUw3ZDYa s3uyjic7EuBPfjd//p/XWgfJK4TcDNEAS25y7i3mdpNF7EwrgvA= X-Received: by 2002:a05:600c:1ca2:b0:455:f6cd:8703 with SMTP id 5b1f17b1804b1-4562e39b29bmr138801705e9.31.1752864348992; Fri, 18 Jul 2025 11:45:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFbNuGVzcfO7UktN/BYAgYVL3kgGsxVnfkOR4aQwDVdxWEb0z2jcdeIlwn5LnIwG+5oW2hkXQ== X-Received: by 2002:a05:600c:1ca2:b0:455:f6cd:8703 with SMTP id 5b1f17b1804b1-4562e39b29bmr138801435e9.31.1752864348528; Fri, 18 Jul 2025 11:45:48 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4563b73f76esm26471705e9.18.2025.07.18.11.45.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Jul 2025 11:45:47 -0700 (PDT) Date: Fri, 18 Jul 2025 20:45:46 +0200 From: Stefano Brivio To: Laurent Vivier Subject: Re: [PATCH v7 00/31] Introduce discontiguous frames management Message-ID: <20250718204546.5ff05d49@elisabeth> In-Reply-To: <20250623110635.1478625-1-lvivier@redhat.com> References: <20250623110635.1478625-1-lvivier@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: DpT_MMTtWYMOtDuNXf9Dr4uHtZUjzNggH4E0UXDo_TA_1752864350 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: YFOVCG4LWQHQBCDXAJXK7XCSMPWFPO5X X-Message-ID-Hash: YFOVCG4LWQHQBCDXAJXK7XCSMPWFPO5X X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 23 Jun 2025 13:06:04 +0200 Laurent Vivier wrote: > This series introduces iov_tail to convey frame information > between functions. >=20 > This is only an API change, for the moment the memory pool > is only able to store contiguous buffer, so, except for > vhost-user in a special case, we only play with iovec array > with only one entry. >=20 > v7: > - Add a patch to fix comment style of 'Return:' > - Fix ignore_arp()/accept_arp() > - Fix coverity error > - Fix several comments I was about to apply this without 1/31 (I applied the v2 of it you sent outside of this series instead, which is actually up to date) and with the minor comment fix to 31/31... but the test perf/passt_vu_tcp fails rather consistently now (and I triple checked without this series): - "TCP throughput over IPv6: guest to host" with MTU 1500 and 9000 bytes now reports between 0 and 0.6 Gbps. The guest kernel prints a series of two messages with ~1-10 =C2=B5s interval: [ 21.159827] TCP: out of memory -- consider tuning tcp_mem [ 21.159831] TCP: out of memory -- consider tuning tcp_mem - "TCP throughput over IPv4: guest to host" never reports 0 Gbps, but the throughput figure for large MTU (65520 bytes) is very low (5.4 Gbps in the last run). Here I'm getting four messages: [ 40.807818] TCP: out of memory -- consider tuning tcp_mem [ 40.807829] TCP: out of memory -- consider tuning tcp_mem [ 40.807829] TCP: out of memory -- consider tuning tcp_mem [ 40.807830] TCP: out of memory -- consider tuning tcp_mem - on the reverse direction, "TCP throughput over IPv4: host to guest" (but not with IPv6), the iperf3 client gets SIGSEGV, but not consistently, it happened once out of five times. To me it smells a bit like we're leaking virtqueue slots but I looked again at the whole series and I couldn't find anything obvious... at least not yet. UDP tests never fail and the throughput is the same as before. I'm stopping here for the moment, let me know if I should run more tests or anything. By the way, I'm running just those tests by enclosing the rest of the sequence in test/run in a dummy function, say: --- diff --git a/test/run b/test/run index f73c311..97b96a4 100755 --- a/test/run +++ b/test/run @@ -67,6 +67,7 @@ run() { =09perf_init =09[ ${CI} -eq 1 ] && video_start ci =20 +dont() { =09setup build =09test build/all =09test build/cppcheck @@ -178,6 +179,8 @@ run() { =09test perf/pasta_udp =09test passt_in_ns/shutdown =09teardown passt_in_ns +} +=09VALGRIND=3D0 =20 =09VHOST_USER=3D1 =09setup passt_in_ns --- ...you could also pass the setup steps plus test to ./run, but you would need to set VHOST_USER=3D1 as well. --=20 Stefano