public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top, Paul Holzinger <pholzing@redhat.com>
Subject: Re: [PATCH] treewide: Flush pcap and log files, if used, before exiting
Date: Fri, 15 Aug 2025 18:15:23 +0200	[thread overview]
Message-ID: <20250815181523.406d6057@elisabeth> (raw)
In-Reply-To: <aJ7Kq485GAUFUIy9@zatzit>

On Fri, 15 Aug 2025 15:50:35 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:

> On Thu, Aug 14, 2025 at 07:12:55AM +0200, Stefano Brivio wrote:
> > On Thu, 14 Aug 2025 14:10:20 +1000
> > David Gibson <david@gibson.dropbear.id.au> wrote:  
> [snip]
> > > Here we're adding a new syscall to work around the problems with
> > > _exit().  In which case, why don't we add futex() to the syscall list
> > > and go back to exit(3).  
> > 
> > Because futex() just came up unexpectedly and Paul and myself had to
> > spend hours figuring that out, and there are good chances we'll get
> > something else like that from glibc in the future.  
> 
> Yes, but that could happen with literally any libc function, I'm not
> convinced that exit() is a target that deserves special attention.

From experience, it clearly did.

Most of the other C library functions we call are relatively simple in
comparison, and almost all the complicated implementations are
directly implemented by system calls instead.

Another notable exception was vsyslog(), and that's why we ship our own
implementation for it.

-- 
Stefano


      reply	other threads:[~2025-08-15 16:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-13 16:45 [PATCH] treewide: Flush pcap and log files, if used, before exiting Stefano Brivio
2025-08-14  4:10 ` David Gibson
2025-08-14  5:12   ` Stefano Brivio
2025-08-14  5:24     ` Stefano Brivio
2025-08-14  5:36       ` David Gibson
2025-08-15  5:50     ` David Gibson
2025-08-15 16:15       ` Stefano Brivio [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250815181523.406d6057@elisabeth \
    --to=sbrivio@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    --cc=pholzing@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).