From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=SsJze/3m; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id E2A675A0271 for ; Fri, 15 Aug 2025 18:15:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1755274529; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DHZ2X/PmM0+TwrAgnCKQsc+Yhdu9cWlwTVta5MwFN+o=; b=SsJze/3moWFpd9rjkHFTP+NDo1d/SPB2IguYL4ycyOUfyxbUAZLL+tUT8zy3Me046rPDgg f2vqQ4cvKC06DHuhAFwYE2Jcd55nNv1l+I+gLs1s9zZxN/SgJl7iE1ltN8nleyFxn0GhqS fIry5+jbIJw6dobS+ZJYaouJS2/L9Jw= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-367-FzFR8AxKM7GELefW2s1TiA-1; Fri, 15 Aug 2025 12:15:27 -0400 X-MC-Unique: FzFR8AxKM7GELefW2s1TiA-1 X-Mimecast-MFC-AGG-ID: FzFR8AxKM7GELefW2s1TiA_1755274526 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-afcb7348249so148856266b.0 for ; Fri, 15 Aug 2025 09:15:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755274525; x=1755879325; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=KgQjKqq96nSwL9Eh3uNon4Lqr7wCW/H1Q1AGjgZJx/0=; b=F9oAfGvfZ7exomtKGibphkMLx6QbpGV6HgzH5cei+VI4rS9H5LY6Tn/TL/E8Wz6Dqq F/Y3YW/RvWqSaLXjCdioO4iVTUbcXBaKfZkd5ZaiW0SougWm2hlb2gHzK+2NZXsNkVvw 9H6+qDV4Nwwh6LGW0shuCeOnpwYMX15uEscM8z+2jMH/86goxE/qvX0XzsgdvjMjpvCj oj6MIzkM1wIUW9gOHwcuwI9Sq1r2BtH/H1ijKO6Kz+ZUP4p/UDZVMa6CLkJoIzt9aIK6 o/FOK+Idw5FnpkiRFQqm33feMAsEByGbFOsI4VNzBo4GptMS/srv/CY9aXgTDtr3LLIs 3Qng== X-Gm-Message-State: AOJu0YxUgObyJEfc03w1UjW8wwBBVdRfte8qnVQzB2lZtwIwrniIX9KA aydfr8RTkoW6fOMgd+mlL30sTMc3cJpZ/M/KlhMRUnxVtd6PFkdUbtI15FJgDknafciHwH3GokM MwmGGqufcO7sdyg/4gr5SxbZ6BPYIneaSdOoBDKdumfmZgckv+3m+IOTanFS/EA== X-Gm-Gg: ASbGncvWPiNZ4eseWCL5c56pFWCrsX2aVcE5zn+uY8NH3ETefCN+sqv1UO9OngHjHKX 8Ee8ldn2dJluOZiH4opBL+2wfbsxPu3g7ZnKxA0vw2udC5yGayF9Y1S7N4mlUpYF2wBo/Pb3NxM yDvNz08e9vHpDNHa1yF5tLkWCKq1AIyxqLotBe7K3/xDESL2R8ndE1H+SLj/T3BotMc6AC5Slc1 oGsR9ywqt7lVUcsESsomUz/NAHQOvzAHKu8eFYBmliJluHMB0Yw4oE7vLxBtmnMmnUku0w1Cg7t EVdvxjXF5hKPTEfejun97dLGGMy7R7iXOPPX7pimml9hDWeYK3G0En1eH2dwKvoN0W/C X-Received: by 2002:a17:907:3ea8:b0:af9:5993:65ed with SMTP id a640c23a62f3a-afcdc062977mr242001566b.6.1755274525538; Fri, 15 Aug 2025 09:15:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEBd4nt6DNW6dMgwWlxSPI0n20S3SiPXFW/940hbX6BNAVmPPAzYbz6kRrMGYVrz5KEyntSiQ== X-Received: by 2002:a17:907:3ea8:b0:af9:5993:65ed with SMTP id a640c23a62f3a-afcdc062977mr241999066b.6.1755274525094; Fri, 15 Aug 2025 09:15:25 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-afcdce72d74sm192319866b.29.2025.08.15.09.15.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Aug 2025 09:15:24 -0700 (PDT) Date: Fri, 15 Aug 2025 18:15:23 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH] treewide: Flush pcap and log files, if used, before exiting Message-ID: <20250815181523.406d6057@elisabeth> In-Reply-To: References: <20250813164510.3382756-1-sbrivio@redhat.com> <20250814071255.3dfbd733@elisabeth> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: SeF221O2q9hO0QwXeP1Ood6PJL5bGh68fZtYz-WS17Y_1755274526 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 3TPI5NMKJWNZQAGM6FKW53Z5PQHXO3TG X-Message-ID-Hash: 3TPI5NMKJWNZQAGM6FKW53Z5PQHXO3TG X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Paul Holzinger X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 15 Aug 2025 15:50:35 +1000 David Gibson wrote: > On Thu, Aug 14, 2025 at 07:12:55AM +0200, Stefano Brivio wrote: > > On Thu, 14 Aug 2025 14:10:20 +1000 > > David Gibson wrote: =20 > [snip] > > > Here we're adding a new syscall to work around the problems with > > > _exit(). In which case, why don't we add futex() to the syscall list > > > and go back to exit(3). =20 > >=20 > > Because futex() just came up unexpectedly and Paul and myself had to > > spend hours figuring that out, and there are good chances we'll get > > something else like that from glibc in the future. =20 >=20 > Yes, but that could happen with literally any libc function, I'm not > convinced that exit() is a target that deserves special attention. >From experience, it clearly did. Most of the other C library functions we call are relatively simple in comparison, and almost all the complicated implementations are directly implemented by system calls instead. Another notable exception was vsyslog(), and that's why we ship our own implementation for it. --=20 Stefano