From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=QsexRkjF; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id D3EBB5A0279 for ; Wed, 20 Aug 2025 13:44:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1755690273; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UnZq1ayao1TK82r9wGwlokEuIPtlKrj+tR8vezeVjOQ=; b=QsexRkjFT1sVj65Hbj4gh6++HPv1kAAtJKpbvFBeRniuh4oGxhaytdoPAaoLa8c0KS3Vzg EYsr4y8RTMb6LHxaIOls5mwXF/133UYlFCw+FZizFqMz0dw4O7bU5STENW8ko4X/lRQXLG e2erPFNL+i23qqp3DQACLZO5dpOE2Dc= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-489-0EAgI4RWMSCHVDXWN_EPVA-1; Wed, 20 Aug 2025 07:44:32 -0400 X-MC-Unique: 0EAgI4RWMSCHVDXWN_EPVA-1 X-Mimecast-MFC-AGG-ID: 0EAgI4RWMSCHVDXWN_EPVA_1755690271 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3b9dc566cb4so3696686f8f.1 for ; Wed, 20 Aug 2025 04:44:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755690270; x=1756295070; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=UnZq1ayao1TK82r9wGwlokEuIPtlKrj+tR8vezeVjOQ=; b=NXwS0IHiWixH3UJOLTPXyyfQjg+tq0JUKIoKTpS2ZhvSMT7qWRYwCtfpLnqLlch90Z 431ETsiFjIgK7poam1HfC8RBkXJgDyB3W+7xm/ErCY58uqgOM2RSvAWwqD2PDmZLzU1i kNhpij6exQmbmkjGybDx5p17J2xFL8O6/Yj64fTwsrArBZGIt+lNiuJ3krfMxyJ2eAZH fkV/hUkE76Boq2pGHWdLkz5givOw1NplFRtSfYHzFDRLwbBtrdb4EbofEEm9tg9UCH6z 87JHD6VqqUQ7qrjN4vMaTROWifVrFxpus/U30pelfxuDXvN4SwjkFySZcbDTgdo/lr+l Yk+A== X-Gm-Message-State: AOJu0Ywlt5ovW3Y9ie6TYLjx1ki86TZ4wkfRg363MdHy93OKxJj2RifP x7i6NBoy0oc5mew5RCRvYizOoR3deTP20kswkXYjdMwbIRiDJ1k5IXFFb0LVgUGMO2GqbHRNCrM EyNMsiZ9X4Tn9Le8OZTRNCeCECnmPTAEqz+VEpaJakWIvPSeRvtNGmqsH8jTUTg== X-Gm-Gg: ASbGncsKcnM1l+AmgdvARKbebJ9au+ra6HybDLInuu4/mBG4gkwdvdU9OpTVaDUWS35 n0uPgNMLQYcEEaLrk8ijMpq482rVvkjzA2SyEZ7t3jkg+F/yjMwWTlIu9qyFCopp4RcuosgFZEf VxwpuQds5pa6jlrZytrpTSaZMvBvnu9dbp4y00LQJMeBrFPJH1dQllRPBUDEQ0SIRPH68qZ9uWh PY/rtyyu5KWMieDWd5LxpI3t+FzJUqclMJ7C40KsWUsdfoa5ZLl879bSFb5y6MPUUJRgARii5kf up4bpE/JM88+L5hpT/tnwxgwmmZ3WspZsWN1uyiy09NHojlgJUM= X-Received: by 2002:a05:6000:2211:b0:3b8:d082:443 with SMTP id ffacd0b85a97d-3c32edc38f3mr1983345f8f.58.1755690270517; Wed, 20 Aug 2025 04:44:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFH+9tyEli58gQNDj8m0O4QveDVUoFPp7CuZYmmbPavrzMg0lyIwkQ7rT5HlCIEkFrEApm1rA== X-Received: by 2002:a05:6000:2211:b0:3b8:d082:443 with SMTP id ffacd0b85a97d-3c32edc38f3mr1983319f8f.58.1755690269983; Wed, 20 Aug 2025 04:44:29 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3c07496f432sm7357493f8f.6.2025.08.20.04.44.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Aug 2025 04:44:29 -0700 (PDT) Date: Wed, 20 Aug 2025 13:44:27 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v4 1/3] test: Extend test scripts to allow running exeter tests. Message-ID: <20250820134427.6a16ad19@elisabeth> In-Reply-To: References: <20250807113237.548294-1-david@gibson.dropbear.id.au> <20250807113237.548294-2-david@gibson.dropbear.id.au> <20250819162738.36d35d52@elisabeth> <20250820115218.2cdab1ba@elisabeth> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: DzE8LrB8gwaxMLTb6klW3IekuXF8Uy4-yiqNR0w-T-g_1755690271 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 7FSDMWUPQABMXWY2HMCRHXNGB63BFM2L X-Message-ID-Hash: 7FSDMWUPQABMXWY2HMCRHXNGB63BFM2L X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 20 Aug 2025 21:10:17 +1000 David Gibson wrote: > On Wed, Aug 20, 2025 at 11:52:18AM +0200, Stefano Brivio wrote: > > On Wed, 20 Aug 2025 12:55:58 +1000 > > David Gibson wrote: > > > > > On Tue, Aug 19, 2025 at 04:27:38PM +0200, Stefano Brivio wrote: > > > > On Thu, 7 Aug 2025 21:32:35 +1000 > > > > David Gibson wrote: > > > > > > > > > Introduce some trivial testcases based on the exeter library. These run > > > > > passt and pasta with --help and --version options. Extend our test > > > > > scripts to run these tests. > > > > > > > > > > Signed-off-by: David Gibson > > > > > --- > > > > > test/.gitignore | 1 + > > > > > test/Makefile | 5 ++++- > > > > > test/lib/exeter | 46 +++++++++++++++++++++++++++++++++++++++++++++ > > > > > test/run | 9 ++++++++- > > > > > test/smoke/smoke.sh | 27 ++++++++++++++++++++++++++ > > > > > 5 files changed, 86 insertions(+), 2 deletions(-) > > > > > create mode 100644 test/lib/exeter > > > > > create mode 100755 test/smoke/smoke.sh > > > > > > > > > > diff --git a/test/.gitignore b/test/.gitignore > > > > > index 3573444f..cf48b885 100644 > > > > > --- a/test/.gitignore > > > > > +++ b/test/.gitignore > > > > > @@ -11,3 +11,4 @@ nstool > > > > > rampstream > > > > > guest-key > > > > > guest-key.pub > > > > > +/exeter/ > > > > > diff --git a/test/Makefile b/test/Makefile > > > > > index bf63db87..332f3f3e 100644 > > > > > --- a/test/Makefile > > > > > +++ b/test/Makefile > > > > > @@ -50,7 +50,7 @@ UBUNTU_NEW_IMGS = xenial-server-cloudimg-powerpc-disk1.img \ > > > > > jammy-server-cloudimg-s390x.img > > > > > UBUNTU_IMGS = $(UBUNTU_OLD_IMGS) $(UBUNTU_NEW_IMGS) > > > > > > > > > > -DOWNLOAD_ASSETS = mbuto podman \ > > > > > +DOWNLOAD_ASSETS = exeter mbuto podman \ > > > > > $(DEBIAN_IMGS) $(FEDORA_IMGS) $(OPENSUSE_IMGS) $(UBUNTU_IMGS) > > > > > > > > Pre-existing, but this broke a while after you switched the image > > > > preparation to Makefile targets, so you can't really expect people to > > > > issue 'make' at the moment. > > > > > > Sorry, I'm not quite sure what the problem is you're getting at. > > > > This: > > -- > > Hm, could you avoid using -- to mark quotes like this. mutt mistakes > it for the sig and cuts it out; it's kind of a pain to paste it back > in for repying. Oops, weird, because that was originally "--\n", without a space: https://en.wikipedia.org/wiki/Signature_block#Standard_delimiter In your quote that has now three spaces. Is it a bug in mutt? I never hit it though (but I almost exclusively use claws-mail). Would "---\n" avoid that? > > $ mkdir psst > > $ cd psst > > $ git clone git://passt.top/passt > > [...] > > $ cd passt/test/ > > $ make > > [...] > > wget -c -O debian-11-generic-ppc64el.qcow2 https://cloud.debian.org/images/cloud/bullseye/latest/debian-11-generic-ppc64el.qcow2 > > --2025-08-20 11:27:05-- > > https://cloud.debian.org/images/cloud/bullseye/latest/debian-11-generic-ppc64el.qcow2 > > Resolving cloud.debian.org (cloud.debian.org)... 2001:6b0:19::165, > > 2001:6b0:19::173, 2001:6b0:19::163, ... > > Connecting to cloud.debian.org > > (cloud.debian.org)|2001:6b0:19::165|:443... connected. > > HTTP request sent, awaiting response... 404 Not Found 2025-08-20 11:27:05 ERROR > > 404: Not Found. > > > make: *** [Makefile:150: debian-11-generic-ppc64el.qcow2] Error 8 > > Ah, right. All the distro wgets are so slow from Australia that I've > always avoided them by keeping the image files in place (or even > copying the back from backups). So, I didn't hit this. Yeah.. we > should do something about that. > > > The (very) old logic would make the "distro" tests fail, but it's > > been a while that one can't really run 'make' under test/ anymore > > (unless you have everything already prepared, that is). > > > On one hand, we don't have a replacement for those tests, and, while > > ugly and clumsy, they were actually useful as they would have told > > us > > in advance about stuff such as: > > > https://bugs.passt.top/show_bug.cgi?id=121 > > > ...and probably much more that we're ignoring now. I don't even test > > routinely on big-endian, we just have build tests from > > distributions. That's bad, and it will be ages before we can > > reasonably get a replacement for that. > > Yeah. On the other hand, we could at least remove the links that are > actually broken. The idea of testing across distros seems to me more > important than the exact set of distros/versions to check - that's > relatively easily expanded if we have the structure. ...or find alternate links / similar versions. Older versions are important, too. For that one, this looks like a stable link: https://cdimage.debian.org/cdimage/cloud/bullseye/20250703-2162/debian-11-generic-ppc64el-20250703-2162.qcow2 -- Stefano