From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=du9y0yVV; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id D67F55A0279 for ; Wed, 20 Aug 2025 21:10:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1755717004; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=89rJE1gomGwloCbXVOT3HnSIMzCQqqLueg8QyIHqYJY=; b=du9y0yVVM32aKrPS3+ciAv9Zyk0YN/pyIVe4GPRnm2w1WZcJyojgPVFV39dDdVG8uWEbYE pA5lx99LtHLd0B9ap8gBli3GrruLNz3ywG+eqOrD5cmH3Us1I3ubJ6z58F7+FafQAyjtFb N0G/7FsA1gYsz2KXGnuWdYKo6thYdvs= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-516-bjvdG_97POy72XoRhBUsLA-1; Wed, 20 Aug 2025 15:10:03 -0400 X-MC-Unique: bjvdG_97POy72XoRhBUsLA-1 X-Mimecast-MFC-AGG-ID: bjvdG_97POy72XoRhBUsLA_1755717002 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-45b467f5173so1088675e9.3 for ; Wed, 20 Aug 2025 12:10:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755717002; x=1756321802; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=89rJE1gomGwloCbXVOT3HnSIMzCQqqLueg8QyIHqYJY=; b=FB5e7ZQkA2N7rmJS4DLylQ57jg2uHEEV0CDUsvuNp4CLcooSuIyaqrH5bp4VH3Agbc FckWx2JE942QgvuwM2oo952HCn2hglrTrm32/FarDV4/xZxgrcXYmAQ/7UlC3Nfgjtlx 5J6QEFVuSH7Lkj4zQsAuYPSJoSx9+3soAL08lDTsE9Asz0i7gVyu6/TTYkM3YtA9Amju Xf/y+bDFoYy+iHgx6uE3piFecuu1FJ8paE7IEyb75hE94iJZc6M7hTHetLPdCE3TKwqy aaO8EYfQYlAs1gTKSYUSKaCb5GJh8oZvyAdODTf6cgWomUgVQsAYOm0Y/InU9q0eur15 T7gQ== X-Gm-Message-State: AOJu0YynJ5O5oOGSyRQ65IpP6UHc3rqi8GzKHs4fat/1eZXAWtzkBnTn vOQ8FhDB2p+Kx97T32WB2c5MzTbk61JFFOSGr7jr/urxCUVpnE0MDChLRp1zqconh7qIJlQCM+B 1FF5ashOPciVnkzCStcwJJ5DUKWC+NSOHwRS7a+ot/5OiNcqEdr1sdw== X-Gm-Gg: ASbGnctHFJILUy+t3G9o6zcuvpbvbVVSalFF/OaRpLswgxcuW6zlmT3m8NoXY9yjFeu uVQkOStfUhC2SpqtnnsQK8uUguDZp0SAtMFLbmSRQcbCSWVTwbWbCnf149umVqcGT6JvPrYcnKj ptyotYLd++th6+Y7DIA9iFd/OWYPJAmYa91LFgI5hDOg/hMZVHhHMrS9lpXrR9ZqiUp8KzdaB8O hXqb2UN/uQm04+DxaXcuEYYBe5YhxH/UOb7yZwSRjQZ10CHJm9m0d1h9REb2ypKuimwI98syk2K HPl3/ElGtKbfL+X6TIF6mBGp4ToLqT2P8+W35ndoieAbmjHODZY= X-Received: by 2002:a05:600c:4447:b0:459:dfde:3324 with SMTP id 5b1f17b1804b1-45b479fd4e4mr33363085e9.29.1755717002097; Wed, 20 Aug 2025 12:10:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGHGRvAlwMZtNm0vZ+86Kn3AxA0bRBPdQGItuG975zHVXnhYsaW5x4be39EEczqvBJzP1t1HA== X-Received: by 2002:a05:600c:4447:b0:459:dfde:3324 with SMTP id 5b1f17b1804b1-45b479fd4e4mr33362935e9.29.1755717001634; Wed, 20 Aug 2025 12:10:01 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45b47c287e6sm49476855e9.1.2025.08.20.12.10.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Aug 2025 12:10:01 -0700 (PDT) Date: Wed, 20 Aug 2025 21:09:59 +0200 From: Stefano Brivio To: passt-dev@passt.top Subject: Re: [PATCH v2 0/6] tcp: Fixes for issues uncovered by tests with 6.17-rc1 kernels Message-ID: <20250820210959.12518e26@elisabeth> In-Reply-To: <20250820165137.2004897-1-sbrivio@redhat.com> References: <20250820165137.2004897-1-sbrivio@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: pXqixRVnseZo_KQjchqdj1mxfjPTpKB7EXgdNmqzHRo_1755717002 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: I3Z5HBO3SNK6CAGDK52755HYRFNYBNZ4 X-Message-ID-Hash: I3Z5HBO3SNK6CAGDK52755HYRFNYBNZ4 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Jon Maloy , Paul Holzinger , David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 20 Aug 2025 18:51:31 +0200 Stefano Brivio wrote: > Starting from Linux kernel commit 1d2fbaad7cd8 ("tcp: stronger > sk_rcvbuf checks"), window limits are enforced more aggressively with > a bigger amount of zero-window updates compared to what happened with > e2142825c120 ("net: tcp: send zero-window ACK when no memory") alone, > and occasional duplicate ACKs can now be seen also for local transfers > with default (208 KiB) socket buffer sizes. > > Paul reports that, with 6.17-rc1-ish kernels, Podman tests for the > pasta integration occasionally fail on the "TCP/IPv4 large transfer, > tap" case. > > While playing with a reproducer that seems to be matching those > failures: > > while true; do ./pasta --trace -l /tmp/pasta.log -p /tmp/pasta.pcap --config-net -t 5555 -- socat TCP-LISTEN:5555 OPEN:/tmp/large.rcv,trunc & (sleep 0.3; socat -T2 OPEN:large.bin TCP:88.198.0.164:5555; ); wait; diff large.bin /tmp/large.rcv || break; done > > and a kernel including that commit, I hit a few different failures, > that should be fixed by this series. > > Paul tested v1 of this series and found an additional failure > (transfer timeout), which I could reproduce with a slightly different > command: > > while true; do ./pasta --trace -l /tmp/pasta.log -p /tmp/pasta.pcap --config-net -t 5555 -- socat TCP-LISTEN:5555 EXEC:./write.sh & (sleep 0.3; socat -T2 OPEN:large.bin TCP:88.198.0.164:5555; ); wait; diff large.bin /tmp/large.rcv || break; done > > where write.sh is simply: > > #!/bin/sh > > cat > /tmp/large.rcv > > so that the connection is not half-closed starting from the beginning, > because socat can't make assumptions about the unidirectional nature > of the traffic. This should now be fixed as well by the new version of > patch 3/6. > > > v2: in 3/6, rewind sequence also if the zero-window update comes in > the middle of a batch with non-zero window updates Hmpf, never mind, this broke (on the second run): TCP/IPv4: ns to host (via tap): big transfer from the main tests (not Podman tests). I still need to look into it. -- Stefano