From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=PK1XxCQm; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 5C8685A0271 for ; Sat, 23 Aug 2025 10:43:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1755938590; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vfULO7YLxz7Z2uNy7z4zt/dNZhLkVeddOKxR2NJeRMc=; b=PK1XxCQmqPnSDEVsg4ux8EJdKD+hxfiafAAUPSDwhsDBiEo1GIci8UauAlgpquJO2NFkIx SKq1lNI2Zcz5FwzS9b0w4s8729C4Pw3YOReF9u+uE4bEJ4Cz4YOza7lOpZwcJFP4szf7Mp /2dvoE2c7J/lZhWz/WYK+FofOxaVsZE= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-122-N5lv-ImhN0yWBZQVSM22sw-1; Sat, 23 Aug 2025 04:43:08 -0400 X-MC-Unique: N5lv-ImhN0yWBZQVSM22sw-1 X-Mimecast-MFC-AGG-ID: N5lv-ImhN0yWBZQVSM22sw_1755938587 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-45a1b0caae1so14552845e9.3 for ; Sat, 23 Aug 2025 01:43:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755938587; x=1756543387; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=vfULO7YLxz7Z2uNy7z4zt/dNZhLkVeddOKxR2NJeRMc=; b=KWb8dNfMNMkDzfYbkBk6EF8kFXyZVQqZjAWTQQRHWD/Dy056tdthQNpWQ9bVwZzFPq qqRLRHJQRDa12zqRTz1cOnhAP4A9TqgJFFC/+nfyZq1O42OpV076URGJ/iuL95XFymN3 JKchOyc74VO16EMXr9trz82frIYhfOtq2JCoEaHrtERQx9cY3OftQJquP+iFg2JsD+Bi Ters4UC2hPWR/t1WFLSEMlaBsPLIkjuTk5XuPl2hnlZW+U/9ACQv058tINf7Nk66WjdH 3FopthcHRdthNZBtNmECLlMeZ66plX/lyDCyK3ktK2c5jXON3HvxESWg85DNGRno3My0 ynQg== X-Forwarded-Encrypted: i=1; AJvYcCWtks0xid2xtdTQsV2NFcm0Tx3X9UaQCVRnL4NBUPInz+Nc0JNaZjBa+BlfqRrmwGwXUPjqeZw/4iQ=@passt.top X-Gm-Message-State: AOJu0YzICLliXhIZu9YeAVswT87xwluQiKUT0nCaqoy6dMSJ9zZ2kTyo uaKAc0p9cCtKGW2pvpMg+fR4Ixqx/jyUeNznmXmsu3Ai4lJUS//QebdrOxKzNQmU3RMfPxLYGRM S3hO53Qbw6KA4u1WsEfWOn6mIwkjrMN2E+G9A8I0aACHnmlsODD/bxA== X-Gm-Gg: ASbGncumuNWz70ok6lSiPxuMSycgS0WGpWeae5UEgx70tsoe2CqbWlPmD6yFNArLvX4 CqDPxUaKBDMzxcwRtGfN6HjHho5OPsctkIrK7uiId/CFJrc/O57UDQ8ox8k2BfwrhCkSx99nOXM FXoHqUhCVyGRWXRbN7vW3IHouoJnIH1BkVd7jvWbolwTC6qgcPY4GwEdcJzQgcdEKHozpVespwC uk5PTxLIJlCC38+8fCg0if0I6xoDKpUwANx6vNq4xWVpfHI+SK1cMQlqvAc8u2KNstUjLqJjlYy vbbDRAi7QKKzBUxxP9xk5GjZDlKhIkchkXRuntke/CHxXM/NOaQ= X-Received: by 2002:a05:600c:45ce:b0:459:dba8:bb7b with SMTP id 5b1f17b1804b1-45b517ad7ebmr46997395e9.13.1755938587180; Sat, 23 Aug 2025 01:43:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEvj5I9ZXxDJGaFwa0dfJ5P6LVd376XfbNITRqgnxSw6PLCrBR5O0c8jn+3Z4dPfT9BVo3FDg== X-Received: by 2002:a05:600c:45ce:b0:459:dba8:bb7b with SMTP id 5b1f17b1804b1-45b517ad7ebmr46997215e9.13.1755938586708; Sat, 23 Aug 2025 01:43:06 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3c70e4b9f8dsm2954620f8f.9.2025.08.23.01.43.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Aug 2025 01:43:06 -0700 (PDT) Date: Sat, 23 Aug 2025 10:43:04 +0200 From: Stefano Brivio To: wangzijie Subject: Re: [PATCH] proc: Bring back lseek() operations for /proc/net entries Message-ID: <20250823104305.148e3a02@elisabeth> In-Reply-To: <20250823015349.1650855-1-wangzijie1@honor.com> References: <20250822172335.3187858-1-sbrivio@redhat.com> <20250823015349.1650855-1-wangzijie1@honor.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: SSWKyNtNpOknBdUiKJX4PvX5zY9rNHVG5yVQ0-OxmfI_1755938587 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: K3YQ2HKBTS5ZTV375FJPF5SHXGIJXJXM X-Message-ID-Hash: K3YQ2HKBTS5ZTV375FJPF5SHXGIJXJXM X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: adobriyan@gmail.com, akpm@linux-foundation.org, ast@kernel.org, brauner@kernel.org, kirill.shutemov@linux.intel.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, passt-dev@passt.top, rick.p.edgecombe@intel.com, viro@zeniv.linux.org.uk, jirislaby@kernel.org, Lars Wendler X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hi wangzijie, On Sat, 23 Aug 2025 09:53:49 +0800 wangzijie wrote: > > Commit ff7ec8dc1b64 ("proc: use the same treatment to check proc_lseek > > as ones for proc_read_iter et.al") breaks lseek() for all /proc/net > > entries, as shown for instance by pasta(1), a user-mode network > > implementation using those entries to scan for bound ports: > > > > $ strace -e openat,lseek -e s=none pasta -- true > > [...] > > openat(AT_FDCWD, "/proc/net/tcp", O_RDONLY|O_CLOEXEC) = 12 > > openat(AT_FDCWD, "/proc/net/tcp6", O_RDONLY|O_CLOEXEC) = 13 > > lseek(12, 0, SEEK_SET) = -1 ESPIPE (Illegal seek) > > lseek() failed on /proc/net file: Illegal seek > > lseek(13, 0, SEEK_SET) = -1 ESPIPE (Illegal seek) > > lseek() failed on /proc/net file: Illegal seek > > openat(AT_FDCWD, "/proc/net/udp", O_RDONLY|O_CLOEXEC) = 14 > > openat(AT_FDCWD, "/proc/net/udp6", O_RDONLY|O_CLOEXEC) = 15 > > lseek(14, 0, SEEK_SET) = -1 ESPIPE (Illegal seek) > > lseek() failed on /proc/net file: Illegal seek > > lseek(15, 0, SEEK_SET) = -1 ESPIPE (Illegal seek) > > lseek() failed on /proc/net file: Illegal seek > > [...] > > > > That's because PROC_ENTRY_proc_lseek isn't set for /proc/net entries, > > and it's now mandatory for lseek(). In fact, flags aren't set at all > > for those entries because pde_set_flags() isn't called for them. > > > > As commit d919b33dafb3 ("proc: faster open/read/close with "permanent" > > files") introduced flags for procfs directory entries, along with the > > pde_set_flags() helper, they weren't relevant for /proc/net entries, > > so the lack of pde_set_flags() calls in proc_create_net_*() functions > > was harmless. > > > > Now that the calls are strictly needed for lseek() functionality, > > add them. > > > > Fixes: ff7ec8dc1b64 ("proc: use the same treatment to check proc_lseek as ones for proc_read_iter et.al") > > Signed-off-by: Stefano Brivio > > --- > > fs/proc/generic.c | 2 +- > > fs/proc/internal.h | 1 + > > fs/proc/proc_net.c | 4 ++++ > > 3 files changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/fs/proc/generic.c b/fs/proc/generic.c > > index 76e800e38c8f..57ec5e385d1b 100644 > > --- a/fs/proc/generic.c > > +++ b/fs/proc/generic.c > > @@ -561,7 +561,7 @@ struct proc_dir_entry *proc_create_reg(const char *name, umode_t mode, > > return p; > > } > > > > -static void pde_set_flags(struct proc_dir_entry *pde) > > +void pde_set_flags(struct proc_dir_entry *pde) > > { > > if (pde->proc_ops->proc_flags & PROC_ENTRY_PERMANENT) > > pde->flags |= PROC_ENTRY_PERMANENT; > > diff --git a/fs/proc/internal.h b/fs/proc/internal.h > > index e737401d7383..a358974f14d2 100644 > > --- a/fs/proc/internal.h > > +++ b/fs/proc/internal.h > > @@ -284,6 +284,7 @@ extern struct dentry *proc_lookup(struct inode *, struct dentry *, unsigned int) > > struct dentry *proc_lookup_de(struct inode *, struct dentry *, struct proc_dir_entry *); > > extern int proc_readdir(struct file *, struct dir_context *); > > int proc_readdir_de(struct file *, struct dir_context *, struct proc_dir_entry *); > > +void pde_set_flags(struct proc_dir_entry *pde); > > > > static inline void pde_get(struct proc_dir_entry *pde) > > { > > diff --git a/fs/proc/proc_net.c b/fs/proc/proc_net.c > > index 52f0b75cbce2..20bc7481b02c 100644 > > --- a/fs/proc/proc_net.c > > +++ b/fs/proc/proc_net.c > > @@ -124,6 +124,7 @@ struct proc_dir_entry *proc_create_net_data(const char *name, umode_t mode, > > p->proc_ops = &proc_net_seq_ops; > > p->seq_ops = ops; > > p->state_size = state_size; > > + pde_set_flags(p); > > return proc_register(parent, p); > > } > > EXPORT_SYMBOL_GPL(proc_create_net_data); > > @@ -170,6 +171,7 @@ struct proc_dir_entry *proc_create_net_data_write(const char *name, umode_t mode > > p->seq_ops = ops; > > p->state_size = state_size; > > p->write = write; > > + pde_set_flags(p); > > return proc_register(parent, p); > > } > > EXPORT_SYMBOL_GPL(proc_create_net_data_write); > > @@ -217,6 +219,7 @@ struct proc_dir_entry *proc_create_net_single(const char *name, umode_t mode, > > pde_force_lookup(p); > > p->proc_ops = &proc_net_single_ops; > > p->single_show = show; > > + pde_set_flags(p); > > return proc_register(parent, p); > > } > > EXPORT_SYMBOL_GPL(proc_create_net_single); > > @@ -261,6 +264,7 @@ struct proc_dir_entry *proc_create_net_single_write(const char *name, umode_t mo > > p->proc_ops = &proc_net_single_ops; > > p->single_show = show; > > p->write = write; > > + pde_set_flags(p); > > return proc_register(parent, p); > > } > > EXPORT_SYMBOL_GPL(proc_create_net_single_write); > > -- > > 2.43.0 > > Hi Stefano, > Thanks for your patch, Lars reported this bug last week: > https://lore.kernel.org/all/20250815195616.64497967@chagall.paradoxon.rec/ Apologies, I didn't see that. It's definitely the same issue. > Jiri suggested to make pde_set_flags() part of proc_register(). I think it can help > to avoid lack of pde_set_flags() calls in the future and make code clean. Right, I was pondering to try something like that, but I just wanted to submit a minimal fix for the moment being. In any case, you have it ready, and it's obviously cleaner than my solution, so, of course, let's discard my patch. > I have submitted a patch: > https://lore.kernel.org/all/20250821105806.1453833-1-wangzijie1@honor.com I just tested it, it works for me. Thanks for fixing that! -- Stefano