From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Wm1TgLNt; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id E5A5F5A0271 for ; Tue, 02 Sep 2025 09:27:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756798072; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y5LzUe/ScCOCyEkCLj5AfYSf3aBrlN2DsbI5V+wEUo8=; b=Wm1TgLNtgMIWUPCk5+qdZDCSgbysK1Vxha/DSZrDm0mHyALeWajWhxt7NX8wlyGv+uLY4/ 5zKuzV/lR+r0jSyKCzYd0KOenWQ0Xjp9eIfJw2dk0Wd+q4Uzor2xMym9wbp3wIxV3C5Eau 0wmZ4uQir+YW51EC+7F4195Na5Klyk8= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-639-vlE0s2l2OUqs9NCYJiIWwg-1; Tue, 02 Sep 2025 03:27:51 -0400 X-MC-Unique: vlE0s2l2OUqs9NCYJiIWwg-1 X-Mimecast-MFC-AGG-ID: vlE0s2l2OUqs9NCYJiIWwg_1756798071 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-45b80aecb97so33663285e9.3 for ; Tue, 02 Sep 2025 00:27:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756798069; x=1757402869; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=nmfSVArGwNo7MmklVWdvS2YHwkeOcQFha9Gseo+jUyQ=; b=cEeMY++5qnzuaNYWqExtctLCzd0QmdFsQBiRbA6aOl8IB5U0wRQwGNVgWbAW3tsWBd UE/Fk3NGBXM5HxxwORPWU/LjddqFBL8qXewwlONv9X1KzobE0hxcdl6IrFxq8fzJRGxo Jo6RKmJEbVnKN6dHBDNkjHognGVRmWMxU/XgF4Yg/XJbAr5udz7I0keBVOGHO7O9GmOh +1kHnlK5OsdEj5mYXDekW9ZnmwSzlU5xO39QNGFpKInYQarTDxS1wq/bXSuzQ4RwIuCg M6Vqs81bVHSlN/4pIP5Tt94Qh921rg7rGFpqbw3a6erMmqpimnjO2ZDJlhYeeKMmj2+e PLGA== X-Gm-Message-State: AOJu0YxHjWf3oj0L65qI0YpIH+i4bY2EsorBKroNvoHK7do97MM7IQ8+ LCEVEzskKm2K0t9u3/UTbFP8BMjXEzit7OQYJDWs860eHUSMXWVH9Fq/zTRa+IxhEmemvOsi192 dFKfBSk1Yrf1TNKFf97wHR2aXe0ygBiaUROYmlBsL0u/f1DeCRDD1Bnunt5EwMN+fwsBKMOLMmQ G0YAmWVbJtaLh9UD16L1Jb10j4+IJMOXhmKalA X-Gm-Gg: ASbGncsCQbWl2uF0HaJ+PR/cPYp8H5AfockrsVvRZCeeZvNK1/7GBXzrvjTNTPIwSyb wjFb2x+fK4hRCvQK9WioIk7UFFaFw4FIss2T67hhx4Dj8ydQvhIaPO90gfJ4lJwA98ew5Mr4dYp isvg/b2xU9utnaX093/cPL6KTDwaQrAInWdCFybl5EgHbSiOglZYNygC41lDdagXzgt9RQ2CiK7 5HPWICGoGiIr6dJ90LDm8OSdxgB/hVl7ii6FQvDRguOB1TWLQo+ag9hxQffE9UxVPirSF690bz8 5Pv5gf12QEM3UrB35qIj8hgPUwmFSaOlB/e7MoHHyZigw7KpwEE= X-Received: by 2002:a05:600c:4e07:b0:45b:8795:4caa with SMTP id 5b1f17b1804b1-45b87954e09mr72646575e9.36.1756798068904; Tue, 02 Sep 2025 00:27:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG1loH9SrqsU43btWUvpVomDYTxspdWR4KnD1qwQyeBWzYtKFrf4HyvMGZQAQxo0QQcvSK2jQ== X-Received: by 2002:a05:600c:4e07:b0:45b:8795:4caa with SMTP id 5b1f17b1804b1-45b87954e09mr72646405e9.36.1756798068359; Tue, 02 Sep 2025 00:27:48 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45b87632365sm131802435e9.16.2025.09.02.00.27.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Sep 2025 00:27:46 -0700 (PDT) Date: Tue, 2 Sep 2025 09:27:45 +0200 From: Stefano Brivio To: Yumei Huang Subject: Re: [PATCH] build: Fix errors of TCP_REPAIR_* undeclared Message-ID: <20250902092745.017ac037@elisabeth> In-Reply-To: References: <20250901094510.27813-1-yuhuang@redhat.com> <20250901230219.679a9f27@elisabeth> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: PwApOZ8ZYz54Ya23l0bVhJAi38AML3gquBETLbwEhrU_1756798071 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 2AOSSG2EBTGXNCM7NN6CRTVGGGFJF7GC X-Message-ID-Hash: 2AOSSG2EBTGXNCM7NN6CRTVGGGFJF7GC X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, dgibson@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 2 Sep 2025 10:54:35 +0800 Yumei Huang wrote: > Thank you Stefano for all the comments. Sent v2 to address all the issue= s, > just that.. >=20 > On Tue, Sep 2, 2025 at 5:02=E2=80=AFAM Stefano Brivio wrote: >=20 > > Thanks for the patch! A couple of comments, all minor: > > > > On Mon, 1 Sep 2025 17:45:10 +0800 > > Yumei Huang wrote: > > =20 > > > Fix the following errors on systems with glibc < 2.29: =20 > > > > Before anything, it's customary to credit the original author of a > > patch, even if it was (very) different. Something like: > > > > Based on an original patch by Dongsheng, fix ... > > > > and I think you should also Cc: them (they might want to test / comment > > / review), you can fetch the contact from > > https://bugs.passt.top/show_bug.cgi?id=3D121. > > =20 > > > > > > tcp.c: In function =E2=80=98tcp_flow_repair_on=E2=80=99: > > > tcp.c:2787:38: error: =E2=80=98TCP_REPAIR_ON=E2=80=99 undeclared (fir= st use in this =20 > > function); did you mean =E2=80=98TCP_REPAIR=E2=80=99? =20 > > > if ((rc =3D repair_set(c, conn->sock, TCP_REPAIR_ON))) > > > ^~~~~~~~~~~~~ > > > TCP_REPAIR > > > tcp.c:2787:38: note: each undeclared identifier is reported only once= =20 > > for each function it appears in =20 > > > tcp.c: In function =E2=80=98tcp_flow_repair_off=E2=80=99: > > > tcp.c:2807:38: error: =E2=80=98TCP_REPAIR_OFF=E2=80=99 undeclared (fi= rst use in this =20 > > function); did you mean =E2=80=98TCP_REPAIR=E2=80=99? =20 > > > if ((rc =3D repair_set(c, conn->sock, TCP_REPAIR_OFF))) > > > ^~~~~~~~~~~~~~ > > > TCP_REPAIR > > > make: *** [Makefile:94: passt] Error 1 > > > > > > Signed-off-by: Yumei Huang =20 > > > > Just before this tag, we typically add any references, always using the > > "Link:" tag for simplicity. > > > > Many other projects use separate tags such as "Bug:", "Bugzilla:", > > "Closes:" and so on, but we don't, so that it's a bit easier to > > automate parsing, if needed. In this case that would be: > > > > Link: https://bugs.passt.top/show_bug.cgi?id=3D121 > > > > and perhaps a Reported-by: tag would also be good to have, here. > > =20 > > > --- > > > linux_dep.h | 6 ++++++ > > > passt-repair.c | 1 + > > > 2 files changed, 7 insertions(+) > > > > > > diff --git a/linux_dep.h b/linux_dep.h > > > index 240f50a..c200444 100644 > > > --- a/linux_dep.h > > > +++ b/linux_dep.h > > > @@ -135,6 +135,12 @@ struct tcp_info_linux { > > > #define CLOSE_RANGE_UNSHARE (1U << 1) > > > #endif > > > > > > +#ifndef TCP_REPAIR_ON > > > +#define TCP_REPAIR_ON 1 > > > +#define TCP_REPAIR_OFF 0 > > > +#define TCP_REPAIR_OFF_NO_WP -1 /* Turn off without window = =20 > > probes */ > > > > We use tabs for indentation, and a full tab is displayed as 8 character= s > > wide. For example: > > > > #define TCP_REPAIR_ON 1 > > ^^ two tabs here, so that TCP_REPAIR_OFF_NO_WP is > > aligned too > > > > I did replace the spaces here with two tabs in v2, and it shows aligne= d =20 > in my editors both vim and vscode, but it seems it's not in gmail. > Tried 'set tabstop=3D8' and removed 'set expandtab' in the .vimrc file, a= nd > got the same result. Not sure what's going wrong... I'm not sure either, just mind that you shouldn't rely on the web interface of Gmail because it won't show you emails / patches exactly as they are. But v2 looks good to me, so I guess you fixed it. :) Two more things: 1. look at two paragraph above this one, you'll see that quoting is not correct: > > I did replace ... > in my editors it looks as if "I did replace ..." is from my reply, not from yours. I've seen this issue with people using Gmail but as far as I understood it's a known issue on Gmail side and they don't plan to fix it. 2. your reply contains an HTML version. While I configured passt mailing lists to be tolerant of that, I think that many upstream mailing lists (e.g. kernel lists) will just drop your message altogether if it contains an HTML part. In the end, I would suggest you use an email client instead, which makes it so much easier to work with code. I use claws-mail, other popular options include Thunderbird, Sylpheed, mutt. Maybe it can all be fixed with Gmail configurations, I'm not sure, but I've seen people struggling quite a bit before deciding to use an email client (at least for lists and patches). --=20 Stefano