From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=NQqTnepV; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 4152B5A0271 for ; Tue, 02 Sep 2025 14:23:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756815810; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t0uAgxzk3zf6XqavEQ2YkLiln9FkkTPrk4vQV0GnVKU=; b=NQqTnepVCKoxHjx5L72dUJHygmpRKS4fUaCZPGs01jfvQv1IwBi/3DfT0mRuSYMQErqyL7 I87Yi5P7qjm/Ek8KZB3egUfSuCS5m2la/sq2jdXL5uxglXrrKST/3iOdZ1WgWc6KuEw6sR BxjPr3m61KIrGchhgmw+grNwfBD1hJw= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-329-pfqsxd9KOGmPOF5MeMhURA-1; Tue, 02 Sep 2025 08:23:29 -0400 X-MC-Unique: pfqsxd9KOGmPOF5MeMhURA-1 X-Mimecast-MFC-AGG-ID: pfqsxd9KOGmPOF5MeMhURA_1756815808 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-45b9c1b74e1so2278895e9.1 for ; Tue, 02 Sep 2025 05:23:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756815807; x=1757420607; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=t0uAgxzk3zf6XqavEQ2YkLiln9FkkTPrk4vQV0GnVKU=; b=E+nMocOBoOA/IlXovpU+h8aWHHl2xt0y8QNgJzI7/3OI1uipmQKckARoIOKQOZCHA1 wf8RS67wVoGkRjmUloogON1gevWgXq6d1fJaBOF8cm1JhzFKYUrbFeH7U+xOtL8y5BEO eZPewxxl8KrN5Nwd8wS/TlXAF7yXab/TdJBC7Q8yFPaO9h5zu0rKN5TbSAVH9V7MtNYB SGc6FyHrDtTGAJMdp4uZWbZNzyJa2sc7mkBpzPbQhKWPq7No5C+FrW2wQ/8uRlFjOMGt AgRiNhwe2Cjf2VCZdhTZWQrTa+aRwAcwS/3uQ3cZ+11QXe43SE3gYw2OC8/whtR6CYQY 0sOg== X-Gm-Message-State: AOJu0YxVaHB8OmNMsaq5BoaJqi4TLI2LaD04CEH1/rEXdzrEK5o9rc/+ TBjGrgFrzFKMQ08Tb27/3clbLhVhrQodQ+FdKKk+7msaGeOMVKVRtElYow8VkpngU2FvKZvGuLy 7ciBv0ZHUoN7ttuB7cWqXjuJ8HUNXE2w+Z5/5NG/xUcWtewMoUMRkb/+jMU7wag== X-Gm-Gg: ASbGnct2KPXHevPmnaG2DK45b9plRGsD8gsENTsGypQtubqpvAQV3wHCAvSU/Dt8r/a nHKW+UYU5+z3HqvCG4b6Cey/+TYM+UMmzHpuke6AdIYPPOGYdEoCjea+MgXbodO0nqeosUkwY3n Lg6I5NLVBE8ULgaA64nswskHh4sQuJch3/ff/a6iYvj8vNpe2nrO+dHRBqvuolBtq9TCYBzYGig LqPE2+EugrWbhiLhNVDtAPzK0KSesyGFKWHNt2Zoky60kUc0cp3oR84yVP+PROCPWznnrF2jAyw lyLamwBne8utbCkJwUHC1dSbH1BQGTI1BJxd1IiCGFe9bjNndGE= X-Received: by 2002:a05:600c:4692:b0:45b:7dac:af41 with SMTP id 5b1f17b1804b1-45b8558b869mr82553175e9.32.1756815807406; Tue, 02 Sep 2025 05:23:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFS94lgsYod6xE38wrUoCtGG+2eqparnGSn6KWOdZodL5JxJElrw+RDAOc81F5CUwm/X8ZO1A== X-Received: by 2002:a05:600c:4692:b0:45b:7dac:af41 with SMTP id 5b1f17b1804b1-45b8558b869mr82552925e9.32.1756815806940; Tue, 02 Sep 2025 05:23:26 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45b732671b7sm137439455e9.3.2025.09.02.05.23.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Sep 2025 05:23:25 -0700 (PDT) Date: Tue, 2 Sep 2025 14:23:23 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v6 3/4] test: Convert build tests to exeter Message-ID: <20250902142323.28cf5c6d@elisabeth> In-Reply-To: References: <20250901042515.138861-1-david@gibson.dropbear.id.au> <20250901042515.138861-4-david@gibson.dropbear.id.au> <20250902093953.734411c7@elisabeth> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ToP1HEFkOKh5HJSyOF9lMLPQZHIJppla3tdKJBRKrCQ_1756815808 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: LH2JXBDCPCLYOC3HJZC3M53ZVBTDOCZU X-Message-ID-Hash: LH2JXBDCPCLYOC3HJZC3M53ZVBTDOCZU X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 2 Sep 2025 20:41:41 +1000 David Gibson wrote: > On Tue, Sep 02, 2025 at 09:39:53AM +0200, Stefano Brivio wrote: > > On Mon, 1 Sep 2025 14:25:14 +1000 > > David Gibson wrote: > > > > > +def test_make(target: str, expected_files: list[str]) -> None: > > > + """Test `make {target}` > > > + > > > + Arguments: > > > + target -- make target to invoke > > > + expected_files -- files make is expected to create > > > + > > > + Verifies that > > > + 1) `make target` completes successfully > > > + 2) expected_files care created by `make target` > > > + 3) expected_files are removed by `make clean` > > > + """ > > > + > > > + ex_paths = [Path(f) for f in expected_files] > > > + with clone_sources(): > > > + for p in ex_paths: > > > + assert not p.exists(), f"{p} existed before make" > > > + sh(f'make {target} CFLAGS="-Werror"') > > > + for p in ex_paths: > > > + assert p.exists(), f"{p} wasn't made" > > > + sh('make clean') > > > + for p in ex_paths: > > > + assert not p.exists(), f"{p} existed after make clean" > > > + > > > + > > > +exeter.register('make_passt', test_make, 'passt', ['passt']) > > > +exeter.register('make_pasta', test_make, 'pasta', ['pasta']) > > > +exeter.register('make_qrap', test_make, 'qrap', ['qrap']) > > > +exeter.register('make_all', test_make, 'all', ['passt', 'pasta', 'qrap']) > > > > I guess I'm missing something, but how do you set descriptions from > > Python? > > There are two ways: > 1) > > foo = exeter.register(...) > foo.set_description("test that does the thing") > > 2) > > By default exeter will take it from the first line of the test > function's docstring. Ah, this is really convenient. I mean I saw it happening but I wasn't sure why. :) -- Stefano