From: Stefano Brivio <sbrivio@redhat.com>
To: Yumei Huang <yuhuang@redhat.com>
Cc: passt-dev@passt.top, dgibson@redhat.com, dongsheng.song@gmail.com
Subject: Re: [PATCH v2] build: Fix errors of TCP_REPAIR_* undeclared
Date: Tue, 2 Sep 2025 19:06:56 +0200 [thread overview]
Message-ID: <20250902190656.00c02de9@elisabeth> (raw)
In-Reply-To: <20250902021728.6889-1-yuhuang@redhat.com>
On Tue, 2 Sep 2025 10:17:28 +0800
Yumei Huang <yuhuang@redhat.com> wrote:
> Based on an original patch by Dongsheng, fix the following errors on systems with glibc < 2.29:
>
> tcp.c: In function ‘tcp_flow_repair_on’:
> tcp.c:2787:38: error: ‘TCP_REPAIR_ON’ undeclared (first use in this function); did you mean ‘TCP_REPAIR’?
> if ((rc = repair_set(c, conn->sock, TCP_REPAIR_ON)))
> ^~~~~~~~~~~~~
> TCP_REPAIR
> tcp.c:2787:38: note: each undeclared identifier is reported only once for each function it appears in
> tcp.c: In function ‘tcp_flow_repair_off’:
> tcp.c:2807:38: error: ‘TCP_REPAIR_OFF’ undeclared (first use in this function); did you mean ‘TCP_REPAIR’?
> if ((rc = repair_set(c, conn->sock, TCP_REPAIR_OFF)))
> ^~~~~~~~~~~~~~
> TCP_REPAIR
> make: *** [Makefile:94: passt] Error 1
>
> Link: https://bugs.passt.top/show_bug.cgi?id=121
> Reported-by: Dongsheng <dongsheng.song@gmail.com>
> Signed-off-by: Yumei Huang <yuhuang@redhat.com>
Applied, thanks, and welcome to the git log!
--
Stefano
next prev parent reply other threads:[~2025-09-02 17:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-02 2:17 [PATCH v2] build: Fix errors of TCP_REPAIR_* undeclared Yumei Huang
2025-09-02 17:06 ` Stefano Brivio [this message]
2025-09-03 2:09 ` Yumei Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250902190656.00c02de9@elisabeth \
--to=sbrivio@redhat.com \
--cc=dgibson@redhat.com \
--cc=dongsheng.song@gmail.com \
--cc=passt-dev@passt.top \
--cc=yuhuang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).