From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Y0oW5ndT; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 8A5095A0271 for ; Tue, 02 Sep 2025 19:07:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756832821; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oE7QjrzzLgP6t6Kw9wUcezjmHpQ9ERm98yvZCYUKMLo=; b=Y0oW5ndTScIXCvKrDy67OtnhGo0jQ4XF42Pp+nZo98r5mnvX5KT+mrz3vnScoPWeNQfJ89 kTdhMtx2a+nVJEpud1As4GUEQ6K+zi7KLGF2Gz9rYOmeu3EPHVA9I9UnIEpSqymVIS8PXi HFT+S52p09VTUIwXBPdS+bPfAhoycew= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-347-Nc0F7w6UO0yI2pTf-BkMVA-1; Tue, 02 Sep 2025 13:06:59 -0400 X-MC-Unique: Nc0F7w6UO0yI2pTf-BkMVA-1 X-Mimecast-MFC-AGG-ID: Nc0F7w6UO0yI2pTf-BkMVA_1756832818 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3cf48ec9dcbso4583687f8f.2 for ; Tue, 02 Sep 2025 10:06:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756832818; x=1757437618; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=oE7QjrzzLgP6t6Kw9wUcezjmHpQ9ERm98yvZCYUKMLo=; b=dc0Wi2pvcn0f4bnjLkFqoRBEO26ZjQSmIVt0ZepKm9U0OUsRIiB1sXjn3OOmLYWDVD xYzDMJIMwAD7AcaujzhZOUScJDDx26OCqG1giHw0s/9y9iq9b+NTxuG0ycelmACVDXpC OBs3WR1Go10iCr/LRyIqt/UjdJgfIRP9Y1DP3s+0myqVdzg7OzXdwMnZut7/I/q2rYQe J+/h8TMJhkgsPg7Ntiy4nQIHIMr5PludQ+4vDMTlOuiepAxF3OlCQ7erKxONTKLIgOOy TMHgvgYGHwcU3GaE0Ba9HZXys+l9df27S1osPlTj7KnN9DYjmVwa1Lmp86MufPJp0jU8 X2cQ== X-Gm-Message-State: AOJu0YwGrHCiVKKYwAlmVXRQTGFRzl65eODz/l0utvQ3msUAtnbUzy1s ipcJz2gAe3pT2YZtoyc2/6JWkYTJ0JS7JBxHm0tkPn8vbAcyFitMiOj5PbVjesGZCOD8zBRX4ja Tdj/sw1/pxb1POWjfTBN9f8auBDKOT5Ns2Ln+16ZHoy34DhGprTOsAg== X-Gm-Gg: ASbGncvPVsFXoDPv+FPXWni3cMBzMUcXYIIZRVIOVGvYmK1ZgJvuVUjfn+oaNpB7u7i TtJzJZka0MKgdzY6eIrlF99STIJdF07q4ZelMGf+Izn8rgBH0erz3quKjYxHomjxh53+iMhGl2e wqc4Y7tzy1hONx1MAsOITnHhq/Ax2tQ6trDQeXE4fxz239BWRuJ5+sOexro8dpG3VtwC/KQwGRh UKIP61tO9f9tXaHgJBthe0Z4/9ovRKWIOu4iB57LAEoGKvfJ1FroJ/Gnbc5LErXjiwhVWHrH+5i 6rkTVp1nGciV80fpCtQgFWsjbUkA7Wcr2n+atf5eswZBZlesZiCLMTPq5jFw1q/6zvyH X-Received: by 2002:a05:6000:2c06:b0:3d1:c805:827 with SMTP id ffacd0b85a97d-3d1dc5a2113mr10434146f8f.5.1756832818349; Tue, 02 Sep 2025 10:06:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFFrqGKgwlxKT2FiCFXXaUs/tLzunSDSUIhu/fbPScIe+QN4VshsipqzVwnpZIqRjJsTc0GxQ== X-Received: by 2002:a05:6000:2c06:b0:3d1:c805:827 with SMTP id ffacd0b85a97d-3d1dc5a2113mr10434123f8f.5.1756832817937; Tue, 02 Sep 2025 10:06:57 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45b8f2d3c88sm72517625e9.19.2025.09.02.10.06.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Sep 2025 10:06:57 -0700 (PDT) Date: Tue, 2 Sep 2025 19:06:56 +0200 From: Stefano Brivio To: Yumei Huang Subject: Re: [PATCH v2] build: Fix errors of TCP_REPAIR_* undeclared Message-ID: <20250902190656.00c02de9@elisabeth> In-Reply-To: <20250902021728.6889-1-yuhuang@redhat.com> References: <20250902021728.6889-1-yuhuang@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: XcqgfVUqffXzsLeq1M55M5oHF5y9plcUaovzaGJxQEM_1756832818 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: D3DAJ5L5KPA3FCYAXWCAQQSFFR7AFB5P X-Message-ID-Hash: D3DAJ5L5KPA3FCYAXWCAQQSFFR7AFB5P X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, dgibson@redhat.com, dongsheng.song@gmail.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 2 Sep 2025 10:17:28 +0800 Yumei Huang wrote: > Based on an original patch by Dongsheng, fix the following errors on syst= ems with glibc < 2.29: >=20 > tcp.c: In function =E2=80=98tcp_flow_repair_on=E2=80=99: > tcp.c:2787:38: error: =E2=80=98TCP_REPAIR_ON=E2=80=99 undeclared (first u= se in this function); did you mean =E2=80=98TCP_REPAIR=E2=80=99? > if ((rc =3D repair_set(c, conn->sock, TCP_REPAIR_ON))) > ^~~~~~~~~~~~~ > TCP_REPAIR > tcp.c:2787:38: note: each undeclared identifier is reported only once for= each function it appears in > tcp.c: In function =E2=80=98tcp_flow_repair_off=E2=80=99: > tcp.c:2807:38: error: =E2=80=98TCP_REPAIR_OFF=E2=80=99 undeclared (first = use in this function); did you mean =E2=80=98TCP_REPAIR=E2=80=99? > if ((rc =3D repair_set(c, conn->sock, TCP_REPAIR_OFF))) > ^~~~~~~~~~~~~~ > TCP_REPAIR > make: *** [Makefile:94: passt] Error 1 >=20 > Link: https://bugs.passt.top/show_bug.cgi?id=3D121 > Reported-by: Dongsheng > Signed-off-by: Yumei Huang Applied, thanks, and welcome to the git log! --=20 Stefano