From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ToJDMHQ3; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 07C245A0279 for ; Fri, 05 Sep 2025 13:02:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757070128; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/c8DT2paSNxHtxzCSWNdbPxOJEBNgYJ+6Cf69oBS5Tk=; b=ToJDMHQ3lR75UrXC4DMAeFBoAbotL2K4MSp1Y0wA+DABODT7bQuu20/q1JDtThRt+VSCQ/ QFE4UM0s0W2Z8RgV1biJSSPcbT5y8caJ0OMXEYYbHcFE8lVew2laivMr4jAkhE7Ign25hd oK2UvTQKuICpTfUxcNMt/n887ij7kuw= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-620-HRQIkVmuNKKeLuWAlCJyjA-1; Fri, 05 Sep 2025 07:02:07 -0400 X-MC-Unique: HRQIkVmuNKKeLuWAlCJyjA-1 X-Mimecast-MFC-AGG-ID: HRQIkVmuNKKeLuWAlCJyjA_1757070126 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3df9f185b82so952898f8f.1 for ; Fri, 05 Sep 2025 04:02:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757070125; x=1757674925; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=/c8DT2paSNxHtxzCSWNdbPxOJEBNgYJ+6Cf69oBS5Tk=; b=nbW6bBxDYOu53h5dG3hpNphQtb3PDCFcYEplxEf7RxdBo1X5QQs8rVxzX3XJd9LAGg aUMF/d8idrYzzx4jZ0i+925T+kntvGrvU0VbcdinyYW2h0KCUKUI9okz/VpBAcCRhHoG 70rQ8nGcIrkc0cEei2tHckHHI5o8+vA3q1QZySG4eJFtuNKYHBal7DLd7M2E+tD+WBwH L5YciC37XT9Y4DX/4Gbmv/XeMT7zSdXiS8J7powCTuuoIqC4uR2zpefTVvRMop9mM524 gki9ruddshAhwUNup/nJSEDItX9KHvb4an2yq734jcbu5IuUnOq07OBd48YzvFsvJjHN YsSw== X-Gm-Message-State: AOJu0YwYyu29rMZiKljCRQvc6qSYtykpl0Dd/urkHrF/TYMHOzW0JYjf laAmistm/0LiDLTvxy6TXBykKZE6QN4a36fT70ieNqNjGsrF7xWxJ7FmfBa8UIl34LSrUmKLjhs vNhD2ucBI6ar4w6Nvp17KF21VUtbVLU0nWnLqJO25gAJYgdG6MWvxVPWJRM3qjw== X-Gm-Gg: ASbGncvyfJKaPGtpZE0BMeDVmU7e8FMUPgPGro8wtfNd6eA3FM8wOmLS64P+tGx1PNj 8cwbkg8kpFkMoyPF4rdIrovenKqwpoyZB0ZftRoNXTGS8C8TuIs/PupxMxqNk+yQBi76sd613sN y9bOSCBE+0JqLcCjIwlmzYcxui6VfYfqGGgiAvzY9fo9oYS4KJQEHiKnLDr+vM3Gzv/4JkPIyck TidNYEGDTdd2Qa+0pm6fskjBKnHZP+aqYETNbXPqqUmTWaUcyATZwwbQg8/R496KCrF2voQ7Q2w UTjqPOK1z4Hnt45+jWXESmzG9/6t/cS3QOB4Xyj4jcM1LhI0c/U= X-Received: by 2002:a05:6000:3111:b0:3db:c7aa:2c4a with SMTP id ffacd0b85a97d-3dbc7aa304amr9747681f8f.42.1757070125542; Fri, 05 Sep 2025 04:02:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEQYRiN75s/Gu/taryxqgJSv7jpgoshLg2NNYqwwa4jJDEdfZGTv4U0hG37S2cUkXRxATampA== X-Received: by 2002:a05:6000:3111:b0:3db:c7aa:2c4a with SMTP id ffacd0b85a97d-3dbc7aa304amr9747633f8f.42.1757070124916; Fri, 05 Sep 2025 04:02:04 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45b6f30fe02sm397075675e9.18.2025.09.05.04.02.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Sep 2025 04:02:04 -0700 (PDT) Date: Fri, 5 Sep 2025 13:01:54 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v7 0/4] Introduce first exeter based test infrastructure Message-ID: <20250905130154.76bd6329@elisabeth> In-Reply-To: References: <20250904025004.491185-1-david@gibson.dropbear.id.au> <20250905011433.41c0d242@elisabeth> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 1KFUITOfL5gehW7EnLrjrH6WhSlaqTa2FK1XsUh9_2k_1757070126 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: EAYBNJFN423BIVMVZALEWEV4R4EZFS5A X-Message-ID-Hash: EAYBNJFN423BIVMVZALEWEV4R4EZFS5A X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 5 Sep 2025 16:42:58 +1000 David Gibson wrote: > On Fri, Sep 05, 2025 at 11:35:53AM +1000, David Gibson wrote: > > On Fri, Sep 05, 2025 at 01:14:33AM +0200, Stefano Brivio wrote: > > > On Thu, 4 Sep 2025 12:50:00 +1000 > > > David Gibson wrote: > > > > > > > Here's a new approach to building passt tests with exeter. This new > > > > one no longer uses Avocado in the default case, although it would > > > > still be possible to manually run the exeter based tests with Avocado. > > > > > > > > For now this only does simple tests, to show how the integration could > > > > work. It adds some new trivial "smoke tests" and converts the linter > > > > and build checks to exeter. More complex tests will require building > > > > the tunbridge library we've discussed. A lot of the work for that > > > > already exists in my earlier exeter test series, but it will need some > > > > rework to split it into a separate component. > > > > > > > > v7: > > > > * Use "exetool list" rather than "--list" directly to get test manifest. > > > > * Update Makefiles to automatically update exeter sources as necessary. > > > > * Update series cover letter removing some outdated information. > > > > > > I was about to apply this, but then realised that the usual build test > > > links at https://passt.top/#ci disappeared, see also > > > https://passt.top/builds/latest/web/ci.js. > > > > Huh, that's weird. > > > > > I didn't really investigate > > > yet, we're missing something equivalent to the "test" directive. > > > > We shouldn't be. exeter() calls status_test_{start,ok,fail} much like > > test(). > > Ah.. but I didn't call video_link, like test_one() did. Which > explains why the new tests weren't getting links... but not why it > broke the existing ones. No, no, existing ones are fine. Just the *build* test links were missing. It all works now (with v8). > Well, I've put that in, and ci.js looks sane to me, but I don't really > know how that video stuff works. I'll send v8. It's write-only code but it's conceptually simple: we record the start timestamp (based on /proc/uptime) of each test file and add that, together with a key, to a JavaScript array, video_cilinks. One 'a' HTML element (link) is also generated for each test file, with an 'id' attribute matching that key, and when you click on that link, a listener will look into video_cilink and use the matching start timestamp as seek time for AsciinemaPlayer. > > > If I > > > recall correctly, that was working in v5, but I'm not sure why. I still > > > need to look into this, unless you figure it out meanwhile. > > > > Right, you said v5 worked. Hrm.... one of the main differences since > > v5 is getting the descriptions, which *are* used as the parameter to > > status_test_start. Could the descriptions be using some character we > > weren't before and we're missing an escape somewhere? Not seeing an > > obvious spot. I guess I didn't actually recall correctly, or didn't check those links, because it couldn't have worked in v5 either. -- Stefano