From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top
Subject: Re: [PATCH v8 5/5] test: Explicit specify forwarding ports for pasta in log rotation tests
Date: Fri, 5 Sep 2025 13:03:40 +0200 [thread overview]
Message-ID: <20250905130340.40207517@elisabeth> (raw)
In-Reply-To: <20250905064317.213246-6-david@gibson.dropbear.id.au>
On Fri, 5 Sep 2025 16:43:17 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:
> test/pasta_options/log_to_file uses tcp_crr in a loop to generate log
> messages for what it's actually testing. For this to work, pasta needs to
> forward two ports. We set a PORTS variable with the options for this, but
> never actually use it. The test works, because without the options we use
> automatic port forwarding.
Oops.
> That makes the test more fragile than it needs to be, in a way that's not
> at all related to what we're actually trying to test. Avoid this possible
> point of failure by explicitly specifying the forwarding.
>
> I encountered this because Fedora has now updated to a kernel with the
> /proc/net lseek() bug.
By the way, the fix is now in mainline as 2ce3d282bd50 ("proc: fix
missing pde_set_flags() for net proc files"). I hoped the breakage would
never reach distributions but I guess the timing was unlucky enough.
--
Stefano
next prev parent reply other threads:[~2025-09-05 11:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-05 6:43 [PATCH v8 0/5] Introduce first exeter based test infrastructure David Gibson
2025-09-05 6:43 ` [PATCH v8 1/5] test: Extend test scripts to allow running exeter tests David Gibson
2025-09-05 6:43 ` [PATCH v8 2/5] test: Run static checkers as " David Gibson
2025-09-05 6:43 ` [PATCH v8 3/5] test: Convert build tests to exeter David Gibson
2025-09-05 6:43 ` [PATCH v8 4/5] test: Allow exeter & podman tests to be parallel executed with BATS David Gibson
2025-09-05 6:43 ` [PATCH v8 5/5] test: Explicit specify forwarding ports for pasta in log rotation tests David Gibson
2025-09-05 11:03 ` Stefano Brivio [this message]
2025-09-08 1:53 ` David Gibson
2025-09-08 4:04 ` David Gibson
2025-09-05 11:03 ` [PATCH v8 0/5] Introduce first exeter based test infrastructure Stefano Brivio
2025-09-08 1:55 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250905130340.40207517@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).