From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=R7jgUnD+; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id DF75D5A0279 for ; Fri, 05 Sep 2025 13:03:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757070225; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d00TLVZfMo1HtMDhkHqtZDKX/ngiS5NMNkmaZQLXWS0=; b=R7jgUnD+ao5Mbb2NVVgT/1GDbtn8rID/ErrVSOxSv3xfdjNNiDEHkBzKa0dh2RZVN2BEor O8M2bOzpAhmetMqOc0dhgj+jql8wpzfSWe7ZzqhhGa0pSiagd08EhPJPVdPyozyfqZhf+v c7Fwoc61S3mFQWyIavD4AhTv+xKbWK8= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-584-qRg3hqJhMrqWOZ_RNoHf-A-1; Fri, 05 Sep 2025 07:03:44 -0400 X-MC-Unique: qRg3hqJhMrqWOZ_RNoHf-A-1 X-Mimecast-MFC-AGG-ID: qRg3hqJhMrqWOZ_RNoHf-A_1757070223 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3e3b77972cbso393186f8f.1 for ; Fri, 05 Sep 2025 04:03:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757070222; x=1757675022; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=d00TLVZfMo1HtMDhkHqtZDKX/ngiS5NMNkmaZQLXWS0=; b=EGkcUFAC+QfjCCNr5+6SNeqhVR5ZcFYN7R3cY0UTbfOYeaO6kmp1JKj/mHBz/KtU1a 4Nb9Q5kl3eDvQJpfrIJA6IAKKUyHPD5RTpnegcSfkLqwuMpdn5vdZZs6bi48lwEJ1omM kibQRxgXJWR1Du51ECXVBdyx4wv2o4Yco2XTFBK4cyIa43xcFpWWoiAnMY21trRdlcOK e8hOTGcGzFFCkDSRyVn+rf5krx2rkVqFzHCfmhdr16UF/uDNhWmcIEc7XbpmXKyKKUDr qJ5Q86mS1+oAIZ5Ef1vuZpE6nEGvvgyQAAZ3GaZGkFFRUxaKax/dbBYtODyYXdR9ytqG pj2Q== X-Gm-Message-State: AOJu0Yy0uFN8AtbCB4u9IZFv0Tfc55h66+M/7y53RoAf7DIcUnvOmUMi P3z4TC8mgEg2fTO3vOLXpbOkHgFStUKBsbGWXnXUnaovZU4ybo4LsmXv+J/dBS22gAJ3WCAgARy BlO30NEnNTFo3ytQVGPKNfsFcV6Kkm/UpGqIy+2gc5pqnAa5y6uUD/pGiPvjfZQ== X-Gm-Gg: ASbGncvFwwUyORAaDZyodzXSY5SkGTsMsXiVzxdqKfVQOWgor6VS2etmPTcxf/JWn4I LUCravDAb777zHzUWr4XIMSWUbG0tykIrDI7VX9jyK3svE01fkPyR6TrNcVgFaXe21wrCcsMqXw /ojheP75kWUSSh26kGGOCPBAzZnS/3u5sHq5KagPkQghMIp9hxPGnEGZXs9N2lJ5siTSTwQSMsi b/a5Jn2XtUbkXoqmIEb/FFOWkdrVdPj7ZdgVElihQglXuCgqLXgrmLMkP7PS021BwZ1rKqVGhjX viZk15LFGD2TSTW99Vv6vD5b5F+FqyzvPOXHQrQvjzp2zzrrPs4= X-Received: by 2002:a05:6000:2f84:b0:3e4:74dc:a3bb with SMTP id ffacd0b85a97d-3e474dcd583mr984360f8f.40.1757070222173; Fri, 05 Sep 2025 04:03:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGCjgqdiLDzAe44EfVCBW7ej9rupUoElQg0rcmJ3skFTG+URmFFc7mVSa1iFLmREEmI8c2cGg== X-Received: by 2002:a05:6000:2f84:b0:3e4:74dc:a3bb with SMTP id ffacd0b85a97d-3e474dcd583mr984326f8f.40.1757070221688; Fri, 05 Sep 2025 04:03:41 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3dbead0b247sm11926190f8f.6.2025.09.05.04.03.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Sep 2025 04:03:41 -0700 (PDT) Date: Fri, 5 Sep 2025 13:03:40 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v8 5/5] test: Explicit specify forwarding ports for pasta in log rotation tests Message-ID: <20250905130340.40207517@elisabeth> In-Reply-To: <20250905064317.213246-6-david@gibson.dropbear.id.au> References: <20250905064317.213246-1-david@gibson.dropbear.id.au> <20250905064317.213246-6-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 6bfdMoPeM_IpMPIQYQw7_8_eeuzYBfhoDUFOvvCbPMs_1757070223 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: WDA4Q7UUYKGCINXKDJJYMJ23K6KXKEVC X-Message-ID-Hash: WDA4Q7UUYKGCINXKDJJYMJ23K6KXKEVC X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 5 Sep 2025 16:43:17 +1000 David Gibson wrote: > test/pasta_options/log_to_file uses tcp_crr in a loop to generate log > messages for what it's actually testing. For this to work, pasta needs to > forward two ports. We set a PORTS variable with the options for this, but > never actually use it. The test works, because without the options we use > automatic port forwarding. Oops. > That makes the test more fragile than it needs to be, in a way that's not > at all related to what we're actually trying to test. Avoid this possible > point of failure by explicitly specifying the forwarding. > > I encountered this because Fedora has now updated to a kernel with the > /proc/net lseek() bug. By the way, the fix is now in mainline as 2ce3d282bd50 ("proc: fix missing pde_set_flags() for net proc files"). I hoped the breakage would never reach distributions but I guess the timing was unlucky enough. -- Stefano