From: Stefano Brivio <sbrivio@redhat.com>
To: Volker Diels-Grabsch <v@njh.eu>
Cc: passt-dev@passt.top
Subject: Re: [PATCH] Add missing explicit PSH assignment
Date: Sat, 6 Sep 2025 22:20:32 +0200 [thread overview]
Message-ID: <20250906222032.52aa369c@elisabeth> (raw)
In-Reply-To: <20250905235618.292574-1-v@njh.eu>
On Sat, 6 Sep 2025 01:56:18 +0200
Volker Diels-Grabsch <v@njh.eu> wrote:
> For packets with data, we set the PSH flag depending on whether it's
> the last chunk of data in a single receive operation from a socket.
> But then we reuse the same buffers for SYN segments, and oops, PSH is
> set randomly.
>
> This change cleans this up by setting PSH explicitly, just as we do
> with the other flags.
Thanks, applied, and welcome to the git log!
For the future: it would be nice if you could use the Signed-off-by:
tag to imply all this stuff: https://developercertificate.org/. Here I
added it for you as an exception as I know that it's clearly the case,
and the change is trivial.
By the way, 'git commit --signoff' adds it.
--
Stefano
next prev parent reply other threads:[~2025-09-06 20:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-05 23:56 [PATCH] Add missing explicit PSH assignment Volker Diels-Grabsch
2025-09-06 20:20 ` Stefano Brivio [this message]
2025-09-07 10:40 ` Volker Diels-Grabsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250906222032.52aa369c@elisabeth \
--to=sbrivio@redhat.com \
--cc=passt-dev@passt.top \
--cc=v@njh.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).