From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=BieWfRQQ; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id C709F5A0278 for ; Sat, 06 Sep 2025 22:20:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757190038; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3dghVz8C0M02RkyIi2Rix26pIW2EGphqq6ZoALLbvxk=; b=BieWfRQQjIPiTAaem6BetE972mj6rwwR23NaVLESMLmzyaA6y0vbaZA4/J2cLgyIYjV4yd yQYxg2Cb0BczIC8tYWs3CiWyli2bSVAwIiZruSy1tbdBTR2IqBfdsjCB52onWQosZh8oY2 0hLWseGE1iiCUhVBwn36599PL2GPd24= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-384-6ou_HRPFMfis1fK3HUiYiw-1; Sat, 06 Sep 2025 16:20:36 -0400 X-MC-Unique: 6ou_HRPFMfis1fK3HUiYiw-1 X-Mimecast-MFC-AGG-ID: 6ou_HRPFMfis1fK3HUiYiw_1757190036 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-45ddbdb92c5so7027215e9.3 for ; Sat, 06 Sep 2025 13:20:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757190035; x=1757794835; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=3dghVz8C0M02RkyIi2Rix26pIW2EGphqq6ZoALLbvxk=; b=fGMq7rGFZY9g8p0JTt08sCSADoNxN7wPJAvalNvJ73P8qwX64eYEkgu2TjZ8La8Tgm DgsdY/8YToNlgqXoiOOauS62liXBYNd9qtXrvHEQtkI5WocNjlTyxWrt57z01R749pt2 8jDjno1ODwleWGK5cESnfoifH41pNSi8sqRrPFMkrcL8qy0h1/KO4BufmWfr94yjetQp ocnhV0Q4uOu2n2fOTASLuqFANLUYmci4ob/R7XEWw9XzVU39iUPGfNRdhTXU4cnS2XoE PzA/S9Dp/NzCybfJ2W/ASLiYvXpRE72jZa8NkRZtV7ExIcgfC76VAtQMji+UAOuZjl6z gKMw== X-Gm-Message-State: AOJu0YzarroAPSJ4nkt+EMbQKpkjh7dch5+J1AftAXPIPjuoo70SX7kL NX0LEZbRpdzPdEK1ctPFAV5FJDUZi6c6tKqayKWb1l3ByHyu9J2f8lcoRDBJpyjygULcJ0Vd48m N/5uplMSMSKWR7+nqJuQ/3VnkdhUaKlobeyh7v3ZG2IvSqbRJ+qMjzQ== X-Gm-Gg: ASbGncuwit46ks9ngTFIpCRXgaqf7w2fyX3VTCos8yiXlUrKqvcApcpLr4Leqr6mD1i BJV8LQwp4lk5+nHR6STYEsv99YTPI+PK+FH7zRHLNia5MXipIi+w9i2VkbA1+H9bDRwzxsBq98R XQUbK3n0dN4w8KgAuP+3Igr2Cb8cx++9X0lzRwivhMA+H1bd/vYXFEoX8kGWUCqIGeKvmn3rO0Q KRRNTEZdjWjCxgm0M0ZiEQK7QMopteCBjUWwFSYxDpAZXz7wIrpziIA7GISZkITs2lv5F1u8BHl UIUTskZ/ysEbIX87vSNUApnW+jDK53KImdi8H3dmFj+q6qx6fE8= X-Received: by 2002:a05:600c:4fc1:b0:45b:868e:7f80 with SMTP id 5b1f17b1804b1-45ddde81532mr29721605e9.8.1757190035569; Sat, 06 Sep 2025 13:20:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFceZ2MaJ4AIp7G8PXMu1KUzClCzOHugbnk2W7E+2vo43nJx/tpQvloy5zmcdmoqwJc3Q473g== X-Received: by 2002:a05:600c:4fc1:b0:45b:868e:7f80 with SMTP id 5b1f17b1804b1-45ddde81532mr29721445e9.8.1757190035010; Sat, 06 Sep 2025 13:20:35 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45de2132cd3sm14462695e9.9.2025.09.06.13.20.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Sep 2025 13:20:34 -0700 (PDT) Date: Sat, 6 Sep 2025 22:20:32 +0200 From: Stefano Brivio To: Volker Diels-Grabsch Subject: Re: [PATCH] Add missing explicit PSH assignment Message-ID: <20250906222032.52aa369c@elisabeth> In-Reply-To: <20250905235618.292574-1-v@njh.eu> References: <20250905235618.292574-1-v@njh.eu> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 3boOEtiRtnYW_6jWYCkf4vQqtsG5jtHYMB4uampxjMg_1757190036 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: PWITSIFPV7E75ERJ2LVLVOE72R3NC36Q X-Message-ID-Hash: PWITSIFPV7E75ERJ2LVLVOE72R3NC36Q X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Sat, 6 Sep 2025 01:56:18 +0200 Volker Diels-Grabsch wrote: > For packets with data, we set the PSH flag depending on whether it's > the last chunk of data in a single receive operation from a socket. > But then we reuse the same buffers for SYN segments, and oops, PSH is > set randomly. > > This change cleans this up by setting PSH explicitly, just as we do > with the other flags. Thanks, applied, and welcome to the git log! For the future: it would be nice if you could use the Signed-off-by: tag to imply all this stuff: https://developercertificate.org/. Here I added it for you as an exception as I know that it's clearly the case, and the change is trivial. By the way, 'git commit --signoff' adds it. -- Stefano