From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=C72JsYYG; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 431725A0278 for ; Mon, 08 Sep 2025 09:33:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757316798; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gp6pOr9K0H4d4O3FxNY1MnsTsZSj5MGjuTfVh+LYdOA=; b=C72JsYYG04pb6OBZBrqqyPtKbKXJOzmAbEI97snNHLdnKWph9P5VzMa5gFHfj0HrNN24rr 5MccommPCbucAp9c0FdbHnfM+qHR2Bo51RfaYarmzIoLP3zm1N7LMrN0xT2KVe0WxOJ+1C DidkLgG5zSq4ToR+GF39NIbYOL8A1jQ= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-516-y-Prg4AAP5OmIcIYNNBhgw-1; Mon, 08 Sep 2025 03:33:16 -0400 X-MC-Unique: y-Prg4AAP5OmIcIYNNBhgw-1 X-Mimecast-MFC-AGG-ID: y-Prg4AAP5OmIcIYNNBhgw_1757316795 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7388D195608B for ; Mon, 8 Sep 2025 07:33:15 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.72.112.84]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D8803180044F; Mon, 8 Sep 2025 07:33:12 +0000 (UTC) From: Yumei Huang To: passt-dev@passt.top Subject: [PATCH] test: Fix QEMU_EFI.fd not found error on non-ARM platforms Date: Mon, 8 Sep 2025 15:33:09 +0800 Message-ID: <20250908073309.16238-1-yuhuang@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ZMxn7o80xXhtU6ZJlO3LgXhlXOR4RmgpTJX-bTxy0cQ_1757316795 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true Message-ID-Hash: 67AVUXKJHU3HB4EYFRVJI56FJYVQJLAD X-Message-ID-Hash: 67AVUXKJHU3HB4EYFRVJI56FJYVQJLAD X-MailFrom: yuhuang@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: sbrivio@redhat.com, dgibson@redhat.com, yuhuang@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Fix the following error when running `make assets` under test on non-ARM platforms: ./find-arm64-firmware.sh QEMU_EFI.fd Couldn't find QEMU_EFI.fd make: *** [Makefile:68: QEMU_EFI.fd] Error 1 Signed-off-by: Yumei Huang --- test/Makefile | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/test/Makefile b/test/Makefile index a774285..32d6b43 100644 --- a/test/Makefile +++ b/test/Makefile @@ -109,7 +109,11 @@ nstool: nstool.c $(CC) $(CFLAGS) -o $@ $^ QEMU_EFI.fd: - ./find-arm64-firmware.sh $@ + if [ "$(shell uname -m)" = "aarch64" ]; then \ + ./find-arm64-firmware.sh $@; \ + else \ + echo "QEMU_EFI.fd not needed on $(shell uname -m)" && touch $@; \ + fi prepared-%.qcow2: %.qcow2 ./prepare-distro-img.sh qemu-img create -f qcow2 -F qcow2 -b $< $@ -- 2.47.0