public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: Yumei Huang <yuhuang@redhat.com>,
	passt-dev@passt.top, dgibson@redhat.com
Subject: Re: [PATCH] test: Fix QEMU_EFI.fd not found error on non-ARM platforms
Date: Mon, 8 Sep 2025 11:28:01 +0200	[thread overview]
Message-ID: <20250908112801.0d9f6a0b@elisabeth> (raw)
In-Reply-To: <aL6SZpn-7SPljV4o@zatzit>

On Mon, 8 Sep 2025 18:23:02 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:

> On Mon, Sep 08, 2025 at 10:10:17AM +0200, Stefano Brivio wrote:
> > On Mon,  8 Sep 2025 15:33:09 +0800
> > Yumei Huang <yuhuang@redhat.com> wrote:
> >   
> > > Fix the following error when running `make assets` under test on
> > > non-ARM platforms:
> > > 
> > > ./find-arm64-firmware.sh QEMU_EFI.fd
> > > Couldn't find QEMU_EFI.fd
> > > make: *** [Makefile:68: QEMU_EFI.fd] Error 1  
> > 
> > Hmm, wait, this is needed to run ARM guests, but not necessarily on
> > ARM.  
> 
> Right.
> 
> > The test/distro tests (currently skipped) can use QEMU TCG to run ARM
> > guests on (kind of) any host architecture, and actually the only usage
> > I've ever made of find-arm64-firmware.sh is on x86_64.
> > 
> > It still works for me there. On Fedora and related, you need to install
> > the edk2-aarch64 package, and it's qemu-efi-aarch64 on Debian and
> > Debian-based distributions.  
> 
> The firmware package should be installed as a dependency of
> qemu-system-aarch64, which is also necessary to run those ARM TCG
> tests.

It's also mentioned in test/README.md (at least the Debian name for
it).

We should fix that document altogether, because it doesn't mention
'make' under test/ at all. It's on my list, but I didn't start yet, so
it's up for grabs (yes, I should file some more tickets, but I didn't
find a moment for that yet).

-- 
Stefano


      parent reply	other threads:[~2025-09-08  9:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-08  7:33 Yumei Huang
2025-09-08  8:10 ` Stefano Brivio
2025-09-08  8:23   ` David Gibson
2025-09-08  9:07     ` Yumei Huang
2025-09-08  9:28     ` Stefano Brivio [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250908112801.0d9f6a0b@elisabeth \
    --to=sbrivio@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=dgibson@redhat.com \
    --cc=passt-dev@passt.top \
    --cc=yuhuang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).