From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=gbm306Qo; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 765585A0271 for ; Tue, 09 Sep 2025 17:55:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757433337; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZjfJG0vCc2woQvnV7XXJ7uKkRrr8Mk6pvOa3NCEm9VI=; b=gbm306Qo+01ulxiE06gzKwuH9RGMqo+XdYN8hX65jsYpBTfMdYnDtuUWat3+ia/GXwvF38 elPUl5CJORSSd3VDr1kZmANHr3SWUY3FlA2eAspyvJdiGiO0Q6haVH6vruIxLie4UbgEbS RhvUn1BwylwlNw/iVVXhlp45ATO4daM= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-373-6b-hQVQlMsSxl2MHxHJpgA-1; Tue, 09 Sep 2025 11:55:35 -0400 X-MC-Unique: 6b-hQVQlMsSxl2MHxHJpgA-1 X-Mimecast-MFC-AGG-ID: 6b-hQVQlMsSxl2MHxHJpgA_1757433334 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-45cb604427fso31855665e9.1 for ; Tue, 09 Sep 2025 08:55:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757433333; x=1758038133; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ZjfJG0vCc2woQvnV7XXJ7uKkRrr8Mk6pvOa3NCEm9VI=; b=VIoPhRpJ90a9H3SCTHRRPthHeiNuyaFtQrovTVv+YRUFxhXLQhoDhQJgh2COLSU0uO iMsqbJ5ABK68/qrcMT48OFUynWuXLvQe4W6Rnleg0z4RfURoJzfDZ/u7y4EG7KcasgJT UbKlg0E4F3YjPY45QijSRL/B60wilqqeDWFfdnBCX38rAHoNVnkurUdUhkjdsWhxB4t+ ECi5Cs7H9RmISa9XfeiOwhslKwwqfz00jvrG1vpdZJFrBx8tlSsr7+wqHx1q8Lx4RkvH 3dFr/Wd9ZHIOx4JWR5C1rQ/hct6SlxBV8u8FrTfwrsZUeUd4JiubTW3gxDDjQrgbntEj Krnw== X-Forwarded-Encrypted: i=1; AJvYcCX0+/jUFBUrLTRIEO28+qSJzDlkrChpvwgZ1PXN+wfvf92hiW+ELeGLH7J7UW4Rgb31LLGQI7aH9Bw=@passt.top X-Gm-Message-State: AOJu0Yxl5/SnPkuFZuDe/nrkVVRDe6R5d1Nwpbwm2QBdV1chVDm7dHTV AkyJsrPiv5mVJfmyFJUwyL6I2s11qGGKv/JboC5gqhDwChLIkBSQ5LNZ9r/ZI4WOT6uVN5/yj9N 98SibS2pTG+VXA4fhZLC1ik4ziVN9Yt9S2jSF8fyKYJgLJqLmbzIy4cXpI63Fog== X-Gm-Gg: ASbGncvM/pJlB8BoypJ+rLlsU5iq8QxQ4kYLlbdlkmDesb+iltkAKIEzkxCBDC4EN8v MubRtxdt5o4OKeSzENqm4crMHGntvJ+LEGNK+jwpufmXFjyt7B/wIsCMuBze65IDoCZg3+w7Mmc nHOmk5pSxqaq/t/E3TgEJP5FpOwWMQj5KZM0eifIkSDjF0kF0tjJiD4PHoamBgS2MPmYIgd0ry6 RDWbwsQwfhlAy1ylJo/X818n+EQNrNeXGQ1FTSPtvy3nv/yy1uSNrx6WREt8bTyc/HtT1Alaa6V DR67UMQPV2WGaNFV5BiOUaG6ffa8M5/LGHsIafnHbi6sduC87uI= X-Received: by 2002:a05:600c:1c15:b0:45b:9c93:d22b with SMTP id 5b1f17b1804b1-45ddde864b4mr97158905e9.2.1757433333138; Tue, 09 Sep 2025 08:55:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFapubZPt92nHXR+mgPvO1C8lwHzSA/7yIqzGdVqT7yhP7KVF7Gu+oYnHnQmdniaLovchX0tw== X-Received: by 2002:a05:600c:1c15:b0:45b:9c93:d22b with SMTP id 5b1f17b1804b1-45ddde864b4mr97158705e9.2.1757433332694; Tue, 09 Sep 2025 08:55:32 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45df16b2971sm11691595e9.7.2025.09.09.08.55.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Sep 2025 08:55:31 -0700 (PDT) Date: Tue, 9 Sep 2025 17:55:30 +0200 From: Stefano Brivio To: Volker Diels-Grabsch Subject: Re: [PATCH v2] Send an initial ARP request to resolve the guest IP address Message-ID: <20250909175530.7fc950bc@elisabeth> In-Reply-To: References: <20250908092038.405194-1-v@njh.eu> <20250908092429.406248-2-v@njh.eu> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 6tyGupXgjGBfh6vcmccs88cy0kmijHhXleUa3hdfWOM_1757433334 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: IZMUALNGOVCYSTRJZOQZ6GDW6F7L6KB4 X-Message-ID-Hash: IZMUALNGOVCYSTRJZOQZ6GDW6F7L6KB4 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 9 Sep 2025 12:10:45 +0200 Volker Diels-Grabsch wrote: > David Gibson wrote: > > Looks good to me. It would be nice to also send an Neighbour > > Discovery request to accomplish the same thing for IPv6 only guests, > > but that could be a separate patch. > > Good point! I'd prefer to do it in the same patch, as I'd also like > fix another minor detail in this one. > > Just for the sake of clarity: I had a look at RFC4861 and there are > many types of Neighbour Discovery requests. For our purpose, I believe > that we want to send a "Neighbor Solicitation Message" described in > section 4.3: > > https://datatracker.ietf.org/doc/html/rfc4861#section-4.3 > > Do you agree, or did you have something else in mind? I was about to comment on this, but from the new patch you sent, I see you already figured out it's a Neighbour Solicitation and that we already have some bits of code for that. :) > > Note that even with this patch, active TCP connections (and in some > > cases UDP flows) will be broken by a passt restart. > > Indeed, that is unavoidable for a user-space tool opening TCP and UDP > connections, I guess, unless "passt" itself is wrapped into another > process or system tool that keeps those connections open. But let's > not go into that. Actually, it's not really unavoidable, in the sense that we recently added (see migrate.c, repair.c, passt-repair.c, and passt-repair(1)) support for migration of live TCP connections triggered by vhost-user commands: https://qemu-project.gitlab.io/qemu/interop/vhost-user.html#migrating-back-end-state which is based on the TCP_REPAIR socket option in the Linux kernel, which was in turn added to support a similar feature in CRIU: https://criu.org/TCP_connection and while this was done with KubeVirt in mind: https://github.com/kubevirt/enhancements/blob/main/veps/sig-network/passt/passt-migration-proposal.md that is, migration between two different nodes / hosts, there's nothing that really prevents migration between two instances of passt via, for example, load/dump from/to a binary file. Actually, we initially wanted to add the file option for testing purposes, but we skipped it eventually and went straight ahead for the direct implementation. Some bits of "documentation": git log migrate.c test/migrate/basic ...yes, a new website with some space for this stuff is in (infinitesimally slow) progress. -- Stefano