From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=E4dQPtNR; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 029945A0271 for ; Tue, 09 Sep 2025 22:24:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757449472; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1O12pjIV2PkiviU4T/G9aQ6MN/hD/j7zm0ENhUwIMvc=; b=E4dQPtNR+87O3c9Lbfej6t839CjQEXLY6Nhq8KUgH6SMkSsmHrq3XLuYv/7C9z0dP32lDx GLKYxKno4ECB2SRxJG39Y0o6qnijXzohKJGupYUN/ak87LkKzCeIhWZyQMpYbTISfgpD9A ftzrUXmtovV0HXRg4S20fCAICuQuIg8= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-488-V0OWlkPeOo2nvB1jnmGnxA-1; Tue, 09 Sep 2025 16:24:30 -0400 X-MC-Unique: V0OWlkPeOo2nvB1jnmGnxA-1 X-Mimecast-MFC-AGG-ID: V0OWlkPeOo2nvB1jnmGnxA_1757449469 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-45dcf5f1239so23678555e9.2 for ; Tue, 09 Sep 2025 13:24:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757449468; x=1758054268; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=1O12pjIV2PkiviU4T/G9aQ6MN/hD/j7zm0ENhUwIMvc=; b=MmqHKsfJtjyxvobqiRALHaoXN+xrtQ9RR3wzVYLZ09LfZni4paBlgKojYj4tgiqx+u bdKdLZ3+nturqS1zXl70j+EdOA6wVe2dfMcupg4jbMn/glPDBNI/948LPSlWDdXx6FBC LiiYO8to6FHKVDMuEPoys4HQW+LjkeNEWJ/10bVofL8d711CyCmaeF06fgEJ+ICpZks6 S7QYpDSeyybrdh/uZKocxptODGu0gIj/5i6+112aZPOh+CvMzWN7BZfklfdWLG5bhCrw lq1SESHR5y7gjAcCwCKe9F87FnSIfl91Wk5WuWxiiRkSf6pQy4X9rBBsdpxIQ2vABTml UOyA== X-Gm-Message-State: AOJu0YxhaQ/EvuQlgLDeaABL3LH3vFzrvvH8guGcJ6qUAMmT/hloHn0O N0ZGgpQ9sdnYoAxx4QHCO2em6ZzsQ8T5JUr6z2VlzjhjpNwIxiwyRpvF8kj2YoqVOcKzd1btQj3 MucRUwNTyuG6FoCrWhyk9cq3nGWomJy6EG8GMke4wvR1gW0CYXarAyvPWmauDyI8+G96V03NV4F pFmW13HmzipLHuvvjijuX8X8paanMsFpffYv/l X-Gm-Gg: ASbGnct95n+Wfi1hIt4zB3sdWUocFoIsujllZPaEI9OwCjQFCgOY17vsC+UXG2FM0+J xpRd1azqXIPH2iPbp96M+Yx3RHdcgh5qGZhLfmTXc1puSdNyFiAtRClEF77K9+hLzDSVwyKz7BV nH5DF9CGOzBL4xN1dishCCzWXWW6vNtmMyfOM2dX0kxtw7rfG7AoFDz/GCMl+ly7RY1oSSdUW0/ aDv4enQnHvhGig37FHtdjRWytQ5DSLscFyuh5DgG1Mr2yqvdtDJ0anWwNJyhFoe65rVUovqm358 GsR/HjHTIl3rJhI8GskoLeRoDpvK/cimTVhSpj52tPcYhKHBMmI= X-Received: by 2002:a05:600c:4750:b0:458:a7fa:211d with SMTP id 5b1f17b1804b1-45ddded6df8mr102227905e9.29.1757449468268; Tue, 09 Sep 2025 13:24:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH45Nea3uVDPzc9jSCeHIqp8r5XmrNXeEX4GJhyKyKDmj6F2RtrkdlnOFu7P9eE94M3I/F6eA== X-Received: by 2002:a05:600c:4750:b0:458:a7fa:211d with SMTP id 5b1f17b1804b1-45ddded6df8mr102227735e9.29.1757449467682; Tue, 09 Sep 2025 13:24:27 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3e7521ca20dsm4274157f8f.21.2025.09.09.13.24.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Sep 2025 13:24:27 -0700 (PDT) Date: Tue, 9 Sep 2025 22:24:25 +0200 From: Stefano Brivio To: Laurent Vivier Subject: Re: [PATCH 0/3] This series contains fixes and improvements to the vhost-user implementation Message-ID: <20250909222425.46d4f792@elisabeth> In-Reply-To: <20250905154935.389634-1-lvivier@redhat.com> References: <20250905154935.389634-1-lvivier@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: gopRO3i3ixEWksp47TN6WkxLoVht2jH-3BkEd6c9TKU_1757449469 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: KVPEPTOZTFDLFCR4RNLXMMEAOMHWDTKV X-Message-ID-Hash: KVPEPTOZTFDLFCR4RNLXMMEAOMHWDTKV X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 5 Sep 2025 17:49:32 +0200 Laurent Vivier wrote: > The first patch fixes a protocol compliance issue where VHOST_USER_GET_QUEUE_NUM > was incorrectly returning the number of virtqueues instead of queue pairs. The > vhost-user specification clearly states this should return the maximum number > of queues supported by the backend. Since each queue consists of an RX/TX pair, > the correct value is VHOST_USER_MAX_VQS / 2. This patch also renames the > constant to better reflect its meaning. > > The second and third patches address virtqueue handling in the UDP and TCP > receive paths. These changes pass the virtqueue pointer explicitly to the > receive functions, enabling proper queue selection for future multiqueue > support. This ensures packets are processed on the same virtqueue as the > caller. > > These changes lay the groundwork for full multiqueue support while fixing > existing protocol compliance issues. > > Laurent Vivier (3): > vhost-user: Fix VHOST_USER_GET_QUEUE_NUM to return number of queues > udp_vu: Pass virtqueue pointer to udp_vu_sock_recv() > tcp_vu: Pass virtqueue pointer to tcp_vu_sock_recv() Applied. -- Stefano