From: Volker Diels-Grabsch <v@njh.eu>
To: passt-dev@passt.top
Subject: [PATCH v4] Send an initial ARP and NDP request to resolve the guest IP
Date: Wed, 10 Sep 2025 13:35:40 +0200 [thread overview]
Message-ID: <20250910113632.80620-2-v@njh.eu> (raw)
Changes from PATCH v3: (... which wasn't marked as "v3", sorry for that)
1. Simply remove the "e.g." part from the comment, as it's misleading anyways
2. Make "bufmac[]" as local as possible
3. Demote the "Sending initial ..." log message from info() to debug()
4. Log "Sending initial ..." separately for ARP and NDP (because of 5. and 6.)
5. Send initial ARP request only if IPv4 is enabled
6. Send initial NDP request only if IPv6, NDP and ICMP are enabled
7. Update description of "--no-ndp" in man page
8. Fix and update description of "--no-icmp" in man page
9. Break long line for MAC_BROADCAST
One final thought regarding 8.:
Would it make sense to state in the man page that "--no-icmp" implies
"--no-ndp", and to implement it rigorously that way? Or, would that
be going to far?
next reply other threads:[~2025-09-10 11:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-10 11:35 Volker Diels-Grabsch [this message]
2025-09-10 11:35 ` [PATCH v4] Send an initial ARP and NDP request to resolve the guest IP address Volker Diels-Grabsch
2025-09-10 14:32 ` Stefano Brivio
2025-09-10 14:10 ` [PATCH v4] Send an initial ARP and NDP request to resolve the guest IP Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250910113632.80620-2-v@njh.eu \
--to=v@njh.eu \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).