From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=njh.eu
Received: from mail.notjusthosting.com (mail.notjusthosting.com [IPv6:2a01:4f8:a0:516f:1::1])
	by passt.top (Postfix) with ESMTPS id 7B9E25A0279
	for <passt-dev@passt.top>; Wed, 10 Sep 2025 13:37:34 +0200 (CEST)
Received: from dynamic-2a02-3100-2db2-7a00-838e-54c1-0d16-87c5.310.pool.telefonica.de ([2a02:3100:2db2:7a00:838e:54c1:d16:87c5] helo=vlap)
	by mail.notjusthosting.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.89)
	(envelope-from <v@njh.eu>)
	id 1uwJ8n-0008Fo-W6
	for passt-dev@passt.top; Wed, 10 Sep 2025 13:37:34 +0200
From: Volker Diels-Grabsch <v@njh.eu>
To: passt-dev@passt.top
Subject: [PATCH v4] Send an initial ARP and NDP request to resolve the guest IP
Date: Wed, 10 Sep 2025 13:35:40 +0200
Message-ID: <20250910113632.80620-2-v@njh.eu>
X-Mailer: git-send-email 2.47.3
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Message-ID-Hash: M3EDIE4HF6W7ODW6XTKEI2ZUZH2NMLEW
X-Message-ID-Hash: M3EDIE4HF6W7ODW6XTKEI2ZUZH2NMLEW
X-MailFrom: v@njh.eu
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.8
Precedence: list
List-Id: Development discussion and patches for passt <passt-dev.passt.top>
Archived-At: <https://archives.passt.top/passt-dev/20250910113632.80620-2-v@njh.eu/>
Archived-At: <https://passt.top/hyperkitty/list/passt-dev@passt.top/message/M3EDIE4HF6W7ODW6XTKEI2ZUZH2NMLEW/>
List-Archive: <https://archives.passt.top/passt-dev/>
List-Archive: <https://passt.top/hyperkitty/list/passt-dev@passt.top/>
List-Help: <mailto:passt-dev-request@passt.top?subject=help>
List-Owner: <mailto:passt-dev-owner@passt.top>
List-Post: <mailto:passt-dev@passt.top>
List-Subscribe: <mailto:passt-dev-join@passt.top>
List-Unsubscribe: <mailto:passt-dev-leave@passt.top>

Changes from PATCH v3:   (... which wasn't marked as "v3", sorry for that)

1. Simply remove the "e.g." part from the comment, as it's misleading anyways
2. Make "bufmac[]" as local as possible
3. Demote the "Sending initial ..." log message from info() to debug()
4. Log "Sending initial ..." separately for ARP and NDP (because of 5. and 6.)
5. Send initial ARP request only if IPv4 is enabled
6. Send initial NDP request only if IPv6, NDP and ICMP are enabled
7. Update description of "--no-ndp" in man page
8. Fix and update description of "--no-icmp" in man page
9. Break long line for MAC_BROADCAST

One final thought regarding 8.:

Would it make sense to state in the man page that "--no-icmp" implies
"--no-ndp", and to implement it rigorously that way?  Or, would that
be going to far?