From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=eBOkkEOQ; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 73B3E5A0279 for ; Wed, 10 Sep 2025 16:10:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757513437; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6mz19H169h1/tUw7FCnq/ylsmJJThglaBnCHVxGSrIo=; b=eBOkkEOQ+SLWbWtChPerGWmDav+uRXSbBeQylSOa2XmVQ+kwo04bTOZ8warRVlxt0aLhSB tQxgMLx/8n0tBf2jhG2HCg0onb45KEpnKz0jgjESQ7FgIWnMWuwiSejcJHE4TMuT81nJqh qezGWfJ7I9W84+MhHmMNu1kyUYf8Q0A= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-159-ewCunkEvORKvUjQsJn1WIA-1; Wed, 10 Sep 2025 10:10:35 -0400 X-MC-Unique: ewCunkEvORKvUjQsJn1WIA-1 X-Mimecast-MFC-AGG-ID: ewCunkEvORKvUjQsJn1WIA_1757513435 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-45dcf5f1239so27237315e9.2 for ; Wed, 10 Sep 2025 07:10:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757513434; x=1758118234; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=6mz19H169h1/tUw7FCnq/ylsmJJThglaBnCHVxGSrIo=; b=BvdYVL1XQW+jAxdiCrxHw3NFyQX2+WkvaZj3Y1LP0jTaE7EbjYP6lIJCWyqhbMGCt3 5kz8kQoUDuLbMNQKsDo7JN2hSQEXB1nP9K/vG6rtAJfqyJNujRkMhjjXy3UJlAWYFBSm X2819Ktz6xjzmpPsMcZb4FZ03+/l2tLxNOFUMhKP8q8cXASjZZLUgWvmp0Ex2LEfnZ6h vDqYUHwf8v1nqxPMIUvltrL1h3ADrADuolb/m4ETZe0x8r+iCQP++ugyLkrD3rWRV1xm xRspFEAK93a+UjGNWLz5FxBryFZo/LZ1LWWOIkxl/CUcHj4qy+myJaP9Beo9GYCJUnqg otOw== X-Gm-Message-State: AOJu0Yx4YHkqqGwnesmt8a8d4o6e5MT4VCPGnPwR1mSfwklr24Dei8t0 v/zwtwDN5MsuUEpoRmvkIpHeSq+F+NoWxuDkh6/+mrEq0Oo5j7gTiNPO4lw+56vS+FfgMhv4Lsz IktEidN0gUjcwJPuFIJHW8l90owWxflRL+NxUeqHW1dG5PekUTByOsdr+uqSziw== X-Gm-Gg: ASbGncvXACzb1a6KHIZZ6j1rna3IvckTSSMz0FCEB7s+Lgu/EBRjrRGUxVZVjnDr/gb nS9kW4WkkfwAomANYPnZ1YAxvwxQ94K3zLNkl4zqz0N+T62CrNs5VETKHZQAGlk588rEmEE6Itq flMBgHZHbxFTCB9n2IMLlOtsipAaIHYtwCuavLY2x/YgIDMwULNTTnn/IObyH7Z1RkyZN0Hhchz gWIPW3gr8QM3FQXg5nMOsNl9qM/bDBnOVC/9QhFlITR2fTrQHxxv3m0vIPqN0UbkvHcJdcE02sw MCmZRYLO3FbaH711DbgJThTR/6ke49fKZYx0wogXcVr+epqIEY8= X-Received: by 2002:a05:600c:154f:b0:45b:7e68:c6a3 with SMTP id 5b1f17b1804b1-45ddde94d8emr179213905e9.16.1757513433775; Wed, 10 Sep 2025 07:10:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG6x7+IoQWQbFE0oBYQAw3exvqqGm2j8ouVOFgARfNLNW65L2ST6YoYqOWQFfKiRvjW1V16og== X-Received: by 2002:a05:600c:154f:b0:45b:7e68:c6a3 with SMTP id 5b1f17b1804b1-45ddde94d8emr179213325e9.16.1757513433267; Wed, 10 Sep 2025 07:10:33 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3e75223885csm6959235f8f.36.2025.09.10.07.10.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Sep 2025 07:10:32 -0700 (PDT) Date: Wed, 10 Sep 2025 16:10:30 +0200 From: Stefano Brivio To: Volker Diels-Grabsch Subject: Re: [PATCH v4] Send an initial ARP and NDP request to resolve the guest IP Message-ID: <20250910161030.3058566f@elisabeth> In-Reply-To: <20250910113632.80620-2-v@njh.eu> References: <20250910113632.80620-2-v@njh.eu> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 3Klnpz1YN5n3DPiQzcCle8VEqlNS6Qa5F1Eetv2cqM0_1757513435 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 52KG4ZZKZCI4DFIID2PGED5FM7HYMWGZ X-Message-ID-Hash: 52KG4ZZKZCI4DFIID2PGED5FM7HYMWGZ X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 10 Sep 2025 13:35:40 +0200 Volker Diels-Grabsch wrote: > Changes from PATCH v3: (... which wasn't marked as "v3", sorry for that) > > 1. Simply remove the "e.g." part from the comment, as it's misleading anyways > 2. Make "bufmac[]" as local as possible > 3. Demote the "Sending initial ..." log message from info() to debug() > 4. Log "Sending initial ..." separately for ARP and NDP (because of 5. and 6.) > 5. Send initial ARP request only if IPv4 is enabled > 6. Send initial NDP request only if IPv6, NDP and ICMP are enabled > 7. Update description of "--no-ndp" in man page > 8. Fix and update description of "--no-icmp" in man page > 9. Break long line for MAC_BROADCAST By the way, same as most kernel subsystems, we commonly write change revisions after the marker for the end of commit message, say: text text text Tag: x Signed-off-by: y --- v3: - a - b - c or whatever variation one might find convenient. But it's nice to have it there, because it's not polluting the commit message, and at the same time it comes in the same email as the change. This is different from Linux kernel net.git / net-next.git submissions, where there's a general request to include version changes in commit messages, but I don't think that's a good idea, as sometimes net.git commit messages get rather long and unreadable because of that. > One final thought regarding 8.: > > Would it make sense to state in the man page that "--no-icmp" implies > "--no-ndp", and to implement it rigorously that way? Or, would that > be going to far? I'm not sure if it's going too far, but given that we currently disable just a bit of NDP on --no-icmp, I'd say it's better to make it consistent at this point with the strict interpretation you added in v4. -- Stefano