From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=V0lNI9Ec; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 52A495A0279 for ; Thu, 11 Sep 2025 17:45:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757605524; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OogS7q+3uIN3/2DsDcH1GWKI2WGQyhZOrGlIavYSEkk=; b=V0lNI9EcC1jj2Z+HwBxtoUyvcIxWvyyUlEfT5O++etsLc2bGMHfrYc/nP/FtFhps6iQli6 yEnhLkorr67lSgQKnlKWZGQMZnbTzL3YvLVFEPnAT797Ra5bycMkd6r7JL77Rdfyiysemg yaLx4Z6Fgd1Y/ML+s9ZVNmPIxG/qWb4= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-676-UNJcaVsJNOSLirheI9vEQA-1; Thu, 11 Sep 2025 11:45:20 -0400 X-MC-Unique: UNJcaVsJNOSLirheI9vEQA-1 X-Mimecast-MFC-AGG-ID: UNJcaVsJNOSLirheI9vEQA_1757605520 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3e26b5e3f41so488452f8f.1 for ; Thu, 11 Sep 2025 08:45:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757605519; x=1758210319; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=OogS7q+3uIN3/2DsDcH1GWKI2WGQyhZOrGlIavYSEkk=; b=RYzcG0Lg+mRrkJUBWLQtD4MNtCz9ofrr1pLksTwpkZyp+6cf0QJ3O9c8TqfrzeOwiu BJX0bldceuPvdVW10/bJCl0Bi8vWrx01cJACp23R5Sre8zlLKxppDf06vuDhdplINuql l2Vl8e/E4vo0sykpOyGwPZxP1X65Q218g8wIXR2IJ7ch1F2fEQ06sCSCAntxY8ZdntkN b2krQPlepvCdJTagxggjW4NuWjVkR9jcxrEE+kLIXFtVrp5PIsMLuH+ibEinkld0vc1Y iXxDvOXWyOWlks/Mj9JHgMclKbOK4AcHONFAU7Z8aaYycD3ZFciQ+tndick0hgfDbkjD Kykg== X-Gm-Message-State: AOJu0Ywadl8SNRt3nG3OagiCx5QsFuwxkAIKVaLYvIn1Q21g5bBLO35b 1drhZU9uDlbGa12aCTeAF8OzB1s/lqHNj+vQCTg3bpzQ2IG8X2r27UJxC0KLLS+1tZ/Gk+uGeHt izxgHz6W94KwgZuqhGSRTLyoIK/PB58kUBfdZkFu9ENtJ449ECwdwOA== X-Gm-Gg: ASbGncuwRnCfBpcOwypCYYEf5FpnE6Qi4VJIMOUMiZkNEWPJgV2gH37m2KyGf+d3Hl7 GzUdBtp3nSKRQt5IOlg6nQXC5aGxOtjhnxaJLiQfE7whKF5hgGdxJjZ6uWzVmFQO7qprHRazf+n Y8A+FHQr7Svb3CZ7CR2akGlsXiN7g29w7a/ckTIefqISHoXalKPsYQasNzD/5/3rPhEyPIeUuKr fE2x92nMUPRUbi0IjwGuwUrWqkjpnwz8SoZ0UCSmOXjzy+5y/k/Nb4LqX58RvDnhhfgZr2KvMOo uNvfI82p3Wojnt9fB4UCVTyZtgMLPICA3S93Ch/wCJ8EYqpMffZwwyBK487ttZVKSir+ X-Received: by 2002:a05:6000:178c:b0:3e7:63c5:9a9d with SMTP id ffacd0b85a97d-3e763c59fadmr883810f8f.6.1757605519520; Thu, 11 Sep 2025 08:45:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHhTtNeQrekqyWAghgXxvf3HVnkQaYfUceuFEp1Ci4rbesLfUn6gYlyuuYwO50dYPay3iXUJw== X-Received: by 2002:a05:6000:178c:b0:3e7:63c5:9a9d with SMTP id ffacd0b85a97d-3e763c59fadmr883796f8f.6.1757605519148; Thu, 11 Sep 2025 08:45:19 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3e760786cddsm3024062f8f.14.2025.09.11.08.45.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Sep 2025 08:45:18 -0700 (PDT) Date: Thu, 11 Sep 2025 17:45:17 +0200 From: Stefano Brivio To: Yumei Huang Subject: Re: [PATCH v3] tcp: Store the owner connections for flags frames Message-ID: <20250911174517.0526ad42@elisabeth> In-Reply-To: <20250911010936.6747-1-yuhuang@redhat.com> References: <20250911010936.6747-1-yuhuang@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: xCQzjLso3EljOIGTc4gDmIK6399ojWr-1ed6pGAXdVU_1757605520 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: VGWKLSMYS5L7ZYFWJIU47UQYS6SB57WO X-Message-ID-Hash: VGWKLSMYS5L7ZYFWJIU47UQYS6SB57WO X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, david@gibson.dropbear.id.au, boleyn.su@gmail.com, v@njh.eu, jmaloy@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 11 Sep 2025 09:09:36 +0800 Yumei Huang wrote: > There is an issue reported by Volker Diels-Grabsch and Boleyn Su. > A segmentation fault occurs when executing the following command: > > (sleep 0.1; ssh -p 22000 127.0.0.1) & passt -f -t 22000:22 > > It's caused by commit 78da088f7bab ("tcp: unify payload and flags > l2 frames array"). Fix it by storing the owner connections of flags > frames into tcp_frame_conns[] array. > > Reported-by: Volker Diels-Grabsch > Reported-by: Boleyn Su > Suggested-by: David Gibson > Fixes: 78da088f7bab ("tcp: unify payload and flags l2 frames array") > Signed-off-by: Yumei Huang Applied. -- Stefano