public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Volker Diels-Grabsch <v@njh.eu>
To: passt-dev@passt.top
Cc: Volker Diels-Grabsch <v@njh.eu>
Subject: [PATCH v5 4/5] Fix --no-icmp description and make it imply --no-ndp
Date: Thu, 11 Sep 2025 22:19:03 +0200	[thread overview]
Message-ID: <20250911201900.237677-8-v@njh.eu> (raw)
In-Reply-To: <20250911201900.237677-2-v@njh.eu>

Signed-off-by: Volker Diels-Grabsch <v@njh.eu>
---
 conf.c  | 3 +++
 passt.1 | 4 ++--
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/conf.c b/conf.c
index f47f48e..02e903b 100644
--- a/conf.c
+++ b/conf.c
@@ -2067,6 +2067,9 @@ void conf(struct ctx *c, int argc, char **argv)
 
 	isolate_user(uid, gid, !netns_only, userns, c->mode);
 
+	if (c->no_icmp)
+		c->no_ndp = 1;
+
 	if (c->pasta_conf_ns)
 		c->no_ra = 1;
 
diff --git a/passt.1 b/passt.1
index cef98b2..dd00b08 100644
--- a/passt.1
+++ b/passt.1
@@ -319,8 +319,8 @@ silently dropped.
 
 .TP
 .BR \-\-no-icmp
-Disable the ICMP/ICMPv6 echo handler. ICMP and ICMPv6 echo requests coming from
-guest or target namespace will be silently dropped.
+Disable the ICMP/ICMPv6 protocol handler. ICMP and ICMPv6 requests coming from
+guest or target namespace will be silently dropped. Implies \fB--no-ndp\fR.
 
 .TP
 .BR \-\-no-dhcp
-- 
@@ -319,8 +319,8 @@ silently dropped.
 
 .TP
 .BR \-\-no-icmp
-Disable the ICMP/ICMPv6 echo handler. ICMP and ICMPv6 echo requests coming from
-guest or target namespace will be silently dropped.
+Disable the ICMP/ICMPv6 protocol handler. ICMP and ICMPv6 requests coming from
+guest or target namespace will be silently dropped. Implies \fB--no-ndp\fR.
 
 .TP
 .BR \-\-no-dhcp
-- 
2.47.3


  parent reply	other threads:[~2025-09-11 20:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-11 20:18 [PATCH v5 1/5] Show debug message whenever we learn a new guest MAC address Volker Diels-Grabsch
2025-09-11 20:18 ` [PATCH v5 2/5] Improve clarity of comment Volker Diels-Grabsch
2025-09-11 20:19 ` [PATCH v5 3/5] Introduce constant MAC_BROADCAST Volker Diels-Grabsch
2025-09-11 20:19 ` Volker Diels-Grabsch [this message]
2025-09-11 20:19 ` [PATCH v5 5/5] Send an initial ARP and NDP request to resolve the guest IP address Volker Diels-Grabsch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250911201900.237677-8-v@njh.eu \
    --to=v@njh.eu \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).