From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=njh.eu Received: from mail.notjusthosting.com (mail.notjusthosting.com [IPv6:2a01:4f8:a0:516f:1::1]) by passt.top (Postfix) with ESMTPS id 382995A0271 for ; Thu, 11 Sep 2025 22:20:27 +0200 (CEST) Received: from echelon-telekom.c-base.org ([80.147.140.51] helo=vlap) by mail.notjusthosting.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1uwnmM-0006PA-RZ; Thu, 11 Sep 2025 22:20:26 +0200 From: Volker Diels-Grabsch To: passt-dev@passt.top Subject: [PATCH v5 4/5] Fix --no-icmp description and make it imply --no-ndp Date: Thu, 11 Sep 2025 22:19:03 +0200 Message-ID: <20250911201900.237677-8-v@njh.eu> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20250911201900.237677-2-v@njh.eu> References: <20250911201900.237677-2-v@njh.eu> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: CBSJ5APK2RV7ACDKAMQBXI2Z4IAY63BX X-Message-ID-Hash: CBSJ5APK2RV7ACDKAMQBXI2Z4IAY63BX X-MailFrom: v@njh.eu X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Volker Diels-Grabsch X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Signed-off-by: Volker Diels-Grabsch --- conf.c | 3 +++ passt.1 | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/conf.c b/conf.c index f47f48e..02e903b 100644 --- a/conf.c +++ b/conf.c @@ -2067,6 +2067,9 @@ void conf(struct ctx *c, int argc, char **argv) isolate_user(uid, gid, !netns_only, userns, c->mode); + if (c->no_icmp) + c->no_ndp = 1; + if (c->pasta_conf_ns) c->no_ra = 1; diff --git a/passt.1 b/passt.1 index cef98b2..dd00b08 100644 --- a/passt.1 +++ b/passt.1 @@ -319,8 +319,8 @@ silently dropped. .TP .BR \-\-no-icmp -Disable the ICMP/ICMPv6 echo handler. ICMP and ICMPv6 echo requests coming from -guest or target namespace will be silently dropped. +Disable the ICMP/ICMPv6 protocol handler. ICMP and ICMPv6 requests coming from +guest or target namespace will be silently dropped. Implies \fB--no-ndp\fR. .TP .BR \-\-no-dhcp -- 2.47.3