Re: [PATCH v5 1/5] Show debug message whenever we learn a new guest MAC address

[Stefano Brivio <sbrivio@redhat.com>]

On Thu, 11 Sep 2025 22:18:57 +0200
Volker Diels-Grabsch <v@njh.eu> wrote:

> Signed-off-by: Volker Diels-Grabsch <v@njh.eu>
> ---
>  tap.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tap.c b/tap.c
> index 7ba6399..3c08126 100644
> --- a/tap.c
> +++ b/tap.c
> @@ -1096,7 +1096,11 @@ void tap_add_packet(struct ctx *c, struct iov_tail *data,
>  		return;
>  
>  	if (memcmp(c->guest_mac, eh->h_source, ETH_ALEN)) {
> +		char bufmac[ETH_ADDRSTRLEN];
> +
>  		memcpy(c->guest_mac, eh->h_source, ETH_ALEN);
> +		debug("Guest MAC address: %s",

I think this should say "New guest MAC address", or maybe even "New
guest MAC address observed" (a bit verbose though).

Otherwise it's not really clear to users what we're referring to here.

> +		      eth_ntop(c->guest_mac, bufmac, sizeof(bufmac)));
>  		proto_update_l2_buf(c->guest_mac, NULL);
>  	}
>  

The rest of the series looks great to me!

-- 
Stefano