From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=eA295tFW; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 5F2605A0271 for ; Sat, 13 Sep 2025 12:16:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757758559; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SvPwgYD1eaXGsymqretEa9fZtYGnQpKKEdUSWvMubi4=; b=eA295tFWaVY0v6rGAuNyUf/St32X/oQuwrUq7SWLWb8++tyha80v8RDBwLaVa66Rz9Q1VO TfgafWqDNXrzdIQ5nQDN9dE3hcKPOeSiEHhoxyG2j87MPhmaET9FNwRMyzM9xlqjk/GIdA EZrpS2zyFYFE+5r6HmNd/9gyYiAK4aI= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-638-h7d4LAvHPXi7tJ-tqIHHpg-1; Sat, 13 Sep 2025 06:15:58 -0400 X-MC-Unique: h7d4LAvHPXi7tJ-tqIHHpg-1 X-Mimecast-MFC-AGG-ID: h7d4LAvHPXi7tJ-tqIHHpg_1757758557 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-45df9e11fc6so15495615e9.3 for ; Sat, 13 Sep 2025 03:15:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757758557; x=1758363357; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=SvPwgYD1eaXGsymqretEa9fZtYGnQpKKEdUSWvMubi4=; b=tCNRtOannN0fRfi2tWsS1QAafUPjm1LQQqAkxR4DC7Ae5Bu62fb7WVYJldpCEwVS1h Ooy/YhrqBWsyWeGERdm6hW+TqWcolhMfg3QfIe3OX2851dMdiWN0RYSsNXc9+o6mjm2C T3GZsxLA6BTSTF0Geg9NDKR5SUuQc492WLbsghiXJ/r7asMYLdfc1gvJqWlIJG6XK6Yz fPaljBKfDzjxZvgxhDZ5nLbi8KHwpuxdF9qLFfvqAU1bHjofLsj8u4Ar02pQGqnDAuUl iXXMKMgIQRhmFP1pUInpklH32Vl5B2iRTb5mMqw+sAHRANDtdkPQiikSSqFbXcRHixfX 8dIg== X-Gm-Message-State: AOJu0YwfZU2g30MQkUKSKT7ZwqiCmv1jobChm4qyud5JhtPlRWZYkwjU vPkHvZxWKHuebqG7tY1QPJPxVVgI5mZ49qlO1oGTCqZfstLXhE2HzIUVsc5fOxbrBvlm3VPxiSv PT0mBY4V+TwaLFjScjQFAfbmAKHysZBr5gpBW5B0hkd+9P+QG8UtVAw== X-Gm-Gg: ASbGncvRrRDP3h8ivdFLFSxVAEc+VkBGNDteJkkdLtPo+lnUHG721EJA0Q4PR3cUJgT F92keD4KmkMv5OXUZ+i4e5qIHxp9K+TPNtyuoexG26PCLRg4bwgl7WiFtS3yjAGOoxw7QZsg18u bjhZXggOT0qpwviuJsQ9wlzBn8zIi1pyg55a832eXjPLTxNEWAoBB/wnfotyIyXU0VGSG+qqSbJ qdbCrsU1hTuTzw7rT9FENObcJxry5GMh4PpRoWMjRMgoP5LMQIPIiolg6tjTYs+a8MkDWzqquhS Hw3zSX0/0KMmugwyf6CaFgMJcfUe8lIynrInIIlPWDbbqVxcYfwFL3RPP82o9pYjx5aa X-Received: by 2002:a05:600c:19d3:b0:45d:d609:1199 with SMTP id 5b1f17b1804b1-45f2121afa2mr61851525e9.30.1757758556740; Sat, 13 Sep 2025 03:15:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFcBPCwhdtxPRYQ244mOq2dAsecRTyb8SyRS11Qqmz2lcfoQ/vm3Aa74JY9CWQbMXhAHEQRIw== X-Received: by 2002:a05:600c:19d3:b0:45d:d609:1199 with SMTP id 5b1f17b1804b1-45f2121afa2mr61851315e9.30.1757758556280; Sat, 13 Sep 2025 03:15:56 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45e41b6dbdbsm79399755e9.22.2025.09.13.03.15.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 Sep 2025 03:15:55 -0700 (PDT) Date: Sat, 13 Sep 2025 12:15:45 +0200 From: Stefano Brivio To: Volker Diels-Grabsch Subject: Re: [PATCH v5 1/5] Show debug message whenever we learn a new guest MAC address Message-ID: <20250913121545.1d19ca10@elisabeth> In-Reply-To: <20250911201900.237677-2-v@njh.eu> References: <20250911201900.237677-2-v@njh.eu> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: zFg4a6mqpMn7KgkVVXfIfnbsvVED9ogQe7rdM_v6ZE8_1757758557 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: AENKR62JGXFQDGMPYNXB4UKSN3VM2S7I X-Message-ID-Hash: AENKR62JGXFQDGMPYNXB4UKSN3VM2S7I X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 11 Sep 2025 22:18:57 +0200 Volker Diels-Grabsch wrote: > Signed-off-by: Volker Diels-Grabsch > --- > tap.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/tap.c b/tap.c > index 7ba6399..3c08126 100644 > --- a/tap.c > +++ b/tap.c > @@ -1096,7 +1096,11 @@ void tap_add_packet(struct ctx *c, struct iov_tail *data, > return; > > if (memcmp(c->guest_mac, eh->h_source, ETH_ALEN)) { > + char bufmac[ETH_ADDRSTRLEN]; > + > memcpy(c->guest_mac, eh->h_source, ETH_ALEN); > + debug("Guest MAC address: %s", I think this should say "New guest MAC address", or maybe even "New guest MAC address observed" (a bit verbose though). Otherwise it's not really clear to users what we're referring to here. > + eth_ntop(c->guest_mac, bufmac, sizeof(bufmac))); > proto_update_l2_buf(c->guest_mac, NULL); > } > The rest of the series looks great to me! -- Stefano