Re: [PATCH] tap: Drop frames if no client connected

[Stefano Brivio <sbrivio@redhat.com>]

On Fri, 12 Sep 2025 10:45:30 +0800
Yumei Huang <yuhuang@redhat.com> wrote:

> > On Thu, Sep 11, 2025 at 11:54:25AM +0200, Stefano Brivio wrote:  
> >
> > [...]
> >
> > > - until a while ago, this couldn't happen at all. We were just blocking
> > >   the whole execution as long as the tap / guest / container interface
> > >   wasn't up and running.
> > >
> > >   I wonder when this changed and if it makes sense to go back to the
> > >   previous behaviour. I had just a quick look and I wonder if I
> > >   accidentally broke this in c9b241346569 ("conf, passt, tap: Open
> > >   socket and PID files before switching UID/GID").  
> BTW, I read the commit c9b241346569, it didn't change the behaviour.
> Before this, tap_sock_init() will call tap_sock_unix_init() without
> checking if c->fd_tap.

Sure, it didn't check c->fd_tap, but was it blocking the whole
execution?

I'm not sure, I just know that at some point we were blocking
everything. As David mentioned it's not possible with vhost-user
anyway, so it doesn't matter so much.

-- 
Stefano