From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=iplI8+01; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 800AF5A0271 for ; Mon, 15 Sep 2025 08:13:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757916802; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KbHf9MQH1WiDve/AHWJV+rrItjfdmifxDU593X86Pv4=; b=iplI8+01yUXhvhgz1QQ5p73pKXkMOAXJ9W0U+IGMHrUlVxq6GGA95VYVsQHKWYENkfbppO SsvKr5VxMIQvFjkjh2hV/19qC4SPaQtt5Sbqa/dHy5NQXi64V3/Y1JLoqulomEh77eQtvW dUzvdE6cLoHIlvnsywTmWSqeSjt91jA= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-163-CRyIgFEdNMaF4TecGe_WKg-1; Mon, 15 Sep 2025 02:13:20 -0400 X-MC-Unique: CRyIgFEdNMaF4TecGe_WKg-1 X-Mimecast-MFC-AGG-ID: CRyIgFEdNMaF4TecGe_WKg_1757916799 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3eb536ac039so170220f8f.1 for ; Sun, 14 Sep 2025 23:13:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757916799; x=1758521599; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=KbHf9MQH1WiDve/AHWJV+rrItjfdmifxDU593X86Pv4=; b=Rd9K/anmrIZ0g8yoD/qzEeWtDDaWp66+X/yVrrVnUCUzhcfItB9TTeRRv3c/6ehSKb tx0AkFQtrLuezGh2IZ5W469Ydf4nXm+k9LKijgwF0UrokpxXzr1wLsTz5I8b/sapKwqW 3UFX5G4GsdGWC6anI1v2noqX4r59PGG1y8fUsR7BU/QKih9GJje78UVifczKZj4a7Ur2 I+c9Bmg77ychawNw/hYUgg2Uc513Toorm1y4+T0JPxCm2rSMu0oaQ7oj3tID+gHXnNSN 64G1+5R7ThMF5fW/FsddEB6wcGWJpt948yW056uLkaFMvYVTn5oSILB4GUjsn4AhzWJY LhFw== X-Forwarded-Encrypted: i=1; AJvYcCXtZP5EBlcpxc2uK5/Z6+RhVyFlJWu3LRapQZQsYBKam+mEyw4pfjyQ3mvGPsMU0R7dqLQ75+VS/G4=@passt.top X-Gm-Message-State: AOJu0YyVlNo2pAzs8Wv1i7aNpIxxH4fpFeUvJgpaN53BQ1Vs1TkmofrR IlReHmUfDTv34fr7JL1E9uYYbeB/oBg0JwTC5LyqdlvLaEKSaFMUDR9KmGRxzsyeYw8pdjMfyco SVeSxRRDuRNd3GE3NJLRgSmkSZo3lTfBM2JNGemC8DZ+P3y15uzzjDQ== X-Gm-Gg: ASbGnctVUUZeuCvVVNtADYtfjCFI3fypjcczXNasT0b15MnyyCuQZMyr3d9tOyV8F3s 6KnC0ieua5bqZ8+LiWlStL0hdIy6fyUz61DXDkAGRQYNnsPfkvPLVHxkyGzn5/269FsH/BL1ISa IrMhDSHXSzty/Gi9Na1DjOX6C14ZRRqqWZ4ZFAi+IPRpzFZkbI/HYzHTzW03kOSfRHMHvCJBz72 wmzCHDMdi9hKOdJP5Efk4zh7BfRD6YfEcPqkCqG4dMjH0HgF3gROYXl2HVqXZ7zDvvZH1z69zDM 6K8RAf1gtfAVD2Z1FoVZ1otH3bppqeYa/PYab+aG2myhs/0rKv4= X-Received: by 2002:a05:6000:248a:b0:3eb:8a4b:c8e0 with SMTP id ffacd0b85a97d-3eb8a4bcbb3mr393042f8f.40.1757916799284; Sun, 14 Sep 2025 23:13:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFnaFeJwX1wxJYr5p+L/FApvEHsIEvIU3XZ7GQ0aPDrtt7etA1EMyePdBDuf4ZzKhMti5IcPA== X-Received: by 2002:a05:6000:248a:b0:3eb:8a4b:c8e0 with SMTP id ffacd0b85a97d-3eb8a4bcbb3mr392999f8f.40.1757916798729; Sun, 14 Sep 2025 23:13:18 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3e8892afc04sm8519685f8f.13.2025.09.14.23.13.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Sep 2025 23:13:17 -0700 (PDT) Date: Mon, 15 Sep 2025 08:13:16 +0200 From: Stefano Brivio To: Yumei Huang Subject: Re: [PATCH] tap: Drop frames if no client connected Message-ID: <20250915081316.31d31db9@elisabeth> In-Reply-To: References: <20250911085519.24395-1-yuhuang@redhat.com> <20250911115425.79eaaac5@elisabeth> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: jll-M51a2bT5IyyMtZ4cGxd1RDcjDb-cFBwQBuYgYCY_1757916799 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: EB2YYMGNYJBSLGUSELKFYGHBWI4GX5G6 X-Message-ID-Hash: EB2YYMGNYJBSLGUSELKFYGHBWI4GX5G6 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson , passt-dev@passt.top, lvivier@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 12 Sep 2025 10:45:30 +0800 Yumei Huang wrote: > > On Thu, Sep 11, 2025 at 11:54:25AM +0200, Stefano Brivio wrote: > > > > [...] > > > > > - until a while ago, this couldn't happen at all. We were just blocking > > > the whole execution as long as the tap / guest / container interface > > > wasn't up and running. > > > > > > I wonder when this changed and if it makes sense to go back to the > > > previous behaviour. I had just a quick look and I wonder if I > > > accidentally broke this in c9b241346569 ("conf, passt, tap: Open > > > socket and PID files before switching UID/GID"). > BTW, I read the commit c9b241346569, it didn't change the behaviour. > Before this, tap_sock_init() will call tap_sock_unix_init() without > checking if c->fd_tap. Sure, it didn't check c->fd_tap, but was it blocking the whole execution? I'm not sure, I just know that at some point we were blocking everything. As David mentioned it's not possible with vhost-user anyway, so it doesn't matter so much. -- Stefano